Re: [PATCHv2 5/4] nonblocking: reduce dependency

2011-04-17 Thread Bruno Haible
Hi Eric, > 2011-04-08 Eric Blake > > + nonblocking: reduce dependency > + * tests/test-nonblocking.c: Only test sockets when in use. > + * modules/nonblocking-tests (Depends-on): Drop socket. > + (Makefile.am): Link even if sockets are not present. > + * modules/pipe2-test

Re: [PATCH 4/4] pipe2: fix O_NONBLOCK support on mingw

2011-04-17 Thread Bruno Haible
Eric Blake wrote: > * lib/pipe2.c (pipe2) [WIN32]: Add O_NONBLOCK support. Thanks. The code can be simplified a bit. In particular, there is no need to call _pipe in two places, with different arguments. This should make it simpler to add support for more flags in the future. 2011-04-17 Bruno H

Re: [PATCH 1/4] nonblocking: provide O_NONBLOCK for mingw

2011-04-17 Thread Bruno Haible
Hi Eric, > * modules/nonblocking (Depends-on): Add open. This looks like a dependency that will surprise people. If a program needs the 'nonblocking' module for pipe or socket communication, why would it need to compile a replacement for open(). If a program uses open(), then it can use the open(

Re: [PATCH 1/4] nonblocking: provide O_NONBLOCK for mingw

2011-04-17 Thread Bruno Haible
Eric Blake wrote: > * lib/fcntl.in.h (O_NONBLOCK): Guarantee non-zero definition when > nonblocking module is in use. I think this deserves some comment. (It is documented in doc/posix-headers/fcntl.texi but sometimes we are looking at the code only.) 2011-04-17 Bruno Haible nonblock

[PATCH] init.sh docs: prefer AM_TESTS_SETUP to TESTS_ENVIRONMENT

2011-04-17 Thread Stefano Lattarini
Hello Gnulibers. The latest developement version of Automake has finally implemented the support for the developer-reserved variable `AM_TESTS_SETUP', which can be used to run initialization code and set environment variables for the testsuite (when the "parallel-tests" option is used) without inv

Re: non-blocking I/O tests

2011-04-17 Thread Bruno Haible
Hi Eric, There were indeed some mistakes in the test. Now I've debugged it and added a test for non-blocking sockets as well. As is, the socket test fails on Cygwin 1.5.x. After putting STDOUT_FILENO in non-blocking mode, get_nonblocking_flag reports that it is in non-blocking mode, but it still