Re: [PATCH] socklen: do not depend on sys_socket

2011-03-19 Thread Paul Eggert
Thanks for looking into this, Bruno. I altered the patch to reflect your comments, with the following further ideas: On 03/19/2011 06:49 AM, Bruno Haible wrote: >the 'Include' statement of the socklen module should be changed ... to > > #include > #if HAVE_SYS_SOCKET_H > #inc

Re: [PATCH] maint.mk: let po check work in VPATH build

2011-03-19 Thread Jim Meyering
Bruno Haible wrote: > Eric Blake wrote: >> >> + for file in $$($(VC_LIST_EXCEPT)) $(srcdir)lib/*.[ch]; do \ >> > >> > Is $(srcdir) expected to end in a slash or not? >> >> Not. Autoconf intentionally strips any trailing slash given by the >> user. Thanks for the catch (the idea of $(srcdir)

Re: [PATCH] socklen: do not depend on sys_socket

2011-03-19 Thread Bruno Haible
Hi Paul, > * m4/socklen.m4 (gl_PREREQ_TYPE_SOCKLEN_T): New macro, taken from > parts of gl_PREREQ_SYS_H_SOCKET. > (gl_TYPE_SOCKLEN_T): Require it instead of requiring > gl_PREREQ_SYS_H_SOCKET. Check for ws2tcpip.h only if > sys_socket is also used. > * m4/sys_socket_h.m4 (gl_PREREQ_SYS_H_SOCKET):

Re: [PATCH] socklen: do not depend on sys_socket

2011-03-19 Thread Bruno Haible
Paul Eggert wrote: > +   * modules/inet_ntop (Depends-on): Remove socklen, since > +   sys_socket is supposed to provide socklen_t and we already > +   depend on sys_socket. > +   * modules/inet_pton, modules/netdb: Likewise. This part is undoubtedly correct, after we document that

Re: [PATCH] maint.mk: let po check work in VPATH build

2011-03-19 Thread Bruno Haible
Eric Blake wrote: > >> +for file in $$($(VC_LIST_EXCEPT)) $(srcdir)lib/*.[ch]; do \ > > > > Is $(srcdir) expected to end in a slash or not? > > Not. Autoconf intentionally strips any trailing slash given by the > user. Thanks for the catch (the idea of $(srcdir)/lib/*.[ch] Then, I thin