Re: Relocation patch for cygwin

2011-02-28 Thread Charles Wilson
On 2/28/2011 5:23 PM, Bruno Haible wrote: > Thanks for the reminder. Three weeks ago, I concentrated on discussing the > support of UCS-4 characters (still working on that). I've added minor tweaks > (especially so as to avoid mixing the Win32 and the Cygwin approach), and > committed this: Thanks

Re: [PATCH] stdio: simplify by removing some files and dependencies

2011-02-28 Thread Paul Eggert
On 02/28/2011 02:00 PM, Bruno Haible wrote: I find it preferrable to commit independent changes as separate commits; it makes things clearer when analyzing the history later. OK, thanks; I did that.

Re: localcharset.c

2011-02-28 Thread Bruno Haible
Simon Josefsson wrote: > Make syntax-check complains about this in localcharset.c: > > if (old_res_ptr != NULL) > free (old_res_ptr); > > maint.mk: found useless "if" before "free" above I wouldn't use this rule in general, because whether th

Re: Relocation patch for cygwin

2011-02-28 Thread Bruno Haible
Hi Chuck, > Ping? Thanks for the reminder. Three weeks ago, I concentrated on discussing the support of UCS-4 characters (still working on that). I've added minor tweaks (especially so as to avoid mixing the Win32 and the Cygwin approach), and committed this: 2011-02-28 Corinna Vinschen(ti

Re: [PATCH] stdio: simplify by removing some files and dependencies

2011-02-28 Thread Bruno Haible
Hi Paul, > Here's a proposed patch to simplify stdio so that, for example, > Emacs and coreutils won't need m4/asm-underscore.m4 or > lib/stdio-write.c. The patch is fine and good. But actually it's two different, independent changes (even though they have the same motivation). I find it preferr

localcharset.c

2011-02-28 Thread Simon Josefsson
Make syntax-check complains about this in localcharset.c: if (old_res_ptr != NULL) free (old_res_ptr); maint.mk: found useless "if" before "free" above Any objections to simplifying this to 'free (old_res_ptr);'? /Simon