copyright year ranges and README.gnulib

2011-01-01 Thread John W. Eaton
On 1-Jan-2011, Karl Berry wrote: | Subject: Re: [PATCH 1/2] maint: new rule to update copyright year ranges | | This brings up a related topic that belatedly crossed my mind recently. | rms stated an extra requirement of making a statement in the README | about copyright ranges when they are

Re: [PATCH 1/2] maint: new rule to update copyright year ranges

2011-01-01 Thread Ralf Wildenhues
[ adding bug-autoconf, as install.texi is from Autoconf ] Hi Karl, and a happy new year everyone! * Karl Berry wrote on Sun, Jan 02, 2011 at 12:17:21AM CET: > Thanks. Those are probably worth excluding manually. > Let's hear what Karl has to say. > > Excluding INSTALL* and install.texi

copyright year ranges and README.gnulib

2011-01-01 Thread Karl Berry
Subject: Re: [PATCH 1/2] maint: new rule to update copyright year ranges This brings up a related topic that belatedly crossed my mind recently. rms stated an extra requirement of making a statement in the README about copyright ranges when they are used. Thus, ever since gnulib started using

[gbrk improvements 3/3] Rename uc_is_grapheme_cluster_break() to uc_is_grapheme_break().

2011-01-01 Thread Ben Pfaff
This aids consistency, since the "cluster" term is not used elsewhere. * lib/unigbrk.in.h: Update name. * lib/unigbrk/u16-grapheme-breaks.c: Update name. * lib/unigbrk/u16-grapheme-next.c: Update name. * lib/unigbrk/u16-grapheme-prev.c: Update name. * lib/unigbrk/u32-grapheme-breaks.c: Update name

[gbrk improvements 2/3] Remove u#-grapheme-len modules as too redundant with u#-grapheme-next.

2011-01-01 Thread Ben Pfaff
Remove module 'u8-grapheme-len' as too redundant with 'u8-grapheme-next'. * modules/unigbrk/u8-grapheme-len: Delete file. * modules/unigbrk/u8-grapheme-len-tests: Delete file. * lib/unigbrk.in.h: Remove prototype for deleted function. * lib/unigbrk/u8-grapheme-len.c: Delete file. * tests/unigbrk/te

[gbrk improvements 1/3] unigbrk.in.h: Fix typo: "ben" => "been".

2011-01-01 Thread Ben Pfaff
Reported by Bruno Haible. --- ChangeLog|5 + lib/unigbrk.in.h |4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index d021bde..c5a1cae 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-01-01 Ben Pfaff + + * unigbrk

[gbrk improvements 0/3] assorted improvements to unigbrk modules

2011-01-01 Thread Ben Pfaff
These changes were suggested by Bruno Haible at: http://permalink.gmane.org/gmane.comp.lib.gnulib.bugs/24565 I've already pushed these changes. Ben Pfaff (3): unigbrk.in.h: Fix typo: "ben" => "been". Remove u#-grapheme-len modules as too redundant with u#-grapheme-next. Rename u

Re: [unigbrk 2/2] unigbrk: New modules for grapheme clusters.

2011-01-01 Thread Ben Pfaff
Bruno Haible writes: > - The functions u#_grapheme_len and u#_grapheme_next are > redundant with each other: > u8_grapheme_len (s, n) ::= > (n == 0 ? 0 : (u8_grapheme_next (s, s + n) ? : end) - s). > I would not offer two APIs that are _that_ similar for > doing the same thing. (The

Re: [PATCH 1/2] maint: new rule to update copyright year ranges

2011-01-01 Thread Karl Berry
Thanks. Those are probably worth excluding manually. Let's hear what Karl has to say. Excluding INSTALL* and install.texi from this process sounds good to me. BTW, is there some reason why install.texi makes the nonstandard formatting setting: @firstparagraphindent insert Personally, I t

new u{8,16,32}-mb-prev-uc modules

2011-01-01 Thread Ben Pfaff
Hi Bruno. In November I sent you a module for backward iteration in UTF-8 strings for review: http://permalink.gmane.org/gmane.comp.gnu.libunistring.bugs/55 I didn't get a response. Maybe you were waiting for the equivalent modules for UTF-16 and UTF-32 that I had promised, or maybe you

Re: [unigbrk 2/2] unigbrk: New modules for grapheme clusters.

2011-01-01 Thread Bruno Haible
Hi Ben, Great work. But on this one I have a couple of comments: - The functions u#_grapheme_len and u#_grapheme_next are redundant with each other: u8_grapheme_len (s, n) ::= (n == 0 ? 0 : (u8_grapheme_next (s, s + n) ? : end) - s). I would not offer two APIs that are _that_ similar

Re: [PATCH 1/2] maint: new rule to update copyright year ranges

2011-01-01 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> Here's the whole thing: > > Thanks for showing it. The hunks I've looked at look all fine. Thanks for the review, Bruno. I've made one more change to the update-copyright rule, patch below, then pushed the change that results from running "make update-copyright".

Re: [PATCH 1/2] maint: new rule to update copyright year ranges

2011-01-01 Thread Bruno Haible
Hi Jim, > Here's the whole thing: Thanks for showing it. The hunks I've looked at look all fine. Bruno

Re: hexadecimal escape sequences

2011-01-01 Thread Paul Eggert
On 01/01/2011 10:14 AM, Bruno Haible wrote: > So that compiler did not understand '\a'. quotearg.c used to support pre-C89 compilers that did not understand '\a', using a configure-time test for HAVE_C_BACKSLASH_A, but that support was withdrawn in 2002, because we were assuming C89 compilers by

Re: abort on mingw

2011-01-01 Thread Ben Pfaff
Bruno Haible writes: >> > On mingw, >> > stdio buffers are not flushed when abort() is called, i.e. their contents >> > gets lost. >> >> Does this mean that mingw also fully buffers stderr? This is a >> violation of the C standard, which says, "As initially opened, >> the standard error stream

Re: hexadecimal escape sequences

2011-01-01 Thread Bruno Haible
Ben Pfaff wrote: > Wow. This is a gigantic bug that I don't see documented > anywhere. I can't reproduce it with the "cc" compilers I have access to right now. But it was apparently seen on HP-UX 11: [1] mentions a warning cc: "quotearg.c", line 275: warning 30: Character constant contains unde

Re: abort on mingw

2011-01-01 Thread Bruno Haible
Hi Ben, > > On mingw, > > stdio buffers are not flushed when abort() is called, i.e. their contents > > gets lost. > > Does this mean that mingw also fully buffers stderr? This is a > violation of the C standard, which says, "As initially opened, > the standard error stream is not fully buffered

Re: new modules for grapheme cluster breaking

2011-01-01 Thread Ben Pfaff
Bruno Haible writes: > One tiny improvement of your patches: In C source code, use octal escapes > instead of hexadecimal escapes. Some platform's cc compiler (IRIX 6.5 or > HP-UX 10.20 or something like that) supports only octal escapes correctly. Wow. This is a gigantic bug that I don't see d

Re: [unigbrk 1/2] unigbrk: Fix uc_graphemeclusterbreak_property(), add comprehensive test.

2011-01-01 Thread Ben Pfaff
Bruno Haible writes: >> +++ b/tests/unigbrk/test-uc-gbrk-prop.c >> ... >> + fprintf (stderr, "uc_graphemeclusterbreak_property(%#x) " >> + "yielded %s but should have been %s\n", >> + uc, graphemebreakproperty_to_string (retval), >> +

Re: [unigbrk 1/2] unigbrk: Fix uc_graphemeclusterbreak_property(), add comprehensive test.

2011-01-01 Thread Bruno Haible
Hi Ben, > +++ b/tests/unigbrk/test-uc-gbrk-prop.c > ... > + fprintf (stderr, "uc_graphemeclusterbreak_property(%#x) " > + "yielded %s but should have been %s\n", > + uc, graphemebreakproperty_to_string (retval), > + gra

Re: [PATCH 1/2] maint: new rule to update copyright year ranges

2011-01-01 Thread Bruno Haible
Hi Jim, >  doc/INSTALL                                        |    3 +-- >  doc/INSTALL.ISO                                    |    3 +-- >  doc/INSTALL.UTF-8                                  |    3 +-- These are automatically generated from doc/install.texi. I think Karl would need to update the

Re: new modules for grapheme cluster breaking

2011-01-01 Thread Bruno Haible
Hi Ben, > > "grapheme" or "grapheme cluster"? I'm a bit confused: The Unicode 3.0 > > book uses the term "grapheme" to denote the entity that users consider > > to be a single character, but UAX #29 nowadays calls it "grapheme cluster". > > I am being a little sloppy with terminology. My take-aw

[PATCH] version-etc: update the copyright year it reports

2011-01-01 Thread Jim Meyering
FYI, without this, coreutils' make syntax check was failing: >From 2d43094c0ef80723db75bfe5fc74f876113e0bc4 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 1 Jan 2011 11:08:18 +0100 Subject: [PATCH] version-etc: update the copyright year it reports * lib/version-etc.c (COPYRIGHT_YEAR): Up