Re: bison-generated code causes compilation failure on OpenBSD 4.7

2010-10-07 Thread Eric Blake
On 10/07/2010 03:19 PM, Jim Meyering wrote: Stepping back, malloc shouldn't even be declared here, since this skeleton code has already included stdlib.h. Agreed. This portion of bison output stems back to K&R days, when you couldn't guarantee things like malloc's declaration. But given tha

Re: bison-generated code causes compilation failure on OpenBSD 4.7

2010-10-07 Thread Jim Meyering
Jim Meyering wrote: > Hello, > > On an OpenBSD 4.7 system, building coreutils fails like this: > (noticed in prerelease testing) > > make[2]: Entering directory `/u/guest/meyering/coreutils-8.5.185-0ad44/lib' > CC parse-datetime.o > parse-datetime.c:590: error: conflicting types for

[PATCH] docs: update cygwin progress

2010-10-07 Thread Eric Blake
* doc/glibc-functions/mkostemp.texi (mkostemp): Added in cygwin 1.7.6. * doc/glibc-functions/mkostemps.texi (mkostemps): Likewise. * doc/posix-headers/fenv.texi (fenv.h): Added after cygwin 1.7.7. * doc/posix-functions/feclearexcept.texi (feclearexcept): Likewise. * doc/posix-functions/fegetenv.tex

Re: [diffutils-3.0] 9 of 78 tests failed on Haiku

2010-10-07 Thread Bruno Haible
[dropped bug-diffutils from CC] > > Haiku, like BeOS have O_BINARY and O_TEXT but they have no effect: > > http://www.mail-archive.com/bug-gnulib@gnu.org/msg12137.html Yes, and gnulib's binary-io.h undefines O_BINARY and O_TEXT on Haiku for this reason. > > --- diffutils-3.0/gnulib-tests/test-du

Re: [PATCH] parse-datetime: do some more renaming

2010-10-07 Thread Eric Blake
On 10/05/2010 06:00 PM, Paul Eggert wrote: On 10/05/10 14:00, Eric Blake wrote: Is that the correct historical name, or should this be worded: @code{parse_datetime} started life as @code{getdate}, as originally implemented... Perhaps that would be better. I don't know what its name was origi

Re: [PATCH] memmem, strstr, strcasestr: fix bug with long periodic needle

2010-10-07 Thread Eric Blake
On 10/05/2010 05:42 PM, Bruno Haible wrote: Hi Eric, - #if CYGWIN_VERSION_DLL_MAJOR>= 1007 + #if CYGWIN_VERSION_DLL_MAJOR>= 1007&& CYGWIN_VERSION_DLL_MINOR> 7 I think this conditional expression will evaluate to false for Cygwin 1.8.0, 1.9.5, and so on, which is not intended. Indeed. And

Re: compilation failure on freebsd8.0-p3 (acl-related?)

2010-10-07 Thread Jim Meyering
Bruno Haible wrote: ... > I'm therefore applying this; I hope it helps (I don't have a FreeBSD login). > > 2010-10-06 Bruno Haible > > string, sys_select: Avoid #including large headers unless necessary. > * lib/string.in.h: Don't include except on NetBSD. > * lib/sys_select.i

Re: [diffutils-3.0] 9 of 78 tests failed on Haiku

2010-10-07 Thread Jim Meyering
scott mc wrote: > Diffutils-3.0 builds ok on Haiku but the test suite did not. I made > patches to three of the test files as shown here: Thanks for the report and patches. I'm redirecting this to bug-gnulib, since those tests all come from that project, not diffutils directly. > ---