Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Gary V. Vaughan
On 3 Sep 2010, at 03:18, Jim Meyering wrote: > Gary V. Vaughan wrote: >> 1. gnulib_mk >> >> >>> # Name of the Makefile.am >>> gnulib_mk=gnulib.mk >> >> What is this for? The only use in the rest of the script is inside the >> slurp() function, who's purpose I cannot fathom: >> >>>

Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Gary V. Vaughan
Hi Eric, Thanks for your prompt response :) The fog is clearing a little already! On 3 Sep 2010, at 01:01, Eric Blake wrote: > On 09/02/2010 10:36 AM, Gary V. Vaughan wrote: >> Is gnulib bootstrap designed for reuse in other projects? > > Yes; I know that it is already shared among coreutils,

Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Gary V. Vaughan
Hi Jim, Thanks for the feedback. On 3 Sep 2010, at 13:05, Jim Meyering wrote: > Gary V. Vaughan wrote: >> 14. Updating >> >> >> There's no obvious way for bootstrap to update itself. Since we got to some >> lengths to install the `gnulib' subproject that it comes from, it should a

Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Jim Meyering
Gary V. Vaughan wrote: > 14. Updating > > > There's no obvious way for bootstrap to update itself. Since we got to some > lengths to install the `gnulib' subproject that it comes from, it should at > least be able to warn that it is out of date even if a self-update is not > possib

Re: [PATCH] strtod: work around IRIX 6.5 bug

2010-09-02 Thread Eric Blake
On 09/02/2010 09:35 AM, Tom G. Christensen wrote: On Wed, Sep 01, 2010 at 09:49:58PM -0600, Eric Blake wrote: IRIX mis-parses "1e 1" as 10.0 and "" instead of 1.0 and "e 1". Because the original parse may differ from the reparse in terms of whether the value overflows, we have to do an errno dan

Re: git log -> changelog

2010-09-02 Thread Eric Blake
On 09/02/2010 03:16 PM, Charles Wilson wrote: On 9/2/2010 5:08 PM, Eric Blake wrote: On 09/02/2010 03:00 PM, Charles Wilson wrote: Two people worked on a single patch, or someone submitted it, and then one of the people with commit access modified the patch slightly. The GCS says you should do

Re: git log -> changelog

2010-09-02 Thread Charles Wilson
On 9/2/2010 5:08 PM, Eric Blake wrote: > On 09/02/2010 03:00 PM, Charles Wilson wrote: >> Two people worked on a single patch, or someone submitted it, and then >> one of the people with commit access modified the patch slightly. The >> GCS says you should do this, in the ChangeLog: >> >>

git log -> changelog [was: [PATCH] Path conversion documentation]

2010-09-02 Thread Eric Blake
[adding bug-gnulib] On 09/02/2010 03:00 PM, Charles Wilson wrote: IF we want to use gitlog to create the ChangeLog, then either of these is fine with me. However, see below. iii) fix the gitlog entries -- if that's even viable? I don't think (iii) will work. You can play all sorts o

Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Gary V. Vaughan
And theres more... On 2 Sep 2010, at 23:36, Gary V. Vaughan wrote: > Is gnulib bootstrap designed for reuse in other projects? > > I'm finding it extremely difficult to understand a lot of the code, let alone > incorporate it into Libtool. I have some fixes for the obvious bugs, and a > lot of

Re: test-vc-cvs [was: IRIX failures]

2010-09-02 Thread Eric Blake
On 09/02/2010 08:25 AM, Eric Blake wrote: Next, your trace showed the cause of the first message: +mktempd_:51> template_length_=+mktempd_:1> wc -c +mktempd_:51> template_length_=' 16' +mktempd_:52> nx_=+mktempd_:1> echo gt-init.sh. +mktempd_:52> nx_=+mktempd_:1> wc -c +mktempd_:52> nx_=' 12' +m

Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Jim Meyering
Gary V. Vaughan wrote: > 1. gnulib_mk > > >> # Name of the Makefile.am >> gnulib_mk=gnulib.mk > > What is this for? The only use in the rest of the script is inside the > slurp() function, who's purpose I cannot fathom: > >> if test $file = Makefile.am && test "X$gnulib_mk" != X

[PATCH] tests: init.sh improvements for re-exec'ing with zsh

2010-09-02 Thread Eric Blake
Tom's IRIX setup had a broken bash, and proceeded to run zsh outside of POSIX mode. But trying to trace that setup proved difficult, since the re-exec lost tracing. * tests/init.sh: Borrow autoconf POSIX-mode sanitization. Pass -vx through shell re-exec. Reported by Tom G. Christensen. Signed-o

[PATCH] hash: fix safe_hasher const typo

2010-09-02 Thread Paul Eggert
I installed this as an obvious fix for a recently-installed typo. * lib/hash.c (safe_hasher): Result is pointer, not pointer to const; otherwise, there is a type error later. --- ChangeLog |6 ++ lib/hash.c |2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ChangeL

Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Jim Meyering
Gary V. Vaughan wrote: > Is gnulib bootstrap designed for reuse in other projects? > > I'm finding it extremely difficult to understand a lot of the code, > let alone incorporate it into Libtool. ... Hi Gary, You're right, bootstrap is not pretty. It has grown mostly by accretion. It is used in

Re: Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Eric Blake
On 09/02/2010 10:36 AM, Gary V. Vaughan wrote: Is gnulib bootstrap designed for reuse in other projects? Yes; I know that it is already shared among coreutils, grep, libvirt, and several other projects. However, improvements are certainly welcome. I'll tackle the questions I know an answer

Re: failure to build due to ignoring fwrite() result

2010-09-02 Thread Bruce Korb
Hi, On Thu, Sep 2, 2010 at 9:23 AM, Paul Eggert wrote: > Bruno's proposed changes are mostly good, but I have a few quibbles: > >> +Don't make the program ugly just to placate warnings from tools other >> +than those that you use on a daily basis. > > This isn't quite right.  Suppose a programmer

Failing to use gnulib bootstrap in libtool

2010-09-02 Thread Gary V. Vaughan
Is gnulib bootstrap designed for reuse in other projects? I'm finding it extremely difficult to understand a lot of the code, let alone incorporate it into Libtool. I have some fixes for the obvious bugs, and a lot of questions about the design choices, below. In short, it could use a complet

Re: failure to build due to ignoring fwrite() result

2010-09-02 Thread Paul Eggert
Bruno's proposed changes are mostly good, but I have a few quibbles: > +Don't make the program ugly just to placate warnings from tools other > +than those that you use on a daily basis. This isn't quite right. Suppose a programmer uses 'lint' on a daily basis? They they can make a program ugly

Re: test-vc-cvs [was: IRIX failures]

2010-09-02 Thread Tom G. Christensen
On Thu, Sep 02, 2010 at 08:25:51AM -0600, Eric Blake wrote: > On 09/02/2010 08:02 AM, Tom G. Christensen wrote: > > >echo $BASH_VERSION > >+ echo '3.1.16(1)-release' > >3.1.16(1)-release > >test $(echo y) = y || exit 1 > >cho y > >++ cho y > >bash: line 2: cho: command not found > >+ test = y > >b

Re: minimum perl version

2010-09-02 Thread Jim Meyering
Tom G. Christensen wrote: > On Thu, Sep 02, 2010 at 01:53:54PM +0200, Jim Meyering wrote: >> Sure. I've just pushed the following. >> Can someone confirm that 5.6.0 works, or even >> find what precise version is barely new enough? >> > I just tried the test on RHEL 2.1 with perl 5.6.1 > and it fai

Re: iswblank failure

2010-09-02 Thread Eric Blake
On 09/02/2010 07:21 AM, Ludovic Courtès wrote: --8<---cut here---start->8--- ./wctype.h:581:14: error: operator '||' has no right operand ./wctype.h:654:6: error: #if with no expression --8<---cut here---end--->8--- My guess

Re: minimum perl version

2010-09-02 Thread Tom G. Christensen
On Thu, Sep 02, 2010 at 01:53:54PM +0200, Jim Meyering wrote: > Sure. I've just pushed the following. > Can someone confirm that 5.6.0 works, or even > find what precise version is barely new enough? > I just tried the test on RHEL 2.1 with perl 5.6.1 and it fails in the same way. The test works

Re: [PATCH] strtod: work around IRIX 6.5 bug

2010-09-02 Thread Tom G. Christensen
On Wed, Sep 01, 2010 at 09:49:58PM -0600, Eric Blake wrote: > IRIX mis-parses "1e 1" as 10.0 and "" instead of 1.0 and "e 1". > Because the original parse may differ from the reparse in terms > of whether the value overflows, we have to do an errno dance. > > * lib/strtod.c (strtod): Reparse numbe

Re: iswblank failure

2010-09-02 Thread Tom G. Christensen
On Thu, Sep 02, 2010 at 03:21:46PM +0200, Ludovic Courtès wrote: > Hello! > > Bruno Haible writes: > > > 2010-09-02 Bruno Haible > > > > wctype: Avoid compilation error on IRIX 6.5.30. > > * lib/wctype.in.h (iswblank): Declare with a replacement if > > REPLACE_ISWBLANK is set. > >

Re: test-vc-cvs [was: IRIX failures]

2010-09-02 Thread Eric Blake
On 09/02/2010 08:02 AM, Tom G. Christensen wrote: > > zsh -vx ./test-vc-list-files-cvs.sh > > Sure, output here: http://jupiterrise.com/tmp/zsh_vx_test-vc-list-files-cvs.out Thanks. I definitely see a couple of problems. First, there's no 'emulate sh' command anywhere in the trace, and zsh

Re: test-vc-cvs [was: IRIX failures]

2010-09-02 Thread Tom G. Christensen
On Wed, Sep 01, 2010 at 08:04:50PM -0600, Eric Blake wrote: > On 09/01/2010 12:48 PM, Tom G. Christensen wrote: > >+ exec zsh ./test-vc-list-files-cvs.sh --no-reexec > > Tom, since the reexec lost all tracing, what about: > > zsh -vx ./test-vc-list-files-cvs.sh > Sure, output here: http://jupite

Re: iswblank failure

2010-09-02 Thread Ludovic Courtès
Hello! Bruno Haible writes: > 2010-09-02 Bruno Haible > > wctype: Avoid compilation error on IRIX 6.5.30. > * lib/wctype.in.h (iswblank): Declare with a replacement if > REPLACE_ISWBLANK is set. > * m4/wctype_h.m4 (gl_WCTYPE_H): Check also whether iswblank is > d

Re: test-vc-cvs

2010-09-02 Thread Jim Meyering
Eric Blake wrote: ... > Tom, since the reexec lost all tracing, what about: > > zsh -vx ./test-vc-list-files-cvs.sh > > Jim, I'm wondering if init.sh should propagate v and/or x as part of > the re-exec (certainly it would make it easier to get a full trace): > > opts= > case $- in > *v*) opts=v

Re: minimum perl version

2010-09-02 Thread Jim Meyering
Eric Blake wrote: > On 09/01/2010 12:48 PM, Tom G. Christensen wrote: +++ update-copyright.test-ex-stderr 2010-08-31 22:20:22.981772600 +0200 @@ -1,2 +1 @@ -update-copyright.test-ex.4: warning: FSF copyright statement not found -update-copyright.test-ex.5: warning: FSF copyr

Re: iswblank failure

2010-09-02 Thread Bruno Haible
Hi Eric, Eric Blake wrote: > >> Also, that > >> particular declaration at line 585 of wctype.h (line 282 of wctype.in.h) > >> is guarded by: > >> > >> #if ! @HAVE_ISWCNTRL@ || @REPLACE_ISWCNTRL@ > >> #elif ! @HAVE_ISWBLANK@ > >> > >> So knowing the value of all the HAVE_IS* and REPLACE_IS* from co

Re: module request: sockets.m4

2010-09-02 Thread Bruno Haible
Simon Josefsson wrote: > Yes this makes sense. Please push it! Done, I pushed it. Bruno