Re: _Exit detection

2010-07-12 Thread Eric Blake
On 07/12/2010 05:17 PM, Paul Eggert wrote: > On 07/12/10 14:44, Karl Berry wrote: >> Sorry for my ignorance, but what's the advantage for RCS of using _exit >> or _Exit instead of just plain exit() and thus eliminating the >> complications? > > Signals. Plain exit() isn't guaranteed to work in a

Re: [PATCH] strtod: make it more-accurate typically, and don't require libm

2010-07-12 Thread Paul Eggert
> - static double ldexp (double x, int exponent) { return x + exponent; } > + /* A dummy definition that will never be invoked. */ > + static double ldexp (double x, int exponent) { abort (); return 0.0; } The comment and "abort" are fine of course, but won't the "return 0.0" cause some compilers

Re: _Exit detection

2010-07-12 Thread Paul Eggert
On 07/12/10 14:44, Karl Berry wrote: > Sorry for my ignorance, but what's the advantage for RCS of using _exit > or _Exit instead of just plain exit() and thus eliminating the > complications? Signals. Plain exit() isn't guaranteed to work in a signal handler. Come to think of it, though, RCS co

Re: [PATCH] strtod: make it more-accurate typically, and don't require libm

2010-07-12 Thread Bruno Haible
Hi Paul, Paul Eggert wrote: > + #define ldexp dummy_ldexp > + static double ldexp (double x, int exponent) { return x + exponent; } This code looks fishy to someone who may not understand the intent of this definition. How about making it clearer, like this? --- lib/strtod.c.orig Mon Jul 12 2

Re: [PATCH] strtod: make it more-accurate typically, and don't require libm

2010-07-12 Thread Bruno Haible
Paul Eggert wrote: > +# FIXME: This implementation is a copy of printf-frexp.m4 and should be > shared. Indeed, it's bad for maintenance to have several macros which set the same autoconf cache variable, as they can easily evolve differently. I'm fixing these 4 occurrences: 2010-07-12 Bruno Ha

Re: _Exit detection

2010-07-12 Thread Karl Berry
Sorry for my ignorance, but what's the advantage for RCS of using _exit or _Exit instead of just plain exit() and thus eliminating the complications?

Re: _Exit detection

2010-07-12 Thread Thien-Thi Nguyen
() Bruno Haible () Mon, 12 Jul 2010 18:56:28 +0200 But now, I'm adding the module '_Exit'. So all you have to do is to request this module. Cool. I will try it and report any problems. thi

Re: _Exit detection

2010-07-12 Thread Thien-Thi Nguyen
() Paul Eggert () Mon, 12 Jul 2010 09:40:20 -0700 Perhaps there is some advantage to _Exit on non-free platforms but I wouldn't worry about that unless the topic comes up and you have a good expert on those platforms available. Thanks for the explanation. Were it not for just-minted

Re: [PATCH] (x)memcoll: minor tweaks

2010-07-12 Thread Paul Eggert
On 07/11/10 05:06, Bruno Haible wrote: > There is one API bug and two oddities in your patch: Thanks for your comments. The patch below tries to address them, although perhaps not always entirely in the way you asked. The documentation was misleading: the new function's size arguments count the

Re: _Exit detection

2010-07-12 Thread Bruno Haible
Thien-Thi Nguyen wrote: > GNU RCS uses gnulib module ‘stdlib’, which AFAICT does not > detect missing ‘_Exit’, e.g., when using dietlibc: > > https://savannah.gnu.org/bugs/?30372 > > I am unsure where/how to fix this and would be grateful for any tips. > Specifically: > > - Is this something gnu

Re: _Exit detection

2010-07-12 Thread Paul Eggert
On 07/12/10 04:11, Thien-Thi Nguyen wrote: > - Moving laterally, is it poor style to use ‘_Exit’ > (as opposed to plain old ‘_exit’) in the first place? For RCS, I would think so. _Exit is less portable and does not provide any advantages on GNU or on Unix-like platforms (it is functionally eq

[PATCH] strtod: make it more-accurate typically, and don't require libm

2010-07-12 Thread Paul Eggert
I ran into the following problem with "make check" on coreutils on 64-bit RHEL 5: CCLD test-sys_wait ../lib/libcoreutils.a(strtod.o): In function `rpl_strtod': /u/cs/fac/eggert/src/gnu/cu-strtod-bug/lib/strtod.c:249: undefined reference to\ `pow' and traced it down to the fact that test-strto

Re: [PATCH] unistr/u8-strchr: speed up searching for ASCII characters

2010-07-12 Thread Paolo Bonzini
On 07/12/2010 01:38 AM, Pádraig Brady wrote: On 11/07/10 15:20, Paolo Bonzini wrote: On 07/07/2010 03:44 PM, Pádraig Brady wrote: Subject: [PATCH] unistr/u8-strchr: speed up searching for ASCII characters * lib/unistr/u8-strchr.c (u8_strchr): Use strchr() for the single byte case as it was mea

_Exit detection

2010-07-12 Thread Thien-Thi Nguyen
GNU RCS uses gnulib module ‘stdlib’, which AFAICT does not detect missing ‘_Exit’, e.g., when using dietlibc: https://savannah.gnu.org/bugs/?30372 I am unsure where/how to fix this and would be grateful for any tips. Specifically: - Is this something gnulib can/should handle? - If not, what is t

Re: [BUG] priv-set on aix6.1

2010-07-12 Thread Gary V. Vaughan
Hi Bruno, On 11 Jul 2010, at 18:11, Bruno Haible wrote: >> I get a compilation failure in coreutils with the priv-set module >> which correctly detects a getppriv() function, but then tries to use >> it by including a non-existant header. >> >> From priv-set.h: >> >> #if HAVE_GETPPRIV >> >>