[PATCH] (x)memcoll: minor tweaks

2010-07-08 Thread Paul Eggert
I looked through that patch and installed the following relatively minor tweaks. The only nontrivial one is that I removed the abort() checks from memcoll0. Performance does matter with 'sort', and I think it unlikely that the abort() checks would catch important errors that relatively simple testi

Re: [PATCH] (x)memcoll: performance improvement when input is known to be NUL delimited.

2010-07-08 Thread Paul Eggert
On 07/08/10 14:23, Pádraig Brady wrote: > This has finally come through. > Can we apply this please. Done, here: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=9f31a7914f9d65fbc1225f503491dcc90e90c357 Thanks for contributing, Chen!

Re: [PATCH] (x)memcoll: performance improvement when input is known to be NUL delimited.

2010-07-08 Thread Pádraig Brady
On 21/04/10 11:20, Bruno Haible wrote: > Hi Chen, > >> I mailed my signature off a good month ago, it should be. Bruno, >> did you get anything from the FSF yet? > > No, I didn't get a notification from the FSF so far, and the copyright.list > on FSF machines (which was last modified yesterday) d

Re: [BUG] priv-set on aix6.1

2010-07-08 Thread Gary V. Vaughan
On 8 Jul 2010, at 21:55, Gary V. Vaughan wrote: > I guess the solution is to add checks for , > headers and change priv-set.h to read as follows (or similar): > > #if HAVE_GETPPRIV > # if HAVE_PRIV_H > # include > # else > # if HAVE_SYS_TYPES_H > # include > # endif > # if

[BUG] priv-set on aix6.1

2010-07-08 Thread Gary V. Vaughan
I get a compilation failure in coreutils with the priv-set module which correctly detects a getppriv() function, but then tries to use it by including a non-existant header. From priv-set.h: #if HAVE_GETPPRIV # include From the aix manual page for getppriv: Purpose Gets a privi

Re: [PATCH] unistr/u8-strchr: speed up searching for ASCII characters

2010-07-08 Thread Pádraig Brady
On 07/07/10 23:49, Pádraig Brady wrote: > On 07/07/10 17:07, Simon Josefsson wrote: >> Pádraig Brady writes: >> >>> +/* The following is equivalent to: >>> + return memmem (s, strlen(s), c, csize); >>> + but faster for long S with matching UC near the start, >>> + and also

Re: [PATCH] unistr/u8-strchr: speed up searching for ASCII characters

2010-07-08 Thread Pádraig Brady
On 08/07/10 04:24, Ralf Wildenhues wrote: > Hi Pádraig, > > * Pádraig Brady wrote on Wed, Jul 07, 2010 at 03:44:29PM CEST: >> Subject: [PATCH] unistr/u8-strchr: speed up searching for ASCII characters > >> --- a/lib/unistr/u8-strchr.c >> +++ b/lib/unistr/u8-strchr.c > >> uint8_t * >> u8_strchr