Re: Question about critical_factorization() in the Two-Way algorithm

2010-06-22 Thread Pádraig Brady
On 22/06/10 15:42, Eric Blake wrote: > On 06/22/2010 08:41 AM, Eric Blake wrote: >> On 06/22/2010 08:34 AM, Pádraig Brady wrote: >>> Cool, that's what I expected from the names. >>> So do we just need to move a docs around a little like: >>> >> >> Yes, that looks like an appropriate patch. Please

Re: Support script exceptions

2010-06-22 Thread Ralf Wildenhues
* Brett Smith wrote on Tue, Jun 22, 2010 at 03:26:19PM CEST: > On Mon, 2010-06-21 at 19:33 +0200, Ralf Wildenhues wrote: > > These scripts are all maintained in the Automake source tree; the > > canonical upstream for symlink-tree is the GCC source tree. > > Understood. I should explain: the reas

Re: Question about critical_factorization() in the Two-Way algorithm

2010-06-22 Thread Eric Blake
On 06/22/2010 08:34 AM, Pádraig Brady wrote: > Cool, that's what I expected from the names. > So do we just need to move a docs around a little like: > > diff --git a/doc/glibc-functions/memmem.texi b/doc/glibc-functions/memmem.texi > index c7e3d73..7d34817 100644 > --- a/doc/glibc-functions/memme

Re: Question about critical_factorization() in the Two-Way algorithm

2010-06-22 Thread Eric Blake
On 06/22/2010 08:41 AM, Eric Blake wrote: > On 06/22/2010 08:34 AM, Pádraig Brady wrote: >> Cool, that's what I expected from the names. >> So do we just need to move a docs around a little like: >> > > Yes, that looks like an appropriate patch. Please apply. I spoke too soon. We would also nee

Re: Question about critical_factorization() in the Two-Way algorithm

2010-06-22 Thread Pádraig Brady
On 22/06/10 15:09, Eric Blake wrote: > On 06/22/2010 03:18 AM, Pádraig Brady wrote: >> >> Note the docs for "memmem" say it fixes >> >> "This function returns incorrect values in some cases, such as when >>given an empty needle: glibc <= 2.0, Cygwin 1.5.x." >> >> Could that functionality be r

Re: Question about critical_factorization() in the Two-Way algorithm

2010-06-22 Thread Eric Blake
On 06/22/2010 03:18 AM, Pádraig Brady wrote: >> http://sourceware.org/bugzilla/show_bug.cgi?id=11607 > > Coincidentally, I was about to mail you about this :) > Thanks for pointing out that bug which I was unaware of. > > I'm currently working on multibyte enhancements to coreutils > and was usin

Re: Support script exceptions

2010-06-22 Thread Brett Smith
On Mon, 2010-06-21 at 19:33 +0200, Ralf Wildenhues wrote: > > First, the scripts we're talking about are: > > > > * compile > > * depcomp > > * elisp-comp > > * mdate-sh > > * missing > > * py-compile > > * symlink-tree > > * ylwrap > > These scripts are all maintained in the Automake source tree

Re: Support script exceptions

2010-06-22 Thread Paolo Bonzini
On 06/21/2010 07:33 PM, Ralf Wildenhues wrote: > After reviewing the intended uses of these scripts, and their licensing > history, we believe that an exception is not really necessary to allow > proprietary software developers to use the scripts in the ways we expect > them to. Thus, to kee

Re: Question about critical_factorization() in the Two-Way algorithm

2010-06-22 Thread Pádraig Brady
On 22/06/10 00:30, Eric Blake wrote: > Meanwhile, glibc bug 11607 already complains that the time spent on > factorization is extremely noticeable for short strings. I have not > benchmarked things myself (partly because I don't know how cache-line > effects would play into a benchmark), but do w