Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

2010-03-25 Thread Bruno Haible
Hi Eric, Eric Blake wrote: > diff --git a/lib/ctype.in.h b/lib/ctype.in.h > index ccf222d..fdf9e1e 100644 > --- a/lib/ctype.in.h > +++ b/lib/ctype.in.h > @@ -23,12 +23,12 @@ > * > */ > > -#ifndef _GL_CTYPE_H > - > #if __G

Re: new syntax-check rule for @acronym?

2010-03-25 Thread Eric Blake
On 03/24/2010 01:46 AM, Simon Josefsson wrote: >> syntax-check test for this seems useful, to foster harmonization across >> GNU packages. How about the patch below? >> >> I have no objection, certainly. > > I pushed the patch below. > > +# Don't use Texinfo @acronym{} as it is not a go

maintain.texi glitch

2010-03-25 Thread Eric Blake
I noticed this in the recent autoupdate of maintain.texi to gnulib: > include a suggested new wording for it, to help us consider the > -suggestion efficiently. We prefer a context diff to the > -...@file{maintain.texi} file, but if you don't have that file, you can > +suggestion efficiently. W

[PATCH 2/2] maint: use pragma consistently across replacement headers

2010-03-25 Thread Eric Blake
Several headers set #pragma GCC system_header prior to checking any multiple inclusion guards; maintenance is easiest if all replacement headers follow the same paradigm. * lib/ctype.in.h (system_header): Hoist for consistent placement. * lib/dirent.in.h (system_header): Likewise. * lib/errno.in.h

Re: visibility.m4

2010-03-25 Thread Simon Josefsson
Bruno, ping? Ok to push? /Simon Simon Josefsson writes: > Mike Gran writes: > >> Hello- >> >> If I use visibility.m4 on a platform with a recent GCC (4.x) on >> Cygwin, the visibility.m4 correctly discovers that gcc can compile with >> -fvisibility="hidden".  But, on Cygwin (and probably mo

lchmod cygwin failure

2010-03-25 Thread Simon Josefsson
Building in cygwin fails because: depbase=`echo test-fcntl-h-c++.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ g++ -DHAVE_CONFIG_H -I. -I. -I. -I.. -I./.. -I../gllib -I./../gllib -MT test-fcntl-h-c++.o -MD -MP -MF $depbase.Tpo -c -o test-fcntl-h-c++.o test-fcntl-h-c++.cc &&\ mv -f

Re: multiple definitions of __printf__

2010-03-25 Thread Bruno Haible
> +#if !DEPENDS_ON_LIBINTL /* avoid collision with intl/printf.c */ Also, your configure.ac should define DEPENDS_ON_LIBINTL if LIBINTL (determined by AM_GNU_GETTEXT) evaluates to non-empty. Bruno

Re: relaxing xnanosleep

2010-03-25 Thread Jim Meyering
Eric Blake wrote: > Right now, xnanosleep is GPL. But I don't see it calling exit() (which > is normally the reason why most x*() interfaces are GPL), and it would > be useful to use in libvirt. Any objections to relaxing the license to > LGPLv2+, including a technical reason I might be overlooki

Re: multiple definitions of __printf__

2010-03-25 Thread Bruno Haible
Hello, Michel Boaventura wrote: > I'm trying to compile a project which uses both gettext and gnulib. I'm > using mingw, and getting the above error: > > /home/michel/prof/pspp/sources/mingw/usr/i686-pc-mingw32/lib/libintl.a(printf.o): > In function `__printf__': > /home/arquivos/prof/pspp/sourc

Re: multiple definitions of __printf__

2010-03-25 Thread Michel Boaventura
This really only happens when I compile gettext with --disable-shared. I _think_ that gettext-0.17 doesn't have the gnulib version with this fix, since it is dated from 2007. The reason why I'm compiling it using --disable-shared is to avoid dll hell (http://en.wikipedia.org/wiki/DLL_hell) and to m

Re: relaxing xnanosleep

2010-03-25 Thread Bruno Haible
Eric Blake wrote: > sigaction would also need relaxing from LGPLv3+ to LGPLv2+ Fine with me (regarding my contributions to lib/sigaction.c). Bruno