[PATCH] Add hash_contains function

2010-02-13 Thread Colin Watson
I looked at converting man-db to use Gnulib's hash implementation rather than its own. One obstacle seems to be that there is one place where man-db cares about the difference between a key not being in the hash at all, and a key being in the hash but with a NULL value (in Perl syntax, the differe

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 2/13/2010 7:55 AM: >>> For negated character classes in shell case statements, POSIX says to use >>> [!a-z], not [^a-z]. >> >> I've made that change, too. >> Does it matter in practice? > > It matters for at least Solaris /bin/sh. > > $ /bin/sh -c '

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Eric Blake
According to Jim Meyering on 2/13/2010 7:55 AM: >> For negated character classes in shell case statements, POSIX says to use >> [!a-z], not [^a-z]. > > I've made that change, too. > Does it matter in practice? It matters for at least Solaris /bin/sh. $ /bin/sh -c 'case a in [^b]) echo yes;; *) e

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 2/13/2010 4:51 AM: >> Review/comments appreciated. Thanks for the prompt review! >> +# Given a directory name, DIR, if every entry in it that matches *.exe >> +# contains only the specified bytes (see the case stmt below), then print >> +# a space-

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Eric Blake
According to Jim Meyering on 2/13/2010 4:51 AM: > Review/comments appreciated. > > +# Given a directory name, DIR, if every entry in it that matches *.exe > +# contains only the specified bytes (see the case stmt below), then print > +# a space-separated list of those names and return 0. Otherwis

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Jim Meyering
Jim Meyering wrote: > Eric Blake wrote: >> According to Jim Meyering on 1/14/2010 1:08 AM: >>> Think of a set-up function that (when $EXEEXT is nonempty) >>> iterates through the *.$EXEEXT executables in a specified directory... >>> >>> create_exe_shim_functions () >>> { >>> case $EXEEXT in >>>