[PATCH] removing useless parentheses in cpp #define directives

2010-02-01 Thread Jim Meyering
FYI, continuing the clean-up, I ran this: git grep -E 'define.*\(\([^)]+\),' and fixed some of the culprits in the patch below. The following remain (from glibc), and I'll leave them as-is: lib/regex_internal.h:# define internal_function __attribute ((regparm (3), stdcall)) lib/str

Re: avoid some warnings

2010-02-01 Thread Eric Blake
According to Jim Meyering on 2/1/2010 6:56 AM: >> int (*f) (struct timeval *, GETTIMEOFDAY_TIMEZONE *); > > Sounds reasonable. By the way, I haven't forgotten that forkpty and openpty also need help to avoid signature check warnings: http://lists.gnu.org/archive/html/bug-gnulib/2009-12/msg00312.h

Re: avoid some warnings

2010-02-01 Thread Jim Meyering
Eric Blake wrote: > In the process of preparing to release m4 1.4.14, I noticed several > warnings when compiling on Fedora Core 12. I'm still working on silencing > the warning about gettimeofday having an incompatible second argument type > on glibc when using _GNU_SOURCE; I think the only sane

avoid some warnings

2010-02-01 Thread Eric Blake
In the process of preparing to release m4 1.4.14, I noticed several warnings when compiling on Fedora Core 12. I'm still working on silencing the warning about gettimeofday having an incompatible second argument type on glibc when using _GNU_SOURCE; I think the only sane solution is to define GETT

Re: [PATCH] Fix exit status of signal handlers in shell scripts

2010-02-01 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> Imagine that the first 10 tests pass, then each of the remaining ones is >> killed via e.g., SIGHUP. ... >> a naive search for "FAIL:" in the build output would find nothing. > > Yes, and it should be this way, IMO. Each time a user sees a "FAIL:", he >