Simon Josefsson wrote:
> diff --git a/tests/test-xalloc-die.sh b/tests/test-xalloc-die.sh
> index 03bad60..80d6208 100755
> --- a/tests/test-xalloc-die.sh
> +++ b/tests/test-xalloc-die.sh
> @@ -18,7 +18,7 @@
>
> . "${srcdir=.}/init.sh"; path_prepend_ .
>
> -test-xalloc-die 2> err > out
> +test
Bruno Haible writes:
> Hi Simon,
>
>> The tests that failed were:
>>
>> file_has_acl("tmpdir0") returned yes, expected no
>> FAIL: test-file-has-acl.sh
>
> This is normal and expected. In Cygwin 1.5.x, setacl and chown don't
> harmonize: if a program calls setacl after chown, the permissions are
Hi Simon,
> The tests that failed were:
>
> file_has_acl("tmpdir0") returned yes, expected no
> FAIL: test-file-has-acl.sh
This is normal and expected. In Cygwin 1.5.x, setacl and chown don't
harmonize: if a program calls setacl after chown, the permissions are
wrong, and if the program calls ch
Here is an interesting problem. This command
j...@mocca:~/src/gnulib master$ rm -rf m && gnulib-tool --create-testdir --dir
m getsubopt gethostname && cd m && ./configure --host=i586-mingw32msvc
--build=i686-pc-linux-gnu && make check
results in this error:
i586-mingw32msvc-gcc -DHAVE_CONFI
Bruno Haible writes:
> Simon Josefsson wrote:
>> I happened to run 'syntax-check' on some gnulib files, and notices this
>> in lib/striconv.c:
>>
>> if (result != NULL)
>> free (result);
>>
>> Bruno, do you object to removing the unnecessary if?
>
> It is in a part of the code whi
Btw, it's not a typo. When I write
if (result != NULL)
free (result);
it's either
- because it makes the logic clearer (you have to think less when you want
to verify that the code is correct), or
- an attempt to not assume too much from a system function, or
- an optimiza
Simon Josefsson wrote:
> I happened to run 'syntax-check' on some gnulib files, and notices this
> in lib/striconv.c:
>
> if (result != NULL)
> free (result);
>
> Bruno, do you object to removing the unnecessary if?
It is in a part of the code which is rarely executed, therefore th
FYI, a build of gnulib on cygwin on Windows XP just finished, a build
report here:
http://autobuild.josefsson.org/gnulib/log-201001121401712536000.txt
I'll try to set the machine up to build it once per day or so, depending
on how long it takes.
The tests that failed were:
file_has_acl("tmpdir0
I happened to run 'syntax-check' on some gnulib files, and notices this
in lib/striconv.c:
if (result != NULL)
free (result);
Bruno, do you object to removing the unnecessary if?
/Simon
Jim Meyering writes:
> Simon Josefsson wrote:
>> It would be useful to have 'syntax-check' never check certain
>> files/directories. This patch makes it possible to set VC_LIST_NEVER in
>> cfg.mk. Objections to pushing?
>>
>> /Simon
>>
>> 2010-01-12 Simon Josefsson
>>
>> * top/maint.mk
Simon Josefsson wrote:
> It would be useful to have 'syntax-check' never check certain
> files/directories. This patch makes it possible to set VC_LIST_NEVER in
> cfg.mk. Objections to pushing?
>
> /Simon
>
> 2010-01-12 Simon Josefsson
>
> * top/maint.mk (VC_LIST_EXCEPT): Filter list thr
Ben Pfaff writes:
> Eric Blake writes:
>
>> Meanwhile, based on the recent security hole in older automake,
>> should we bite the bullet and require automake 1.10.3 or better
>> (which in turn bumps the minimum autoconf requirement from 2.59
>> up to 2.60)?
>
> Debian stable has Automake 1.10.1.
Eric Blake writes:
> The problem is not old m4, but old autoconf. Which version are you using?
Ubuntu 8.04 has autoconf 2.61.
>> The problem is not old m4, but old autoconf.
>>
>> So, the right patch would be to move gl_AS_VAR_IF out of warnings.m4, and
> make
>> gnulib-common.m4 define a f
Hello,
throwing in my two cents:
* Ben Pfaff wrote on Tue, Jan 12, 2010 at 06:23:32PM CET:
> Eric Blake writes:
>
> > Meanwhile, based on the recent security hole in older automake,
> > should we bite the bullet and require automake 1.10.3 or better
> > (which in turn bumps the minimum autoconf
Pushed. This was triggered building via cygwin on Windows XP (I'm
setting up a Windows XP autobuilder..).
/Simon
---
ChangeLog |4
lib/stdio.in.h |2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index eae5a5c..e4aee22 100644
--- a/Cha
Pushed.
/Simon
---
ChangeLog |5 +
m4/gc.m4 |4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7e9fc3e..eae5a5c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2010-01-12 Simon Josefsson
+ * m4/gc.m4: Check if link
Eric Blake writes:
> Meanwhile, based on the recent security hole in older automake,
> should we bite the bullet and require automake 1.10.3 or better
> (which in turn bumps the minimum autoconf requirement from 2.59
> up to 2.60)?
Debian stable has Automake 1.10.1. In my opinion it would be sa
Eric Blake wrote:
> Simon Josefsson josefsson.org> writes:
>
>> I get errors from autoreconf when bootstrapping Libidn on a Ubuntu 8.04
>> LTS system, and removing the recent warn-on-use.m4 file fixes it. Is
>> there something in the file that requires a recent GNU M4? Ubuntu 8.04
>> has GNU M4
Eric Blake byu.net> writes:
> The problem is not old m4, but old autoconf.
>
> So, the right patch would be to move gl_AS_VAR_IF out of warnings.m4, and
make
> gnulib-common.m4 define a fallback AS_VAR_IF. I'll take care of that.
From: Eric Blake
Date: Tue, 12 Jan 2010 09:02:42 -0700
Subje
Simon Josefsson josefsson.org> writes:
> I get errors from autoreconf when bootstrapping Libidn on a Ubuntu 8.04
> LTS system, and removing the recent warn-on-use.m4 file fixes it. Is
> there something in the file that requires a recent GNU M4? Ubuntu 8.04
> has GNU M4 1.1.10, and according to
Simon Josefsson writes:
> I get errors from autoreconf when bootstrapping Libidn on a Ubuntu 8.04
> LTS system, and removing the recent warn-on-use.m4 file fixes it. Is
> there something in the file that requires a recent GNU M4? Ubuntu 8.04
> has GNU M4 1.1.10, and according to gnulib's DEPEND
I get errors from autoreconf when bootstrapping Libidn on a Ubuntu 8.04
LTS system, and removing the recent warn-on-use.m4 file fixes it. Is
there something in the file that requires a recent GNU M4? Ubuntu 8.04
has GNU M4 1.1.10, and according to gnulib's DEPENDENCIES 1.4.5 or later
should be OK
It would be useful to have 'syntax-check' never check certain
files/directories. This patch makes it possible to set VC_LIST_NEVER in
cfg.mk. Objections to pushing?
/Simon
2010-01-12 Simon Josefsson
* top/maint.mk (VC_LIST_EXCEPT): Filter list through VC_LIST_NEVER
regexp to
Pushed.
/Simon
---
ChangeLog|4
tests/test-xalloc-die.sh |2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index fac2f33..7e9fc3e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,8 @@
2010-01-12 Simon Josefsson
+
+
Mike Gran writes:
> Hello-
>
> If I use visibility.m4 on a platform with a recent GCC (4.x) on
> Cygwin, the visibility.m4 correctly discovers that gcc can compile with
> -fvisibility="hidden". But, on Cygwin (and probably most non-ELF) gcc does
> not actualy implement the visibility and emit
Hi Jim,
Jim Meyering writes:
> Ludovic Courtès wrote:
>> Surprisingly “make dist” has been failing on Hydra for some time[*]:
>>
>> gcc -std=gnu99 -I. -g -O2 -c -o exclude.o exclude.c
>> In file included from mbuiter.h:106,
>> from exclude.c:38:
>> mbchar.h: In function 'm
Hello,
(Apologies for not threading this right.)
I'm writing again to ask that stat-times be relicensed as LGPL, so Guile
can use it. stat-times is just a 200-line header relying on services of
LGPL modules, and its copyright has been assigned to the FSF. It seems
appropriate to me to assume that
Eric Blake writes:
> That said, here's a review of your proposed patch:
Thanks! Here is an updated patch that I will use in my projects.
/Simon
diff --git a/gltests/dup2.c b/gltests/dup2.c
index a4422bf..b9b329c 100644
--- a/gltests/dup2.c
+++ b/gltests/dup2.c
@@ -40,6 +40,7 @@ rpl_dup2 (int
Bruno Haible writes:
> Removing the mingw* case in the 'case' statement is wrong, because the * case
> executes an AC_CACHE_CHECK which would yield 'no' when cross-compiling to
> mingw
> or natively compiling to mingw via wine but yield 'yes' when natively
> compiling
> to mingw via Cygwin. In
Bruno Haible writes:
> Hi Simon,
>
>> These tests are fail unnecessarily easy, I think. See:
>>
>> $ rm -rf m && ./gnulib-tool --create-testdir --dir m --with-tests getlogin_r
>> && cd m && ./configure && nohup make check > log 2>&1
>
> Indeed, I did not think about this situation.
>
>> How ab
Hi Simon,
> These tests are fail unnecessarily easy, I think. See:
>
> $ rm -rf m && ./gnulib-tool --create-testdir --dir m --with-tests getlogin_r
> && cd m && ./configure && nohup make check > log 2>&1
Indeed, I did not think about this situation.
> How about this patch?
Still I'd like to
31 matches
Mail list logo
