Hi Bruno,
On Sat, 19 Dec 2009, Bruno Haible wrote:
> On 2009-12-15, we fixed a memory leak in the fprintf replacement. Since it
> is quite important to not reintroduce this bug in the future, I'm adding a
> unit test against it.
Thanks for taking care of all this. Sorry for my slow response.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 12/19/2009 5:46 PM:
>> -extern int dirfd (DIR const *dir) _GL_ARG_NONNULL ((1));
>> +extern int dirfd (DIR *dir) _GL_ARG_NONNULL ((1));
>
> Do you know of any dirfd implementation that actually modifies the
> pointed-to bu
Eric Blake wrote:
> According to POSIX, dirfd does not take a const argument. I'm applying this:
...
> Subject: [PATCH] dirfd: fix prototype
>
> Fix prototype to match POSIX.
>
> * lib/dirent.in.h (dirfd): Argument is not const, per POSIX.
> * lib/dirfd.c (dirfd): Likewise.
...
> -extern int dirfd
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 12/17/2009 10:16 PM:
> On further investigation, the problem doesn't appear to be quite as
> pervasive as I thought. It only happens when mtime is UTIME_OMIT; that
> is, when the call is only requesting a change in atime. I
Eric Blake wrote:
> > Therefore the last line is better changed to 'extern int _gl_warn_on_use'.
>
> OK, I'll make that change.
Additionally, in the module description modules/warn-on-use you can now use
the section
Applicability:
all
to indicate to gnulib-tool to treat it like 'link-warnin
Hi,
On 2009-12-15, we fixed a memory leak in the fprintf replacement. Since it
is quite important to not reintroduce this bug in the future, I'm adding a
unit test against it.
> - Limit the allowed total memory through a setrlimit call
> (cf. tests/test-printf-posix2.c).
> - Run the test
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 12/19/2009 7:55 AM:
>> For that matter, the temporary variable actual_size is not even needed. I'd
>> write the patch as just a 2-line addition:
>>
>> if (rname_limit != dest + 1)
>> rname = xrealloc (rname, dest - rname
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to POSIX, dirfd does not take a const argument. I'm applying this:
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public k
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 12/19/2009 4:30 AM:
> This is right for platforms for which the '_offset' field is declared as an
> 'fpos_t'. Thanks. But for the platforms where '_offset' is a scalar type
> (_off64_t on Cygwin), and where fpos_t might or
Eric Blake wrote:
> Sergey Poznyakoff gnu.org.ua> writes:
>
>> A user of tar reported a suboptimal memory usage by the
>> canonicalize_filename_mode. Attached is the patch he
>> proposed. Any comments?
>
> Who do we use as --author and/or reporter in the git commit? The patch first
> appeared o
Hi Simon,
> git clone git://git.savannah.gnu.org/libidn.git
> cd libidn
> gnulib-tool --import
Indeed, I reproduce. The reason is that the module 'arg-nonnull' ends up
among the main modules, not the tests modules. But the tests modules need
it as well. We have fixed this for 'link-warning' three
Hi Eric,
> #if defined __sferror || defined __DragonFly__ /* FreeBSD, NetBSD, OpenBSD,
> DragonFly, MacOS X, Cygwin */
> - fp_->_offset = pos;
> + /* Use a union, since on NetBSD, the compilation flags determine
> + whether fpos_t is typedef'd to off_t or a struct containing a
> + sing
Hello José,
> I updated the libgnupdf code to use the new 'nx' functions, caring
> about the returned value.
You're welcome :)
> Just a little-tiny typo fix:
Thanks, applied.
Bruno
13 matches
Mail list logo
