Re: __nonnull__ declarations

Bruno Haible wrote: > Hi Jim, all, >> >> I suggest you declare those functions with the "nonnull" attribute. >> >> I was referring to the functions in progname.h: >> >> set_program_name >> set_program_name_and_installdir > > More generally, it could make sense to mark many functions in gnulib,

Re: untabify?

Bruno Haible wrote: > I see that some of you are starting to untabify C source code (Jim in > lib/userspec.c, Eric in lib/pipe-safer.c). Is this a signal that we can > finally put those annoying TAB characters at rest? [1] I would love it. I would be happy to do that to all of gnulib. It is long o

Re: [bug-libunistring] stdbool issue on Solaris 8 with SunStudio 11

Hi Ludovic, > FYI the Hydra build farm at TU Deflt[*] now continuously builds > libunistring from Git using Gnulib from Git on 3 different platforms: > > http://hydra.nixos.org/jobset/gnu/libunistring > http://hydra.nixos.org/jobset/gnu/libunistring/all Thanks a lot for these pointers! The m

Re: fix mkostemp, add pipe2-safer

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/6/2009 5:18 PM: > - In set_cloexec_flag: You added a call to > dup2 (desc, desc) > But on a POSIX compliant system this is a no-op, since Not quite. It is the fastest one-syscall sequence for determining whether

Re: fix mkostemp, add pipe2-safer

Hi Eric, Great! I like the direction of your patches, unifying the support of *_safer and the native Woe32 requirements in a single API. I also like that the cloexec module now becomes usable for code that is portable to mingw; set_cloexec_flag is not in this category. Detailed review: - In dup_

Re: untabify?

Bruno Haible wrote: > Hi, > > I see that some of you are starting to untabify C source code (Jim in > lib/userspec.c, Eric in lib/pipe-safer.c). Is this a signal that we can > finally put those annoying TAB characters at rest? [1] I would love it. > > Just 2 questions: > > - Since GNU Emacs de

untabify?

Hi, I see that some of you are starting to untabify C source code (Jim in lib/userspec.c, Eric in lib/pipe-safer.c). Is this a signal that we can finally put those annoying TAB characters at rest? [1] I would love it. Just 2 questions: - Since GNU Emacs defaults have certainly not changed: Wha

Re: [PATCH] progname: don't segfault when argv is NULL

Hi Jim, > >> I suggest you declare those functions with the "nonnull" attribute. > > I was referring to the functions in progname.h: > > set_program_name > set_program_name_and_installdir The __nonnull__ attribute on these functions would help preventing or detecting the bug, because these

__nonnull__ declarations

Hi Jim, all, > >> I suggest you declare those functions with the "nonnull" attribute. > > I was referring to the functions in progname.h: > > set_program_name > set_program_name_and_installdir More generally, it could make sense to mark many functions in gnulib, from "acl.h" to "xvasprintf.

Re: [RFC] Add prototype pure-DFA matcher

[going back on the list] Thanks for this trimmed-down code. It at least gives an impression of what is going on in GNU regex. But I would still like to start from scratch for libunistring, 1. because I want code that works the same way in UTF-8 as in UTF-32, You can do that, I think, increm

Re: fix mkostemp, add pipe2-safer

Eric Blake wrote: > I'm currently testing the following series. Any thoughts or review on this? Good catch on mkostemp, and the many new tests are always welcome. As far as I can see (I didn't study the W32-specific bits), this all looks fine. I confirmed that it builds and all tests pass when

Re: [PATCH] progname: don't segfault when argv is NULL

Hi Bruno, Bruno Haible wrote: ... > Ad 1): >> I suggest you declare those functions with the "nonnull" attribute. > > Good idea. I reported this to glibc: > That is welcome, but I was referring to the functions in progname.h: set_program