Re: usleep

2009-11-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/18/2009 5:56 PM: > Yep. I'll fix it in my respin. Besides, I found out that rpl_nanosleep > needs the same bug fix, and not only that, but it has a logic bug - it > ignores EINTR, forcing the sleep to last until a fatal

Re: test-version-etc.sh fails when using the --with-packager-... configure options

2009-11-18 Thread Mike Frysinger
On Wednesday 18 November 2009 22:43:04 Eric Blake wrote: > According to Mike Frysinger on 11/18/2009 8:12 PM: > > the test-version-etc.sh falls over when configured with: > > --with-packager=Gentoo --with-packager-version='8.1 (p1)' > > > > ! COPYRIGHT Free Software Foundation, Inc. > > License G

Re: test-version-etc.sh fails when using the --with-packager-... configure options

2009-11-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding gnulib] According to Mike Frysinger on 11/18/2009 8:12 PM: > the test-version-etc.sh falls over when configured with: > --with-packager=Gentoo --with-packager-version='8.1 (p1)' > > ! COPYRIGHT Free Software Foundation, Inc. > License

Re: usleep

2009-11-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ludovic Courtès on 11/18/2009 4:35 PM: >> +{ >> + seconds -= limit; >> + unsigned int result = sleep (limit); > > This declaration-after-statement is a C99 thing. Isn’t it something > usually avoided in Gnulib? Yep. I'll

cvs access?

2009-11-18 Thread Karl Berry
Is the readonly cvs access to the git repo supposed to still be working? 'cause it isn't, for me. $ cvs [update aborted]: connect to [pserver.git.sv.gnu.org]:2401 failed: Connection timed out

Re: usleep

2009-11-18 Thread Ludovic Courtès
Hi, Eric Blake writes: > +unsigned int > +rpl_sleep (unsigned int seconds) > +{ > + const unsigned int limit = 49 * 24 * 60 * 60; > + while (limit < seconds) > +{ > + seconds -= limit; > + unsigned int result = sleep (limit); This declaration-after-statement is a C99 thing. Isn

Re: usleep (was: pending patches?)

2009-11-18 Thread Eric Blake
Eric Blake byu.net> writes: > I'm pushing this. Most systems these days still support usleep, even > though POSIX no longer requires it; even mingw has it; so the few > platforms where this implementation rounds up to the ceiling of the next > second should be rare (still correct behavior, just

Re: Error message doesn't say, "error"

2009-11-18 Thread Ben Pfaff
Bruce Korb writes: > On Wed, Nov 18, 2009 at 7:04 AM, Alfred M. Szmidt wrote: >> Which is exactly what AC_INIT does, it sets PACKAGE_VERSION, >> PACKAGE_NAME and other such variables that should be used instead. > > Except that it cannot get propagated from there until configure time. > I've fou

Re: Error message doesn't say, "error"

2009-11-18 Thread Bruce Korb
On Wed, Nov 18, 2009 at 7:04 AM, Alfred M. Szmidt wrote: >   > Bruce, how about this?  I'd actually rather see the whole >   > version.m4 mess be removed, but this is a decent fix for now. > >   A good and proper define-in-one-place fix for version stamps is a >   really good idea.  Sticking the o

Re: Error message doesn't say, "error"

2009-11-18 Thread Alfred M. Szmidt
> Bruce, how about this? I'd actually rather see the whole > version.m4 mess be removed, but this is a decent fix for now. A good and proper define-in-one-place fix for version stamps is a really good idea. Sticking the original version string into an AC_INIT() m4 macro is _not_ a

Re: [PATCH] utimens: remove invalid futimesat call

2009-11-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/8/2009 7:21 AM: > This fixes coreutils' final FreeBSD-8.0-rc2 test failure: And breaks the Solaris 10 futimens workaround. Since Solaris lacks futimens and futimes, the only way to change fd timestamps is via futimesat

Re: one more failure on Solaris 10

2009-11-18 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 11/18/2009 6:58 AM: which suggests this code in test-futimens.h needs to handle ENOTDIR: >>> Actually, this was a regression, caused when you disabled the futimens >>> fallback on the 8th. >> >> Really? >> This seems to be the change you'r

Re: one more failure on Solaris 10

2009-11-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/18/2009 6:58 AM: >>> which suggests this code in test-futimens.h >>> needs to handle ENOTDIR: >> Actually, this was a regression, caused when you disabled the futimens >> fallback on the 8th. > > Really? > This seems to

Re: one more failure on Solaris 10

2009-11-18 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 11/18/2009 1:02 AM: >> Not a serious problem, but annoying still to have one test failure: >> >> FAIL: test-utimens (exit: 134) >> >> which suggests this code in test-futimens.h >> needs to handle ENOTDIR: > > Actually, this was a regression, caused

Re: one more failure on Solaris 10

2009-11-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/18/2009 1:02 AM: > Not a serious problem, but annoying still to have one test failure: > > FAIL: test-utimens (exit: 134) > > which suggests this code in test-futimens.h > needs to handle ENOTDIR: Actually, this was a

Re: test-xalloc-die buglet

2009-11-18 Thread Simon Josefsson
Eric Blake writes: > I'm applying this: Tested and works fine for me, thanks! /Simon

one more failure on Solaris 10

2009-11-18 Thread Jim Meyering
Not a serious problem, but annoying still to have one test failure: FAIL: test-utimens (exit: 134) == test-futimens.h:48: assertion failed Here's strace output: stat64("test-utimens.tfile", 0xFFBFFA48)= 0 open64("test-utimens.tfile", O_WRONLY) = 3 ut