Re: ANSI C89 and gnulib

2009-09-21 Thread Eric Blake
Reuben Thomas sc3d.org> writes: > When building with -ansi -pedantic, I get warnings like this: > > In file included from printf-args.c:30: > printf-args.h:105: warning: ISO C90 does not support 'long long' The goal for gnulib is not necessarily strict C89 compliance, but rather using C89 plus

ANSI C89 and gnulib

2009-09-21 Thread Reuben Thomas
Hi, I'm sorry, I have a memory of asking about this before, but I can't after much searching find the previous correspondence, if any. When building with -ansi -pedantic, I get warnings like this: In file included from printf-args.c:30: printf-args.h:105: warning: ISO C90 does not support 'long

Re: symlink/readlink and trailing slash

2009-09-21 Thread Eric Blake
Ben Pfaff cs.stanford.edu> writes: > > + size_t len = strlen (name); > > + if (name[len - 1] == '/') > > +{ > > If name is "" then the "if" statement will reference name[-1]. Thanks. I've rebased my working copy to do: if (len && name[len - 1] == '/') as well as audited other modules w

Re: symlink/readlink and trailing slash

2009-09-21 Thread Ben Pfaff
Eric Blake writes: > +/* Create a symlink, but reject trailing slash. */ > +int > +rpl_symlink (char const *contents, char const *name) > +{ > + size_t len = strlen (name); > + if (name[len - 1] == '/') > +{ If name is "" then the "if" statement will reference name[-1]. > +int > +main ()

progreloc broken on cygwin 1.7

2009-09-21 Thread Eric Blake
Bruno, the progreloc file is broken on cygwin 1.7, because it uses cygwin_conv_to_posix_path. As of cygwin 1.7, longer filenames are supported, so this API is deprecated because it has no way to prevent silent buffer overflow. Cygwin 1.7 adds the new API cygwin_conv_path to solve the shortcom