Re: CLISP build fails in mktime

2009-09-16 Thread Bruno Haible
Hi, On 2009-08-30 I asked Paul Eggert: > static inline time_t > ydhms_diff (long int year1, long int yday1, int hour1, int min1, int sec1, > int year0, int yday0, int hour0, int min0, int sec0) > { > verify (C99_integer_division, -1 / 2 == 0); > verify (long_int_year_and_yday_are_wid

time_t on NetBSD/i386

2009-09-16 Thread Hasso Tepper
time_t is 64 bits in recent NetBSD versions even on i386 platform, therefore these assertations fail on it: in lib/mktime.c: verify (long_int_year_and_yday_are_wide_enough, INT_MAX <= LONG_MAX / 2 || TIME_T_MAX <= UINT_MAX); in lib/getdate.y: verify (LONG_MIN <= TYPE_MINIMUM (time_t) && TYPE

Re: canonicalize-lgpl bug

2009-09-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/16/2009 9:11 AM: >> I've reached this point in reading the patches. >> So far they look fine. >> I will read the remainder, and test tomorrow. > > I'll try and rebase my series before then. Now rebased: git pull git://re

improve unlink on Solaris

2009-09-16 Thread Eric Blake
I'm working on a patch to fix unlink("file/") on Solaris 9. But as a prerequisite (to avoid anyone corrupting their file system if running the unit test as root, and accidentally unlinking an empty directory), I noticed that mingw failed to compile unlinkdir.c due to a missing geteuid. This wo

improve stat on mingw, Solaris

2009-09-16 Thread Eric Blake
As promised, here's another patch series I'm working on. I need to test it further before committing, especially to see if fstatat on Solaris 9 needs the same help (I have easy access to Solaris 8 and 10, but not to Solaris 9; Solaris 8 lacks *at functions, and Solaris 10 fixed many (but not al

Re: mingw remove bug

2009-09-16 Thread Eric Blake
Jim Meyering meyering.net> writes: > > Meanwhile, the rmdir-errno module, in use by coreutils until today, guessed > > wrong for cross-compilation to Solaris (where rmdir fails with EEXIST, not > > ENOTEMPTY, on a populated directory); now that coreutils no longer uses the > > module [1], I see n

Re: [PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-16 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: >> FYI, here's the new test, in case anyone feels like reviewing: >> >> +static struct posixtm_test T[] = >> + { >> +{ "12131415.16", 13, " 1039788916 Fri Dec 13 14:15:16 2002" }, >> +{ "12131415.16", 13, " 1039788916 Fri D

Re: mingw remove bug

2009-09-16 Thread Jim Meyering
Eric Blake wrote: > Eric Blake byu.net> writes: >> > I'm arguing that the second program should also report "No such >> > file or directory". >> >> Ah, so for 'foo/', the code should distinguish between ENOENT and ENOTDIR, >> based on whether 'foo' exists. I'll update the patch and test according

Re: Daily snapshot fails to build with external gettext

2009-09-16 Thread Ralf Wildenhues
* Eric Blake wrote on Wed, Sep 16, 2009 at 07:53:21PM CEST: > Tom G. Christensen writes: > > Undefined first referenced > > symbol in file > > libintl_gettext ../gllib/libgnu.a(xalloc-die.o) > But thinking about it more, since

Re: Daily snapshot fails to build with external gettext

2009-09-16 Thread Eric Blake
Tom G. Christensen jupiterrise.com> writes: > Once again the snapshot is broken when using external gettext: > gcc -std=gnu99 -g -O2 -L/usr/tgcware/lib -Wl,-R,/usr/tgcware/lib > -Wl,-z,ignore -o test-parse-duration test-parse-duration.o ../gllib/libgnu.a - lm > Undefined f

Re: mingw remove bug

2009-09-16 Thread Eric Blake
Eric Blake byu.net> writes: > > I'm arguing that the second program should also report "No such > > file or directory". > > Ah, so for 'foo/', the code should distinguish between ENOENT and ENOTDIR, > based on whether 'foo' exists. I'll update the patch and test accordingly. I'm taking a step

Re: [PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-16 Thread Jim Meyering
Paolo Bonzini wrote: >> { "12131415.16", 13, " 1039788916 Fri Dec 13 14:15:16 2002" }, >> { "12131415.16", 13, " 1039788916 Fri Dec 13 14:15:16 2002" }, > > Uhm, why 2002? You could pre-generate all possible outputs from 2009 > to 2038 and only one of them will be checked.

Re: [PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-16 Thread Paolo Bonzini
{ "12131415.16", 13, " 1039788916 Fri Dec 13 14:15:16 2002" }, { "12131415.16", 13, " 1039788916 Fri Dec 13 14:15:16 2002" }, Uhm, why 2002? You could pre-generate all possible outputs from 2009 to 2038 and only one of them will be checked. Paolo

Re: [PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-16 Thread Eric Blake
Jim Meyering meyering.net> writes: > FYI, here's the new test, in case anyone feels like reviewing: > > +static struct posixtm_test T[] = > + { > +{ "12131415.16", 13, " 1039788916 Fri Dec 13 14:15:16 2002" }, > +{ "12131415.16", 13, " 1039788916 Fri Dec 13 14:15:16 2002" }, I

Re: canonicalize-lgpl bug

2009-09-16 Thread Eric Blake
Jim Meyering meyering.net> writes: > > [3/11] canonicalize: don't lose errno > > glibc still has a bug in realpath/c_f_n where errno could be inadvertently > > changed by a call to free() during an error return, but canonicalize-lgpl was > > immune, and now canonicalize is fixed. I guess

Re: [PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-16 Thread Jim Meyering
Jim Meyering wrote: > Paolo Bonzini wrote: Going backwards from "cal 1 1" you can see that in the Julian calendar 01-Jan- was a Thursday, but that's not so relevant. However cal can help seeing that 01-Jan- is a Saturday in Gregorian proleptic calendar (i.e. ex

Re: canonicalize-lgpl bug

2009-09-16 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: >> > Eric Blake (6): >> > canonicalize-lgpl: reject non-directory with trailing slash >> > stdlib: sort witness names >> > canonicalize: leave canonicalize_file_name to canonicalize-lgpl >> > canonicalize-lgpl: use nati

Re: [PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-16 Thread Jim Meyering
Paolo Bonzini wrote: >>> Going backwards from "cal 1 1" you can see that in >>> the Julian calendar 01-Jan- was a Thursday, but that's not so >>> relevant. >>> >>> However cal can help seeing that 01-Jan- is a Saturday in >>> Gregorian proleptic calendar (i.e. extending Gregorian calendar b