Re: mingw remove bug

2009-09-14 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ben Pfaff on 9/14/2009 8:42 PM: > > I'm arguing that the second program should also report "No such > file or directory". Ah, so for 'foo/', the code should distinguish between ENOENT and ENOTDIR, based on whether 'foo' exists. I'll upd

Re: mingw remove bug

2009-09-14 Thread Ben Pfaff
Eric Blake writes: > According to Ben Pfaff on 9/14/2009 5:51 PM: >>> + /* Mingw remove("file/") fails with EINVAL, instead of the required >>> + ENOTDIR. */ >>> + if (ISSLASH (name[len - 1])) >>> +{ >>> + errno = ENOTDIR; >>> + return -1; >>> +} >> >> I believe that thi

Re: mingw remove bug

2009-09-14 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ben Pfaff on 9/14/2009 5:51 PM: >> + /* Mingw remove("file/") fails with EINVAL, instead of the required >> + ENOTDIR. */ >> + if (ISSLASH (name[len - 1])) >> +{ >> + errno = ENOTDIR; >> + return -1; >> +} > > I b

Re: mingw remove bug

2009-09-14 Thread Ben Pfaff
Eric Blake writes: > + if (lstat (name, &st) == 0 && S_ISDIR (st.st_mode)) > +{ > + /* Mingw rmdir("empty/.") mistakenly succeeds. */ > + while (ISSLASH (name[len - 1])) > +len--; > + if (name[len - 1] == '.' && (1 == len || ISSLASH (name[len - 2]))) > +{ > +

mingw remove bug

2009-09-14 Thread Eric Blake
mingw remove() complies with C89, but not with POSIX. I'll be committing this shortly (actually, first I probably need to commit a stat module, to make up for the fact that both mingw rmdir("dir") and rmdir("dir/") can succeed, even when one of stat("dir") and stat("dir/") fails, depending on w

Re: [PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-14 Thread Paolo Bonzini
--- - 2009-09-14 14:32:58.934253776 +0200 +++ in 2009-09-14 14:32:58.930840392 +0200 @@ -1,6 +1,6 @@ -12131415.16 13 1260713716 Sun Dec 13 14:15:16 2009 -12131415.16 13 1260713716 Sun Dec 13 14:15:16 2009 -0101.00 13 -62167219200 Sat Jan

[PATCH] posixtm: don't reject a time with "60" as the number of seconds

2009-09-14 Thread Jim Meyering
This patch is to make it so touch -t works with a time stamp ending in ".60". Without this change, "touch -t 200901010800.60 file" would fail. Note that the change below makes a recursive call to posixtime. That may not be the most efficient, but I suspect this case is relatively unusual and I'd

Re: [PATCH] build: don't try to run autoheader if we don't use it

2009-09-14 Thread Jim Meyering
Ralf Wildenhues wrote: > * Paolo Bonzini wrote on Wed, Sep 09, 2009 at 09:22:56AM CEST: >> On 09/08/2009 10:25 PM, Jim Meyering wrote: >> >I wanted this change in vc-dwim, since it doesn't use autoheader: >> >I'd rather skip autoheader than add an unnecessary AC_CONFIG_HEADERS. >> >> Although obsol