Re: canonicalize-lgpl bug

2009-09-11 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/11/2009 4:35 PM: > [3/11] canonicalize: don't lose errno > glibc still has a bug in realpath/c_f_n where errno could be inadvertently > changed by a call to free() during an error return, but canonicalize-lgpl was >

Re: canonicalize-lgpl bug

2009-09-11 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: > >> > I noticed that glibc has applied some fixes to canonicalize.c that we were >> > missing; and sure enough, was able to enhance the testsuite to trip these >> > bugs. They also applied some assert's proving that their optimization to > a

Re: canonicalize-lgpl bug

2009-09-11 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/10/2009 12:21 PM: > Hmm, on thinking about this more, there are probably existing Linux machines > where glibc canonicalize_file_name is broken (fails to detect ENOTDIR > on "file/"), and therefore we need to replace it.

[PATCH] announce-gen: include [$release_type] in emitted Subject:

2009-09-11 Thread Jim Meyering
I noticed that I hadn't been consistently including [stable] or [beta] indications in the Subject of release announcements. That's because I'd been adding them manually. Now it's automatic: >From 5e04fd8dbc859fa3dcb2de9cd3279df80bd3418b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 11 S