Re: definition of NULL

2009-08-12 Thread Ralf Wildenhues
Hello, * Eric Blake wrote on Wed, Aug 12, 2009 at 11:45:26PM CEST: > Bruno Haible clisp.org> writes: > > The definition of NULL is a particularly thorny area, because so many > > headers > > use it and so many headers define it. I don't think it's worth the trouble - > > It wasn't _that_ much t

Re: getopt: make declaration available from

2009-08-12 Thread Bruno Haible
Eric Blake wrote: > > POSIX specifies that getopt() and the four variables optarg etc. should be > > declared in . But gnulib provides them only in . This > > fixes it. > > POSIX doesn't require . How about we also change the getopt module > to change the recommended Include: line over to ? POS

new modules getopt-posix, getopt-gnu

2009-08-12 Thread Bruno Haible
There is quite some confusion in the getopt module about which functionality requires which replacement. For example, while mingw fails to provide a working POSIX compliant getopt() function, systems like MacOS X, Cygwin, HP-UX, Solaris provide this but fail in the GNU compatibility section. So a p

getopt needs extensions

2009-08-12 Thread Bruno Haible
According to POSIX, should declare optarg, optind, etc. But on Solaris, the system header does this only if __EXTENSIONS__ is defined. This makes its use in gnulib automatic: 2009-08-12 Bruno Haible Ensure that optarg etc. get declared by . * m4/getopt.m4 (gl_GETOPT_CHECK_HEA

Re: definition of NULL

2009-08-12 Thread Eric Blake
Bruno Haible clisp.org> writes: > > I argue that NetBSD's definition of NULL is thus buggy > > Regarding POSIX, with XSH 2.1.2.(1), you are probably right. > > > we should add gnulib check and config.h workaround for it. > > The definition of NULL is a particularly thorny area, because so many

Re: Tests failing to build with external getttext

2009-08-12 Thread Bruno Haible
Tom G. Christensen wrote: > On Solaris 2.6 building the daily snapshot fails due to missing symbols > in some of the tests: > Undefined first referenced > symbol in file > libintl_gettext ../gllib/libgnu.a(pipe-filter-gi.o) > Un

Re: update-copyright vs. compressed years

2009-08-12 Thread Karl Berry
+Copyright (C) 1996, 2000, 2001, 2005, 2007, 2008-2009 Free Software Perhaps update-copyright could detect the convention being used, to placate Jim :). Failing that, pushing Jim's willful decision to compress years into update-copyright seems like the wrong move to me :). I've never seen an

update-copyright vs. compressed years

2009-08-12 Thread Eric Blake
In testing out the new update-copyright script on autoconf, I noticed the following conversion: -Copyright (C) 1996, 2000, 2001, 2005, 2007, 2008 Free Software +Copyright (C) 1996, 2000, 2001, 2005, 2007, 2008-2009 Free Software Foundation, Inc. In my opinion, this looks ugly for its inconsiste

Re: gl_GETOPT_SUBSTITUTE gone

2009-08-12 Thread Sergey Poznyakoff
Bruno Haible ha escrit: > Oops, I did not see this dependency. I'm restoring it now, as it's better > if most getopt related stuff stays in the same file getopt.m4. Thank you! Regards, Sergey

Re: gl_GETOPT_SUBSTITUTE gone

2009-08-12 Thread Bruno Haible
Hi Sergey, > The recent removal of gl_GETOPT_SUBSTITUTE broke argp.m4. > Argp depends on GNU getopt internals, so it is safer to > always include gnulib's version of getopt even if libc's > one behaves identically to GNU. Oops, I did not see this dependency. I'm restoring it now, as it's better i

gl_GETOPT_SUBSTITUTE gone

2009-08-12 Thread Sergey Poznyakoff
Bruno, The recent removal of gl_GETOPT_SUBSTITUTE broke argp.m4. Argp depends on GNU getopt internals, so it is safer to always include gnulib's version of getopt even if libc's one behaves identically to GNU. Will it suffice to do this: diff --git a/m4/argp.m4 b/m4/argp.m4 index 7263a56..aeb2aeb

Re: uname: build problem on win32

2009-08-12 Thread Sam Steingold
Bruno Haible wrote: Sam Steingold wrote: Therefore for now, this change is better limited to your project. OK, how about adding an --guard_prefix option? fixing the problem at the source (gnulib-tool) is much easier - just a few lines. fixing it inside clisp is a bigger task. Feel free to do

Re: uname: build problem on win32

2009-08-12 Thread Bruno Haible
Sam Steingold wrote: > > Therefore for now, this change is better limited to your project. > > OK, how about adding an --guard_prefix option? > fixing the problem at the source (gnulib-tool) is much easier - just a > few lines. > fixing it inside clisp is a bigger task. Feel free to do it in you

Tests failing to build with external getttext

2009-08-12 Thread Tom G. Christensen
On Solaris 2.6 building the daily snapshot fails due to missing symbols in some of the tests: Undefined first referenced symbol in file libintl_gettext ../gllib/libgnu.a(pipe-filter-gi.o) Undefined first re

Re: Minor fix to gitlog-to-changelog

2009-08-12 Thread Sergey Poznyakoff
Jim Meyering ha escrit: > That's fine, as long as you also add a line or two in --help output. Sure. I have installed the following patch: >From 2ae2a816e734b0332eac67b07e184589e9b5957e Mon Sep 17 00:00:00 2001 From: Sergey Poznyakoff Date: Wed, 12 Aug 2009 19:48:51 +0300 Subject: [PATCH] Mino

Re: Minor fix to gitlog-to-changelog

2009-08-12 Thread Jim Meyering
Sergey Poznyakoff wrote: > Jim Meyering ha escrit: > >> I prefer the existing style, so how about making that format string an >> option? > > That's reasonable. Something like that, then: That's fine, as long as you also add a line or two in --help output.

Re: Minor fix to gitlog-to-changelog

2009-08-12 Thread Sergey Poznyakoff
Jim Meyering ha escrit: > I prefer the existing style, so how about making that format string an > option? That's reasonable. Something like that, then: diff --git a/build-aux/gitlog-to-changelog b/build-aux/gitlog-to-changelog index 1cc53eb..677e5f6 100755 --- a/build-aux/gitlog-to-changelog +

Re: getopt: make declaration available from

2009-08-12 Thread Eric Blake
Bruno Haible clisp.org> writes: > > POSIX specifies that getopt() and the four variables optarg etc. should be > declared in . But gnulib provides them only in . This > fixes it. POSIX doesn't require . How about we also change the getopt module to change the recommended Include: line over to

Re: Minor fix to gitlog-to-changelog

2009-08-12 Thread Jim Meyering
Sergey Poznyakoff wrote: > In the output of gitlog-to-changelog, subject lines > are not separated from the body. This fix adds an extra newline > and fixes this. Any objections to push it? Hi Sergey, I prefer the existing style, so how about making that format string an option? E.g., I prefer t

Minor fix to gitlog-to-changelog

2009-08-12 Thread Sergey Poznyakoff
Hello, In the output of gitlog-to-changelog, subject lines are not separated from the body. This fix adds an extra newline and fixes this. Any objections to push it? Regards, Sergey diff --git a/build-aux/gitlog-to-changelog b/build-aux/gitlog-to-changelog index 1cc53eb..a4a0c1d 100755 --- a/bui

Re: uname: build problem on win32

2009-08-12 Thread Sam Steingold
On Wed, Aug 12, 2009 at 10:43 AM, Bruno Haible wrote: > Sam Steingold wrote: >> >> On one of these, do a >> >>  sed -e s/_GL_UNISTD_H/_GL_UNISTD_H_2/ >> > >> > 2. you can use the --macro-prefix gnulib-too argument to augment the >> > guards. >> > i.e., whenever you generate a header, modify the gu

getopt: make declaration available from

2009-08-12 Thread Bruno Haible
POSIX specifies that getopt() and the four variables optarg etc. should be declared in . But gnulib provides them only in . This fixes it. 2009-08-12 Bruno Haible Ensure that getopt() gets declared by . * lib/unistd.in.h: Conditionally include getopt.h. * m4/getopt.m4

Re: simple multithread program fails on Cygwin, succeeds on Linux

2009-08-12 Thread Bruno Haible
Eric Blake wrote, referring to : > I don't know if you saw the other responses to this thread (the cygwin > list has the annoying habit of setting headers such that reply-to-all > excludes the original poster). Indeed, I missed the answers since

Re: uname: build problem on win32

2009-08-12 Thread Bruno Haible
Sam Steingold wrote: > >> On one of these, do a > >> sed -e s/_GL_UNISTD_H/_GL_UNISTD_H_2/ > > > > 2. you can use the --macro-prefix gnulib-too argument to augment the guards. > > i.e., whenever you generate a header, modify the guards according to the > > prefix. > > diff --git a/gnulib-tool b

Re: test-argp-version-etc failures on mac

2009-08-12 Thread Bruno Haible
Eric Blake wrote: > > * lib/argp-ba.c (argp_program_bug_address): Explicitly zero-initialize > > on non-ELF systems. > > Cygwin is a non-ELF system, but does not need the explicit initialization. > Is there a tighter condition we could use that would pick up just the > MacOS situation, wi

Re: test-argp-version-etc failures on mac

2009-08-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 8/7/2009 1:06 AM: > powerpc-apple-darwin8 is MacOS X 10.4. I see this error also on MacOS X > 10.3.9. > It's the same linker bug as the one mentioned in lib/mbsrtowcs-state.c. I'm > applying this fix: > > 2009-08-07 Brun

Re: new module: update-copyright [Re: copyright years: mass-update every January 1

2009-08-12 Thread Akim Demaille
Le 31 juil. 09 à 15:52, Joel E. Denny a écrit : Hi Joel, +# Format within margin. +my $new_wrapped; +my $text_margin = $margin - length($prefix); +while (length($new)) + { +if (($new =~ s/^(.{1,$text_margin})(?: |$)//) +|| ($