Re: string.h uses restrict

On Fri, 3 Apr 2009, Jim Meyering wrote: I'll take your word that it doesn't change anything. Someone who uses it may want to try it or give it a closer look. Let me know, and I can do some more work. The next thing I'm interested in is adding some more source checking rules, particularly thos

Re: ld-output-def

* Simon Josefsson wrote on Thu, Apr 02, 2009 at 05:24:54PM CEST: > > As far as I could tell, the pr-msvc-support branch is for building > shared libraries using Visual Studio. Is that right? Yes. > If so, that isn't what lib-msvc-compat is meant to help with: > lib-msvc-compat is for building a

Re: [PATCH] Fix arpa_inet bugs found when installing coreutils 7.2 on Solaris 8.

Bruno Haible writes: > There is no point for gnulib to redefine a function that is present in libnsl > (and hopefully working). IMO the fix is therefore to add a 'Link' section to > the module description module/inet_ntop, and determine its value, say, > INET_NTOP_LIB, in the gl_INET_NTOP macro.

Re: false positive in ld-version-script.m4

Hi Simon, * Simon Josefsson wrote on Fri, Apr 03, 2009 at 02:24:04PM CEST: > --- a/m4/ld-version-script.m4 > +++ b/m4/ld-version-script.m4 > @@ -6,6 +6,11 @@ dnl with or without modifications, as long as this notice is > preserved. > > dnl From Simon Josefsson > > +# FIXME: The test below re

Re: [PATCH] Port fnmatch to Solaris 8.

Bruno Haible writes: > Good point. Also, fnmatch.c uses the mbsinit() function; thus a > dependency to the 'mbsinit' module should also be added. > ... > Your commit has not yet appeared at > http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=shortlog Thanks, I forgot to push it. I installed t

Re: string.h uses restrict

Reuben Thomas wrote: > On Fri, 3 Apr 2009, Reuben Thomas wrote: > >> On Wed, 1 Apr 2009, Reuben Thomas wrote: >> >>> Would you like to suggest what I should do next to my patch? >> >> Not having had a reply, I've come up with my own answer: start with >> a little bit of merging. >> >> What I've don

Re: string.h uses restrict

Reuben Thomas wrote: > On Wed, 1 Apr 2009, Reuben Thomas wrote: > >> Would you like to suggest what I should do next to my patch? > > Not having had a reply, I've come up with my own answer: start with a > little bit of merging. > > What I've done so far is to add the macros _prohibit_regexp and >

Re: sc_cast_of_argument_to_free

Reuben Thomas wrote: > Why is this rule valid? GCC gives warnings if const pointers are not > cast to non-const before passing to C. As far as I can see, this is > correct: free takes a non-const argument. > Should malloced memory > simply not be assigned to a const pointer? Right. In the scope t

Re: string.h uses restrict

On Fri, 3 Apr 2009, Reuben Thomas wrote: On Wed, 1 Apr 2009, Reuben Thomas wrote: Would you like to suggest what I should do next to my patch? Not having had a reply, I've come up with my own answer: start with a little bit of merging. What I've done so far is to add the macros _prohibit_

sc_cast_of_argument_to_free

Why is this rule valid? GCC gives warnings if const pointers are not cast to non-const before passing to C. As far as I can see, this is correct: free takes a non-const argument. Should malloced memory simply not be assigned to a const pointer? -- http://rrt.sc3d.org/ | Bathe or shower daily:

Re: string.h uses restrict

On Wed, 1 Apr 2009, Reuben Thomas wrote: Would you like to suggest what I should do next to my patch? Not having had a reply, I've come up with my own answer: start with a little bit of merging. What I've done so far is to add the macros _prohibit_regexp and _header_without_use to gnulib's

Re: struct sched_param on EMX

On 3-04-09 13:42, Bruno Haible wrote: [Changed the subject. Please choose a more precise subject next time.] Elbert_Pol wrote: CC execute.o In file included from ./spawn.h:33, from execute.c:47: ./sched.h:35: error: redefinition of 'struct sched_param' make.exe[4]: *** [e

false positive in ld-version-script.m4

It seems mingw accepts the -Wl,--version-script parameters, but it does not seem to do anything. In particular, a 'local: *;' statement does not remove internal symbols from the resulting DLL. The m4 test could be improved to detect this problem, by building a DLL and then building a program that

Re: struct sched_param on EMX

[Changed the subject. Please choose a more precise subject next time.] Elbert_Pol wrote: > >> CC execute.o > >> In file included from ./spawn.h:33, > >> from execute.c:47: > >> ./sched.h:35: error: redefinition of 'struct sched_param' > >> make.exe[4]: *** [execute.o] Error 1 >

Re: [PATCH] Fix arpa_inet bugs found when installing coreutils 7.2 on Solaris 8.

Hello Paul, > I installed the following patch to gnulib, to fix the following > symptoms when trying to build coreutils 7.2 on Solaris 8: > > inet_ntop.c:73: error: conflicting types for 'inet_ntop' > /usr/include/arpa/inet.h:55: error: previous declaration of 'inet_ntop' was > here > make[4]: *

Re: [PATCH] Port fnmatch to Solaris 8.

Paul Eggert wrote: > * modules/fnmatch (Depends-on): Add mbsrtowcs Good point. Also, fnmatch.c uses the mbsinit() function; thus a dependency to the 'mbsinit' module should also be added. > I installed the following into gnulib Your commit has not yet appeared at http://git.savannah.gnu.org/git

Re: mostlyclean and texinfo outputs (was: Installing gnulib from git)

Hi Ralf, Thanks for pursuing this. > > For the {dvi,ps} formats this is (arguably) a bug in automake, > > I agree; automake should remove {html,dvi,ps,pdf} only upon 'clean', but > not upon 'mostlyclean'. Only the latex by-products should be removed > upon 'mostlyclean'. OK, this is issue #1.