Re: [PATCH] avoid gcc warnings about unused macro definitions

2009-03-12 Thread Bruno Haible
Jim Meyering wrote: > I'm not inclined to move > definitions "down" into the #if blocks where they're used or even > to add #if directives around the definition at the top. I agree: The convention to put all miscellaneous macros used in a file near the top, after the header file includes, is a goo

Re: interix 3.5 select bug

2009-03-12 Thread Bruno Haible
Jim Meyering wrote: > > + /* Interix 3.5 has a bug: it does not support nfds == 0. */ > > + if (nfds == 0) > > +{ > > + nfds = 1; > > + rfds = NULL; > > + wfds = NULL; > > + xfds = NULL; > > +} > > Did you consider doing the above only when all three input pointers >

Re: bug in join: case comparisons don't work in multibyte locales

2009-03-12 Thread Paolo Bonzini
> OK, I'll work on the creation of a GNU project called 'libunistring', that > will export the functions from gnulib as a shared library. That's simply great to hear. Paolo

[PATCH] avoid gcc warnings about unused macro definitions

2009-03-12 Thread Jim Meyering
FYI, I'll push the patch below shortly: Now that I'm enabling more gcc warnings, and since I've just started experimenting with Ralf's new "automake --silent-rules", these new warnings stand out more than before, so I've addressed some of them. Here's sample output: CC modechange.o CC mo

Re: interix 3.5 select bug

2009-03-12 Thread Jim Meyering
Bruno Haible wrote: > Simon Josefsson wrote: >> > It seems that another solution would be to >> > detect this problem, and to replace select if the system's select >> > doesn't work. > > Good point. Using 0 as nfd argument is common; try searching for > " = select (0, " on http://www.google.com/cod

Re: bug in join: case comparisons don't work in multibyte locales

2009-03-12 Thread Pádraig Brady
Bruno Haible wrote: > Pádraig Brady wrote: >> Note as well as folding case I think it might >> be useful to fold other forms like: >> Enclosed: \u24b6 -> A >> Stylistic: \uff21-> A > > These two transformations are already executed when you use ulc_casecmp > with the UNINORM_NFKD argument. A

Re: bug in join: case comparisons don't work in multibyte locales

2009-03-12 Thread Bruno Haible
Pádraig Brady wrote: > Note as well as folding case I think it might > be useful to fold other forms like: > Enclosed: \u24b6 -> A > Stylistic: \uff21-> A These two transformations are already executed when you use ulc_casecmp with the UNINORM_NFKD argument. > Diacritics: À -> A Very goo

Re: bug in join: case comparisons don't work in multibyte locales

2009-03-12 Thread Bruno Haible
James Youngman wrote: > My first reaction was, why isn't libunistring===glibc glibc means to implement POSIX and be the interface to the system calls. The general guideline nowadays among glibc maintainers is "no new API" (unless it's a new system call). IIRC, when libidn was added to glibc as an

Re: interix 3.5 select bug

2009-03-12 Thread Bruno Haible
Simon Josefsson wrote: > > It seems that another solution would be to > > detect this problem, and to replace select if the system's select > > doesn't work. Good point. Using 0 as nfd argument is common; try searching for " = select (0, " on http://www.google.com/codesearch/. > I haven't studie

Re: bug in join: case comparisons don't work in multibyte locales

2009-03-12 Thread James Youngman
On Wed, Mar 11, 2009 at 11:57 AM, Bruno Haible wrote: > OK, I'll work on the creation of a GNU project called 'libunistring', that > will export the functions from gnulib as a shared library. My first reaction was, why isn't libunistring===glibc, but then we'd end up in a situation where gnulib w