> Pádraig Brady wrote:
> > Markus Duft wrote:
[snip]
>
> Thanks for looking at that, Pádraig.
> I agree.
>
> Note that there are other uses of select with 0 as first argument.
> These affect the poll ans select modules:
>
> $ git grep -l 'select (0'
> lib/poll.c
> lib/winsock-select.
Bruno Haible writes:
> | on NUL terminated| on memory areas or
> | strings | strings with embedded NULs
> --+--+---
> For ASCII strings | c_strcasecmp,|
> only
Simon Josefsson wrote:
> Jim Meyering writes:
>
>> +* lib/nanosleep.c (my_usleep): Use 1, not 0, as the first argument.
>> +This avoids a failure on Interix 3.5. Details in
>> +http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/16077
>
> Is this the best solution? It seems that a
> > That looks fine as the first param to select
> > is the highest-numbered file descriptor + 1.
> > Arguably 1 is more correct than 0.
I think this patch is fine. OTOH 1 is *not* more correct than 0, because it
implies that fd 0 might be tested.
The other uses are for WinSock only, so they sh
Jim Meyering writes:
> + * lib/nanosleep.c (my_usleep): Use 1, not 0, as the first argument.
> + This avoids a failure on Interix 3.5. Details in
> + http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/16077
Is this the best solution? It seems that another solution would be to
de
Pádraig Brady wrote:
> Markus Duft wrote:
>> Hi!
>>
>> I have a more or less trivial patch for the nanosleep replacement for
>> interix. The problem I ran into is, that select() has a bug, making it fail
>> with "bad address" if the number of fd's to select on is zero. Setting the
>> set-size to 1
Hi Jim and Pádraig,
> > 1) Which functions to use for case comparison in coreutils?
pb> I think if we're going to do it we should do it right.
pb> I.E. use ulc_casecmp
jm> I prefer the "correct" approach, especially since I believe that will
jm> eventually align with POSIX, even if it doesn't ma
Markus Duft wrote:
> Hi!
>
> I have a more or less trivial patch for the nanosleep replacement for
> interix. The problem I ran into is, that select() has a bug, making it fail
> with "bad address" if the number of fd's to select on is zero. Setting the
> set-size to 1 solves the problem, and shou
Bruno Haible wrote:
> In coreutils/src/join.c, there is a FIXME mentioning that the -i option for
> case insensitive comparison of the input lines does not work in multibyte
> locales. And indeed, in an UTF-8 locale, I see this:
...
> Find attached a draft patch for the 'join' program, that fixes t
David Bartley wrote:
> The following two patches (1 for tar, 1 for gnulib) fix the bug I
> reported earlier [1]. I ran 'make check' successfully on Linux as
> well.
Hi David,
Sorry about the delay.
Thanks for working on this.
Have you started the copyright assignment process
described here (for
10 matches
Mail list logo
