[PATCH] announce-gen: new option: --no-print-checksums

2009-03-01 Thread Jim Meyering
I've been manually removing MD5 and SHA1 checksums from the template generated by coreutils' "make alpha/beta/major", so have added this so I can automate it: >From 7d6b0649427017451841dc69f0be307ba2646076 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 2 Mar 2009 08:49:04 +0100 Subject: [

Re: compilation of findutils-4.4.0 with gcc-4.4.0-20090225 -- error with wctype.h in gnulib code

2009-03-01 Thread Bruno Haible
Frank Erens wrote: > - > #include > #include > > #include > #include > #include > #include > > void test(wint_t _wc) {} > > int main() {} > > --

Re: [PATCH] setsockopt: Add support for timeouts on W32

2009-03-01 Thread Bruno Haible
In this thread, there was also the proposed patch to use 'socklen_t' instead of 'int' in the prototypes of getsockopt() and setsockopt(). Paolo approved it, Simon did not object, I had tested it on mingw, and the type 'socklen_t

Re: gnulib-tool bug

2009-03-01 Thread Bruno Haible
Paolo Bonzini wrote: > FWIW, the bug mentioned earlier in the thread is already fixed in git sed. Thanks for the info. I'm re-enabling the use of the --posix option for when sed 4.2 will be released. 2009-03-01 Bruno Haible * gnulib-tool (sed): Do alias as "sed --posix" if sed's vers

Re: use execute module in m4

2009-03-01 Thread Bruno Haible
Hi Eric, > the execute module outputs an unwanted warning message when a signal > is encountered in the child; m4 would rather handle the warning itself to > give it consistent formatting. OK to apply the gnulib patch? Makes sense indeed to leave to the caller error messages which the caller can

Re: wait-process cosmetics

2009-03-01 Thread Bruno Haible
Eric Blake wrote: >/* waitpid() is just as portable as wait() nowadays. */ > - int status; > + int status = 0; > >if (termsigp != NULL) > *termsigp = 0; > - *(int *) &status = 0; >for (;;) > { Applied as follows: 2009-03-01 Eric Blake * lib/wait-process.c

Re: test-sched.c warning

2009-03-01 Thread Bruno Haible
Eric, I prefer to fix the warning this way. This way, the tests that use 'a' and 'b' are not unnecessarily mixed. 2009-03-01 Bruno Haible Avoid a gcc warning. * tests/test-sched.c (b): Make global. Reported by Eric Blake. --- tests/test-sched.c.orig 2009-03-01 17

Re: isnanl-nolibm failure

2009-03-01 Thread Bruno Haible
Simon Josefsson wrote: > --- a/modules/isnanl-nolibm-tests > +++ b/modules/isnanl-nolibm-tests > @@ -1,6 +1,7 @@ > Files: > tests/test-isnanl-nolibm.c > tests/test-isnanl.h > +tests/nan.h > > Depends-on: > float Yes, this patch is necessary. Thanks. Bruno

Re: [PATCH] setsockopt: Add support for timeouts on W32

2009-03-01 Thread Simon Josefsson
Martin Lambers writes: > On Tue, 03. Feb 2009, 12:37:48 +0100, Simon Josefsson wrote: >> >> > Simon, Paolo, do you have any comments on the patches suggested in this >> >> > thread? >> >> >> >> I didn't see anything wrong -- on the contrary. If you resend it, I'll >> >> apply it. >> > >> > OK,

isnanl-nolibm failure

2009-03-01 Thread Simon Josefsson
Bruno, this command fails: gnulib-tool --test --with-tests isnanl-nolibm with an error: ../../gltests/test-isnanl.h:24:17: error: nan.h: No such file or directory See: http://autobuild.josefsson.org/gnulib/log-200903010845939381000.txt How about this patch? Inspired by the isnanl-tests modul

Re: vc-list-files-cvs failure?

2009-03-01 Thread Simon Josefsson
Ralf Wildenhues writes: > I can reproduce this when awk is mawk. The following patch fixes > the failure, the portability issue is documented in the gawk manual. Great, thanks! /Simon

use execute module in m4

2009-03-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno, a while ago, you suggested that I replace m4's syscmd implementation from system(3) over to the execute module. I responded that m4 needs to know the signal that killed the child process, so you added a parameter to make that possible (2008-06-

Re: [patch #6758] Add support for Atari FreeMiNT OS

2009-03-01 Thread Simon Josefsson
Alan Hourihane writes: > On Sun, 2009-03-01 at 13:38 +0100, Bruno Haible wrote: >> Alan Hourihane wrote: >> > In netdb.in.h we have >> > >> > # ifndef EAI_INPROGRESS >> > >> > but in gai_strerror.c we have... >> > >> > #ifdef __USE_GNU >> > >> > Can we be consistent here and use >> > >

Re: [PATCH] setsockopt: Add support for timeouts on W32

2009-03-01 Thread Martin Lambers
On Tue, 03. Feb 2009, 12:37:48 +0100, Simon Josefsson wrote: > >> > Simon, Paolo, do you have any comments on the patches suggested in this > >> > thread? > >> > >> I didn't see anything wrong -- on the contrary. If you resend it, I'll > >> apply it. > > > > OK, I resend the part that I wrote (pr

Re: compilation of findutils-4.4.0 with gcc-4.4.0-20090225 -- error with wctype.h in gnulib code

2009-03-01 Thread Frank Erens
2009/3/1 Frank Erens : > > I've tried it with the other compiler, and it still gives the same > error. My hosts > compiler works fine. It's strange that it works on Mac with exactly the same > compiler version, but not on Linux. I guess that means we'll have to take > a closer look at mbchar.h Aft

Re: [patch #6758] Add support for Atari FreeMiNT OS to fpurge

2009-03-01 Thread Bruno Haible
Alan Hourihane wrote: > Yes. This does the trick. Committed. Bruno

Re: compilation of findutils-4.4.0 with gcc-4.4.0-20090225 -- error with wctype.h in gnulib code

2009-03-01 Thread Frank Erens
2009/3/1 Frank Erens : > As I was quite sure this was a GCC bug, I've tried compiling this on my > MacBook > ( uname -srm : Darwin 9.6.0 i386 ) with gcc-4.4.0-200821219. That > specific version > is tested by the people of HPC for Mac, so I could be sure there would > be no (large) > bugs in it. >

Re: [patch #6758] Add support for Atari FreeMiNT OS to fpurge

2009-03-01 Thread Alan Hourihane
On Sun, 2009-03-01 at 13:32 +0100, Bruno Haible wrote: > Alan Hourihane wrote: > > > Is anything else among the aforementioned unit tests still failing? > > > > Yes. The last problem is fseeko() as mentioned. > > The 'if (0)' is not right: it causes the lseek to be skipped entirely in > gnulib.

Re: [patch #6758] Add support for Atari FreeMiNT OS

2009-03-01 Thread Alan Hourihane
On Sun, 2009-03-01 at 13:38 +0100, Bruno Haible wrote: > Alan Hourihane wrote: > > In netdb.in.h we have > > > > # ifndef EAI_INPROGRESS > > > > but in gai_strerror.c we have... > > > > #ifdef __USE_GNU > > > > Can we be consistent here and use > > > > #ifdef EAI_INPROGRESS in gai_strerr

Re: [patch #6758] Add support for Atari FreeMiNT OS

2009-03-01 Thread Bruno Haible
Alan Hourihane wrote: > In netdb.in.h we have > > # ifndef EAI_INPROGRESS > > but in gai_strerror.c we have... > > #ifdef __USE_GNU > > Can we be consistent here and use > > #ifdef EAI_INPROGRESS in gai_strerror.c This is Simon's domain. But yes, this would be consistent with the change

Re: [patch #6758] Add support for Atari FreeMiNT OS to fpurge

2009-03-01 Thread Bruno Haible
Alan Hourihane wrote: > > Is anything else among the aforementioned unit tests still failing? > > Yes. The last problem is fseeko() as mentioned. The 'if (0)' is not right: it causes the lseek to be skipped entirely in gnulib. But we have the requirement that fflush followed by fseek acts like ls

Re: [patch #6758] Add support for Atari FreeMiNT OS to fpurge

2009-03-01 Thread Alan Hourihane
On Sun, 2009-03-01 at 11:05 +0100, Bruno Haible wrote: > Alan Hourihane wrote: > > Yes. This works too. > > OK, I committed it. > > Is anything else among the aforementioned unit tests still failing? Yes. The last problem is fseeko() as mentioned. Alan.

Re: [patch #6758] Add support for Atari FreeMiNT OS

2009-03-01 Thread Alan Hourihane
Hi Bruno, On another item (mentioned before) In netdb.in.h we have # ifndef EAI_INPROGRESS but in gai_strerror.c we have... #ifdef __USE_GNU Can we be consistent here and use #ifdef EAI_INPROGRESS in gai_strerror.c or modify netdb.h.in to use __USE_GNU ?? Alan.

Re: [patch #6758] Add support for Atari FreeMiNT OS to fpurge

2009-03-01 Thread Bruno Haible
Alan Hourihane wrote: > Yes. This works too. OK, I committed it. Is anything else among the aforementioned unit tests still failing? Bruno 2009-03-01 Bruno Haible More support for FreeMiNT. * lib/fpurge.c (fpurge): Correct last commit. Reported by Alan Hourihane .

Re: [patch #6758] Add support for Atari FreeMiNT OS

2009-03-01 Thread Alan Hourihane
Hi Bruno, So, we still fail the tests with the current git HEAD of today. As I mentioned yesterday fseeko() still fails. I have to revert to if (0) for FreeMiNT for this to pass the tests. Comments ? Alan.

Re: [patch #6758] Add support for Atari FreeMiNT OS

2009-03-01 Thread Bruno Haible
Alan Hourihane wrote: > Thanks, but the #else section is still broken for older mintlibs, and > it's really not going to work. That's why I added the new functionality. I know, and thanks for adding the new functionality. But for older mintlibs I prefer some something that compiles and works appro

Re: [patch #6758] Add support for Atari FreeMiNT OS

2009-03-01 Thread Alan Hourihane
On Sun, 2009-03-01 at 02:40 +0100, Bruno Haible wrote: > Alan Hourihane wrote: > > Attached are the freading.c and fwriting.c patches to make them pass. > > Thanks. I've committed it like this: Thanks, but the #else section is still broken for older mintlibs, and it's really not going to work. Th

Re: vc-list-files-cvs failure?

2009-03-01 Thread Jim Meyering
Ralf Wildenhues wrote: ... >> That fall-back code relies on gawk, sed and /bin/sh, >> so you might try with a different shell, e.g., bash vs. dash, >> or inserting "| tee /tmp/log " into the pipeline to see if >> the damage is already done before the eval'd "sed" code runs. > > I can reproduce this

Re: [patch #6758] Add support for Atari FreeMiNT OS to fpurge

2009-03-01 Thread Alan Hourihane
On Sun, 2009-03-01 at 02:17 +0100, Bruno Haible wrote: > Alan Hourihane wrote: > + fp->__pushback_bufp = 0; > + if (fp->__mode.__write) > +fp->__put_limit = fp->__buffer; > + fp->__bufp = fp->__get_limit; > > I don't think the last statement is right. The purpose of fpurge, on the read > si