Re: FreeBSD GCC warnings

2008-10-17 Thread Ralf Wildenhues
Hi Bruno, * Bruno Haible wrote on Sat, Oct 18, 2008 at 02:46:13AM CEST: > > ! PRAGMA_SYSTEM_HEADER='#if __GNUC__ >= 3 > > ! #pragma GCC system_header > > ! #endif' > > Oops, that did not work. autoconf >= 2.60 supports multiline replacements > in AC_SUBST, but 'automake' and 'make' don't.

Re: pragma GCC diagnostic

2008-10-17 Thread Manuel López-Ibáñez
2008/10/17 Bruno Haible <[EMAIL PROTECTED]>: > "#pragma GCC diagnostic" has a few limitations, which make it unusable to > resolve warnings like this one: > > Jim Meyering wrote in [1]: >> $ cat in.c >> int f (void) __attribute__ ((__warn_unused_result__)); >> void g (void) { (void) f (

Re: minus_zero-related tests fail to compile on ppc with recent gcc

2008-10-17 Thread Bruno Haible
Jim Meyering wrote: > Markus Armbruster <[EMAIL PROTECTED]> wrote: > > With the appended patch, koji ate it up: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=886652 > > Great! Thanks a lot, Markus. > > Bruno, FYI, Markus discovered that > an upcoming idutils release fails to compile on

Re: FreeBSD GCC warnings

2008-10-17 Thread Bruno Haible
> ! PRAGMA_SYSTEM_HEADER='#if __GNUC__ >= 3 > ! #pragma GCC system_header > ! #endif' Oops, that did not work. autoconf >= 2.60 supports multiline replacements in AC_SUBST, but 'automake' and 'make' don't. I've reverted the commit and done this instead: 2008-10-17 Bruno Haible <[EMAIL PR

Re: FreeBSD GCC warnings

2008-10-17 Thread Bruno Haible
Hi Yoann, > stdio.h:20: warning: ignoring pragma: system_header > stdlib.h:19: warning: ignoring pragma: system_header > string.h:22: warning: ignoring pragma: system_header > strings.h:22: warning: ignoring pragma: system_header > [...] > > This is on FreeBSD 4.10-RELEASE, gcc version 2.95.4 200

Re: pragma GCC diagnostic

2008-10-17 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > "Manuel López-Ibáñez" <[EMAIL PROTECTED]> wrote: >> 2008/10/17 Bruno Haible <[EMAIL PROTECTED]>: >>> "#pragma GCC diagnostic" has a few limitations, which make it unusable to >>> resolve warnings like this one: >>> >>> Jim Meyering wrote in [1]: $

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Jim Meyering
Paolo Bonzini <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Paolo Bonzini <[EMAIL PROTECTED]> wrote: >>> Jim Meyering wrote: I wanted to ignore some new warnings in coreutils, but a "(void)" cast no longer does the job with the latest gcc and libc headers. >>> Do you have a re

Re: pragma GCC diagnostic

2008-10-17 Thread Jim Meyering
"Manuel López-Ibáñez" <[EMAIL PROTECTED]> wrote: > 2008/10/17 Bruno Haible <[EMAIL PROTECTED]>: >> "#pragma GCC diagnostic" has a few limitations, which make it unusable to >> resolve warnings like this one: >> >> Jim Meyering wrote in [1]: >>> $ cat in.c >>> int f (void) __attribute__ ((__

Re: minus_zero-related tests fail to compile on ppc with recent gcc

2008-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 10/17/2008 12:47 PM: > Markus Armbruster <[EMAIL PROTECTED]> wrote: >> With the appended patch, koji ate it up: >> http://koji.fedoraproject.org/koji/taskinfo?taskID=886652 > > Great! Thanks a lot, Markus. > > Bruno, FYI

minus_zero-related tests fail to compile on ppc with recent gcc

2008-10-17 Thread Jim Meyering
Markus Armbruster <[EMAIL PROTECTED]> wrote: > With the appended patch, koji ate it up: > http://koji.fedoraproject.org/koji/taskinfo?taskID=886652 Great! Thanks a lot, Markus. Bruno, FYI, Markus discovered that an upcoming idutils release fails to compile on ppc-based systems: (details here htt

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Hi Jim, > >> +Depends-on: >> +inline >> + >> +configure.ac: >> + > > The 'inline' module is overkill here, since you don't use the HAVE_INLINE > macro. In other words, you don't really care whether the function gets > inlined or not. In this situation, a s

Re: [PATCH]: update tls and lock tests, gl_cond_t WIN32 implementation

2008-10-17 Thread Bruno Haible
Yoann Vandoorselaere wrote: > I just run the test suite under wine and it run correctly. Please apply. Applied. > > Anyway, for reference, here's the same thing again as an attachment. > > Thanks, this solved the problem! I guess some line wrapped around in the > original patch. But as I said,

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Paolo Bonzini
Jim Meyering wrote: > Paolo Bonzini <[EMAIL PROTECTED]> wrote: >> Jim Meyering wrote: >>> I wanted to ignore some new warnings in coreutils, >>> but a "(void)" cast no longer does the job with the latest gcc >>> and libc headers. >> Do you have a reduced testcase? > > No, but I will add one. In p

pragma GCC diagnostic

2008-10-17 Thread Bruno Haible
"#pragma GCC diagnostic" has a few limitations, which make it unusable to resolve warnings like this one: Jim Meyering wrote in [1]: > $ cat in.c > int f (void) __attribute__ ((__warn_unused_result__)); > void g (void) { (void) f (); } > $ gcc -Werror -c in.c > cc1: warnings be

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Bruno Haible
Hi Jim, > +Depends-on: > +inline > + > +configure.ac: > + The 'inline' module is overkill here, since you don't use the HAVE_INLINE macro. In other words, you don't really care whether the function gets inlined or not. In this situation, a simple AC_C_INLINE invocation would be sufficient: Dep

Re: [PATCH]: missing recvfrom dependency

2008-10-17 Thread Paolo Bonzini
Applied, thanks. Paolo

Re: [PATCH]: missing recvfrom dependency

2008-10-17 Thread Simon Josefsson
Yoann Vandoorselaere <[EMAIL PROTECTED]> writes: > Hi, > > recvfrom make use of the getpeername function, but doesn't pull the > dependency automatically. The attached patch fix that. Thanks, pushed. /Simon > Regards, > > -- > Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technolog

[PATCH]: missing recvfrom dependency

2008-10-17 Thread Yoann Vandoorselaere
Hi, recvfrom make use of the getpeername function, but doesn't pull the dependency automatically. The attached patch fix that. Regards, -- Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies Tel: +33 (0)9 50 70 21 58 Fax: +33(0)9 57 25 21 58 http://www.prelud

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > I wanted to ignore some new warnings in coreutils, > but a "(void)" cast no longer does the job with the latest gcc > and libc headers. > > Here's the proposed module: > >>From 179c0e32f86c8b0013111d343f17d27730391e63 Mon Sep 17 00:00:00 2001 > From: Jim Me

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Jim Meyering
Paolo Bonzini <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Paolo Bonzini <[EMAIL PROTECTED]> wrote: >> >>> Jim Meyering wrote: Paolo Bonzini <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> I wanted to ignore some new warnings in coreutils, >> but a "(void)" cast no long

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Paolo Bonzini
Jim Meyering wrote: > Paolo Bonzini <[EMAIL PROTECTED]> wrote: > >> Jim Meyering wrote: >>> Paolo Bonzini <[EMAIL PROTECTED]> wrote: Jim Meyering wrote: > I wanted to ignore some new warnings in coreutils, > but a "(void)" cast no longer does the job with the latest gcc > and libc

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Jim Meyering
Paolo Bonzini <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Paolo Bonzini <[EMAIL PROTECTED]> wrote: >>> Jim Meyering wrote: I wanted to ignore some new warnings in coreutils, but a "(void)" cast no longer does the job with the latest gcc and libc headers. >>> Do you have a re

FreeBSD GCC warnings

2008-10-17 Thread Yoann Vandoorselaere
Hi, I'm getting report from users that they get a lot of the following warnings: stdio.h:20: warning: ignoring pragma: system_header stdlib.h:19: warning: ignoring pragma: system_header string.h:22: warning: ignoring pragma: system_header strings.h:22: warning: ignoring pragma: system_header [...

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Paolo Bonzini
Jim Meyering wrote: > Paolo Bonzini <[EMAIL PROTECTED]> wrote: >> Jim Meyering wrote: >>> I wanted to ignore some new warnings in coreutils, >>> but a "(void)" cast no longer does the job with the latest gcc >>> and libc headers. >> Do you have a reduced testcase? > > No, but I will add one. I me

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Jim Meyering
Paolo Bonzini <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> I wanted to ignore some new warnings in coreutils, >> but a "(void)" cast no longer does the job with the latest gcc >> and libc headers. > > Do you have a reduced testcase? No, but I will add one. Modulo using a unique name for th

Re: [PATCH] ignore-value: new module

2008-10-17 Thread Paolo Bonzini
Jim Meyering wrote: > I wanted to ignore some new warnings in coreutils, > but a "(void)" cast no longer does the job with the latest gcc > and libc headers. Do you have a reduced testcase? Paolo

Re: [PATCH]: update tls and lock tests, gl_cond_t WIN32 implementation

2008-10-17 Thread Yoann Vandoorselaere
Hi Bruno, Le jeudi 16 octobre 2008 à 12:27 +0200, Bruno Haible a écrit : > > The patch won't apply to the current GIT repository: > > > > patching file lib/glthread/cond.h > > patching file lib/glthread/cond.c > > Hunk #2 FAILED at 235. > > Hunk #3 FAILED at 306. > > Hunk #4 FAILED at 422. > > Hu