Re: winsock: needs access to SOCKET in application code

2008-10-13 Thread Bruno Haible
Hi Simon, > As we discussed earlier, and as far as I understand, the only approach > for a project like libgnutls -- that needs compatibility with native > Windows programs -- is to accept a SOCKET handle from the application, > and call the native send/recv. Yes, I agree with this. For libraries

Re: condition variable implementation question

2008-10-13 Thread Bruno Haible
After verifying that taking the lock after the bookkeeping (instead of before) does not break the testsuite, I committed this comment. > --- lib/glthread/cond.c.orig 2008-10-12 22:05:50.0 +0200 > +++ lib/glthread/cond.c 2008-10-12 21:30:47.0 +0200 > @@ -159,7 +159,8 @@ >

Re: [PATCH]: update tls and lock tests, gl_cond_t WIN32 implementation

2008-10-13 Thread Bruno Haible
Hi Yoann, Thanks for the rapid testing. > Attached is a patch that fixes some compilation problem due to the > latest cond and select changes. > > Additionally, it seems the cond timedwait test are now failing under > WIN32, although I did not attempt to trace the problem yet. Your fix for the

Re: automatically preventing merge commits on master

2008-10-13 Thread Bruno Haible
Hi Jim, > In our experience here (with gnulib.git), pushing a merge > commit is always unintentional. Yes, my mistake today. It was definitely unintentional. I was working in two gnulib checkouts at the same time, noticed the merge in one checkout and straightened it through "git rebase origin/ma

winsock: needs access to SOCKET in application code

2008-10-13 Thread Simon Josefsson
Paolo, Bruno, I'm starting to integrate the winsock modules in my projects. As we discussed earlier, and as far as I understand, the only approach for a project like libgnutls -- that needs compatibility with native Windows programs -- is to accept a SOCKET handle from the application, and call t

Re: automatically preventing merge commits on master

2008-10-13 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> Does anyone object to my installing a server-side hook >> that would prevent pushing merge commits on master? >> In our experience here (with gnulib.git), pushing a merge >> commit is always unintentional. >

Re: automatically preventing merge commits on master

2008-10-13 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > Does anyone object to my installing a server-side hook > that would prevent pushing merge commits on master? > In our experience here (with gnulib.git), pushing a merge > commit is always unintentional. +1 from me. How would you do that? I'd like to do

automatically preventing merge commits on master

2008-10-13 Thread Jim Meyering
Does anyone object to my installing a server-side hook that would prevent pushing merge commits on master? In our experience here (with gnulib.git), pushing a merge commit is always unintentional.

Re: [PATCH]: update tls and lock tests, gl_cond_t WIN32 implementation

2008-10-13 Thread Yoann Vandoorselaere
Hi Bruno, Le dimanche 12 octobre 2008 à 00:16 +0200, Bruno Haible a écrit : > You wrote on 2008-09-18 > > and 2008-10-02 > : > > > provide a working implement

Re: pmccabe2html: support inline stylesheets

2008-10-13 Thread jemarch
Jose, after this patch you'll need to supply a new parameter css=filename or css_url=url to provide the stylesheet. Do you think this approach is good? I like it. It allows the use of an external css file or to embed css information from a file, or both.

pmccabe2html: support inline stylesheets

2008-10-13 Thread Simon Josefsson
Pushed. Jose, after this patch you'll need to supply a new parameter css=filename or css_url=url to provide the stylesheet. Do you think this approach is good? I dislike hard coded parameters like the current pmccabe.css filename. /Simon >From b13005f4bf9ed08072874318e2b377851a70263a Mon Sep 1

Re: [PATCH] pmccabe2html C++ support

2008-10-13 Thread Simon Josefsson
Giuseppe Scrivano <[EMAIL PROTECTED]> writes: > Hello, > > I added the possibility to have different functions with the same name > to the pmccabe2html script, in this way it can be used on C++ source > code too. Hi! Thank you. To be able to integrate the patch into gnulib, the FSF needs a copy