Re: Typo in maint.mk

2008-08-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to [EMAIL PROTECTED] on 8/28/2008 5:30 PM: > Hi hackers. > > Just a little note. There are two references in maint.mk to > Makefile.cfg (in comments). It seems that it should read cfg.mk > instead. Thanks. Do you have a preferred name for

Re: byteswap 404

2008-08-28 Thread Bruno Haible
Karl Berry wrote: > I made more fixes to my stupid cron. Fingers crossed for tonight ... Thanks. It's fine now: the newest MODULES.html fixes the problems with the hyperlinks. Bruno

Re: wcwidth replacement problems

2008-08-28 Thread Bruno Haible
Alexander V. Lukyanov wrote: > Well, Solaris wcwidth has many other deficiencies, e.g: > solaris_wcwidth(0x220)=-1 Was added in Unicode 3.2.0 (2002). > solaris_wcwidth(0x221)=-1 mk_wcwidth(0x221)=1 > solaris_wcwidth(0x234)=-1 mk_wcwidth(0x234)=1 > solaris_wcwidth(0x235)=-1 mk_wcwidth(0x235)

Re: getndelim2 license

2008-08-28 Thread Bruno Haible
Hi Jim, > Will commit this shortly: > > * modules/getndelim2 (License): Relicense to LGPLv2+. Do you have RMS's backing for this move? The original version of this code was contributed to the FSF by Jan Brittenson, who is not on this mailing list. It was my understanding that we can relice

Re: bitrotate

2008-08-28 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > +#define rotl32(x,n) \ > + x) << ((uint16_t)(n))) | ((x) >> (32 - (uint16_t)(n & 0x) I suggest using inline functions rather than macros, to avoid hassles with double-evaluating arguments. That way, you won't need any casts. The cast

Typo in maint.mk

2008-08-28 Thread jemarch
Hi hackers. Just a little note. There are two references in maint.mk to Makefile.cfg (in comments). It seems that it should read cfg.mk instead. --- top/maint.mk.orig 2008-07-27 16:21:51.0 +0200 +++ top/maint.mk2008-08-29 01:28:43.0 +0200 @@ -21,10 +21,10 @@ # List o

Re: git-version-gen and 'make install'

2008-08-28 Thread Ralf Wildenhues
* Eric Blake wrote on Thu, Aug 28, 2008 at 02:24:53PM CEST: > According to Bruno Haible on 7/21/2008 5:05 PM: > > > > A) Reduce your expectations, and accept that modified programs show the same > >version number as the unmodified programs. Like it was for the last 20 > >years. When users

findprog: don't exit => exit-free base_name, dir_name, etc

2008-08-28 Thread Jim Meyering
I wanted a version of findprog that I could use from a library (libvirt), but the existing one can call exit in several ways. My first cut at this changes findprog itself not to call exit anymore. Obviously, this is an API change, and may well be undesirable, in which case I can easily create a ne

Re: GNUmakefile: git-version-gen, maintainer-check, install

2008-08-28 Thread Ralf Wildenhues
* Eric Blake wrote on Thu, Aug 28, 2008 at 02:17:01PM CEST: > According to Ralf Wildenhues on 8/28/2008 1:39 AM: > > > > Pause is not good. It doesn't scale with system speed, it doesn't > > parallelize, who looks at build logs interactively anyway, except > > to get annoyed by the fact that it's

Re: [PATCH] use new global, "Version", rather than macro, VERSION

2008-08-28 Thread Ben Pfaff
Jim Meyering <[EMAIL PROTECTED]> writes: > +BUILT_SOURCES += version.c > +version.c: Makefile > + rm -f $@ > + printf '#include \n' > [EMAIL PROTECTED] > + printf 'char const *Version = "$(PACKAGE_VERSION)";\n' >> [EMAIL > PROTECTED] > + @chmod a-w [EMAIL PROTECTED] > + mv [EM

Re: bitrotate

2008-08-28 Thread Paolo Bonzini
> +#define rotl32(x,n) \ > + x) << ((uint16_t)(n))) | ((x) >> (32 - (uint16_t)(n & 0x) > +#define rotr32(x,n) \ > + x) >> ((uint16_t)(n))) | ((x) << (32 - (uint16_t)(n & 0x) > +#define rotl16(x,n) \ > + x) << ((uint16_t)(n))) | ((x) >> (16 - (uint16_t)(n &

Re: wcwidth replacement problems

2008-08-28 Thread Alexander V. Lukyanov
On Tue, Aug 26, 2008 at 09:32:32AM +0200, Bruno Haible wrote: > Probably the Solaris wcwidth is made to match some Japanese terminal > emulators, rather than xterm? In such terminal emulators, many characters > that have width 1 in xterm are represented with width 2. > > U+2022 (BULLET) is designa

Re: [PATCH] use new global, "Version", rather than macro, VERSION

2008-08-28 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > According to Jim Meyering on 8/28/2008 5:54 AM: >> This change makes ccache (http://ccache.samba.org/) more useful in >> that cached .o files from one build are usually still useful after a >> version number change. Before, due to the use of VERSION, the old

Re: [PATCH] use unlocked io in getdelim

2008-08-28 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: >> 2) Portability: getndelim2 uses freadptr and freedseek which appears >>non-portable by design (or?) -- having a getline that can be compiled >>on any C89/POSIX system can be useful >> ... >> It could be moved to a 'getline-portable' module. > > I

Re: [PATCH] use new global, "Version", rather than macro, VERSION

2008-08-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 8/28/2008 5:54 AM: > This change makes ccache (http://ccache.samba.org/) more useful in > that cached .o files from one build are usually still useful after a > version number change. Before, due to the use of VERSION, the

bitrotate

2008-08-28 Thread Simon Josefsson
How about a bitrotate module? I needed bitrotate functions in a project, and noticed that arctwo in gnulib also included definitions. This patch adds a new module bitrotate and makes arctwo use it. If anyone has ideas on better names (currently rotl16, rotr16 etc) or header filename (currently b

Re: [PATCH] use unlocked io in getdelim

2008-08-28 Thread Jim Meyering
Paolo Bonzini <[EMAIL PROTECTED]> wrote: > Eric Blake wrote: >> According to Paolo Bonzini on 8/27/2008 6:54 AM: >>> Except that getndelim2 and memchr2 are GPL, while freadptr and freadseek >>> are LGPL (I assume v3+). Would it be okay to change all four to LGPLv2+? >> >> I'm okay with memchr2 bei

Re: git-version-gen and 'make install'

2008-08-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 7/21/2008 5:05 PM: > Eric Blake wrote on Friday: >> In the developer's sandbox, you should not care what the version is, >> therefore, >> development and incremental compiles should NOT be penalized by always >> keeping

Re: GNUmakefile: git-version-gen, maintainer-check, install

2008-08-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ralf Wildenhues on 8/28/2008 1:39 AM: > > Pause is not good. It doesn't scale with system speed, it doesn't > parallelize, who looks at build logs interactively anyway, except > to get annoyed by the fact that it's still not done yet? I

Re: GNUmakefile: git-version-gen, maintainer-check, install

2008-08-28 Thread Bruno Haible
Ralf Wildenhues wrote: > This whole issue is getting more and more abstruse, ever since it > was decided that the version should contain the git string, but at > the same time autoconf should not rerun upon each version string > change. I agree that more thought needs to be put into solving this i

Re: GNUmakefile: git-version-gen, maintainer-check, install

2008-08-28 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Wed, Aug 27, 2008 at 04:38:00PM CEST: > Denny Joel E cs.clemson.edu> writes: > > > > Well, I tried to make it a hard error, so that it would be the only > > > output, but others on the list convinced me to reduce it back to a > > > warning. I don't know of any GNU

Re: [PATCH] use unlocked io in getdelim

2008-08-28 Thread Bruno Haible
Simon Josefsson wrote: > I'd like to see getndelim2 solve this problem: > > 1) LGPL license compatibility getndelim2 is currently GPL, because it inherits from a file getline.c that was written by Jan Brittenson for gcc. To make it LGPL, you would have to either rewrite getndelim2 from scratch (b