Eric Blake wrote:
> According to Albert Chin on 6/20/2008 5:49 PM:
> | Trying to run the testsuite for the vasprintf-posix module on HP-UX
> | 10.20 using the HP C compiler:
> | $ ./gnulib-tool --test --with-tests vasprintf-posix
> | ...
> | PASS: test-EOVERFLOW
> | PASS: test-alloca-opt
>
Eric Blake wrote:
> I thought we already decided that requiring long long support in the
> preprocessor is a losing battle, at least for a couple more years.
We found out that also Sun C does not support 'long long' right in preprocessor
expressions.
> ie. comment out the preprocessor checks for
In the context of lib/fatal-signal.c, I find that SA_RESETHAND is not
appropriate: If a fatal signal handler cleanup is interrupted by another
fatal signal, it is better to start the cleanup a second time rather than
terminating the program with incomplete cleanup.
OK to apply?
2008-06-22 Bruno
The fact that the next POSIX calls siginterrupt 'obsolescent' is something that
cannot be fixed by gnulib; therefore IMO it belongs outside the list of things
that gnulib does not fix.
Also, siginterrupt is related to SA_RESTART, not SA_NODEFER.
2008-06-22 Bruno Haible <[EMAIL PROTECTED]>
I don't understand the "Due to autoconf conventions". We are not using
HAVE_SIGACTION as a #define in config.h. We are using it as a shell variable.
This shell variable is not set by either AC_REPLACE_FUNCS([sigaction])
nor by AC_CHECK_TYPE(...). So there is no conflict.
Proposed comment change:
In a comment you say that the mingw replacement for sigaction does not
implement SA_RESTART. We can do better, since the msvcrt library never sets
errno = EINTR anyway: Define SA_RESTART and ignore it.
2008-06-22 Bruno Haible <[EMAIL PROTECTED]>
* lib/signal.in.h (SA_RESTART): New macr
Since gl_SIGACTION may set HAVE_SIGACTION to its non-default value, the
default value assignment must occur before it.
2008-06-22 Bruno Haible <[EMAIL PROTECTED]>
* m4/sigaction.m4 (gl_SIGACTION): Invoke gl_SIGNAL_H_DEFAULTS.
*** m4/sigaction.m4.orig2008-06-22 21:44:50.
Eric Blake wrote:
> I named the helper file sig-handler.h.
Since it uses 'inline', it needs AC_C_INLINE.
2008-06-22 Bruno Haible <[EMAIL PROTECTED]>
* m4/signalblocking.m4 (gl_PREREQ_SIG_HANDLER_H): New macro.
(gl_PREREQ_SIGPROCMASK): Invoke it.
* m4/sigaction.m4 (gl_P
Eric Blake wrote:
> Your review hopefully made it even better.
Thanks for addressing all the issues. And thanks for noticing the
missing reloading of the handler in blocking_handler.
> OK, the version of the patch posted below should be safer in the presence of
> async signals (it will never be
Eric Blake wrote:
> + /* POSIX states that sigprocmask and signal are both
> + async-signal-safe.
Going through the list of async-signal-safe functions, gnulib overrides
quite a few. I propose to add comments so that this is remembered in future
modifications of the functions.
Eric Blake wrote:
> found that it would somewhat easier if I could learn accurate
> signal information even when a signal is blocked. Is this okay to apply?
Yes, of course. Thank you. From me, only a small comment update.
2008-06-22 Bruno Haible <[EMAIL PROTECTED]>
* lib/sigprocmask.
On Fri, Jun 20, 2008 at 06:53:53PM -0600, Eric Blake wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> According to Bruno Haible on 6/20/2008 5:58 PM:
> |> The problem is the following:
> |> #if INTMAX_MIN && INTMAX_MAX && UINTMAX_MAX
> |
> | Well, it seems this compiler does not grok
12 matches
Mail list logo
