-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Wow! Check out the speedup with this patch, comparing an -O2 /bin/cut
pre-patch against an unoptimized -g cut post-patch, and that's even with
running /bin/cut second so it benefits from any file system caching effects.
$ dd count=20k data
20480+0
Simon Josefsson wrote:
> diff --git a/m4/arpa_inet_h.m4 b/m4/arpa_inet_h.m4
> index 8f530c5..baddf0d 100644
> --- a/m4/arpa_inet_h.m4
> +++ b/m4/arpa_inet_h.m4
> @@ -32,4 +32,7 @@ AC_DEFUN([gl_ARPA_INET_H_DEFAULTS],
> [
>GNULIB_INET_NTOP=0; AC_SUBST([GNULIB_INET_NTOP])
>GNULIB_INET_PTO
Simon Josefsson wrote:
> Btw, a solaris system I have access to declares the function as follows
> (in system arpa/inet.h):
>
> #if !defined(_XPG4_2) || defined(_XPG6) || defined(__EXTENSIONS__)
> extern int inet_pton(int, const char *_RESTRICT_KYWD, void *_RESTRICT_KYWD);
> extern const char *ine
Jim Meyering <[EMAIL PROTECTED]> writes:
> Jim Meyering <[EMAIL PROTECTED]> wrote:
>
>> Hi Simon
>>
>> Ok to apply?
>> Without it, I'd get this:
>> FAIL: test-getaddrinfo
>> with a segfault that comes from using inet_ntop with no declaration.
>>
>> Avoid test segfault on x86_64 due to lack
Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> I've tested it better now
>
> It was still apparently tested only on few systems. As you can see
> from doc/posix-functions/inet*.texi, the functions inet_ntop and inet_pton
> need to be declared also on HP-UX 11, OSF/1 4.0, Sola
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> Le mardi 29 avril 2008 à 13:16 +0200, Jim Meyering a écrit :
>> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
>> > Le lundi 28 avril 2008 à 22:40 +0200, Jim Meyering a écrit :
>> >> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
>> >> > Le samed
Eric Blake wrote:
> More importantly, getaddrinfo.c fails to compile
More importantly, users' code will fail to compile as well, if they are
not made aware of the change. It's a backward-incompatible change, so needs
to be mentioned in NEWS. I did this:
*** NEWS.orig 2008-04-29 23:40:56.00
Before this change, when there was more than one
useless if test in a block (blocks are '"'-separated),
only the first would be shown. Now they all are.
>From a24967ca5051d7210bb87096c398cfb694385512 Mon Sep 17 00:00:00 2001
From: Jim Meyering <[EMAIL PROTECTED]>
Date: Tue, 29 Apr 2008 22:04:47
I noticed that I'd broken my useless-if-before-free script.
It would only notice the useless tests if there were
a cast on the argument to the free-like function.
I've just pushed this correction and will add unit tests.
>From e47886762b67882c67f9b76f41a1f89c3552c4aa Mon Sep 17 00:00:00 2001
From
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 4/29/2008 10:51 AM:
| FAIL: test-getaddrinfo
| with a segfault that comes from using inet_ntop with no declaration.
More importantly, getaddrinfo.c fails to compile on cygwin 1.5.x without
this change, also pushed:
- -
Jim Meyering <[EMAIL PROTECTED]> wrote:
> Hi Simon
>
> Ok to apply?
> Without it, I'd get this:
> FAIL: test-getaddrinfo
> with a segfault that comes from using inet_ntop with no declaration.
>
> Avoid test segfault on x86_64 due to lack of inet_ntop declaration.
> * tests/test-getad
Hi Simon
Ok to apply?
Without it, I'd get this:
FAIL: test-getaddrinfo
with a segfault that comes from using inet_ntop with no declaration.
Avoid test segfault on x86_64 due to lack of inet_ntop declaration.
* tests/test-getaddrinfo.c: Include , now guaranteed
by gnulib
* m4/arpa_inet_h.m4: Remove trailing blanks.
diff --git a/ChangeLog b/ChangeLog
index ed3c210..1ea1736 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-04-29 Jim Meyering <[EMAIL PROTECTED]>
+
+ * m4/arpa_inet_h.m4: Remove trailing blanks.
+
2008-04-29 Eric Blake <[
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 4/28/2008 4:06 PM:
| Why should a developer who uses gnulib have to write valgrind
suppression files
| to work around ISO C99 violations in gnulib? We can at least provide a
| strchrnul.valgrind file, like the 'malloca' mo
Le mardi 29 avril 2008 à 13:16 +0200, Jim Meyering a écrit :
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> > Le lundi 28 avril 2008 à 22:40 +0200, Jim Meyering a écrit :
> >> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> >> > Le samedi 26 avril 2008 à 02:31 +0200, Bruno Haible a écrit :
>
Simon Josefsson wrote:
> I've tested it better now
It was still apparently tested only on few systems. As you can see
from doc/posix-functions/inet*.texi, the functions inet_ntop and inet_pton
need to be declared also on HP-UX 11, OSF/1 4.0, Solaris 2.5.1. So the
gnulib must be used in these case
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> Le lundi 28 avril 2008 à 22:40 +0200, Jim Meyering a écrit :
>> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
>> > Le samedi 26 avril 2008 à 02:31 +0200, Bruno Haible a écrit :
>> >> Yoann Vandoorselaere wrote:
>> >> > I guess mkdir could use the
Eric Blake wrote:
> 2008-04-28 Eric Blake <[EMAIL PROTECTED]>
>
> + Add rawmemchr module, matching glibc.
> + * modules/string (Makefile.am): New indicator.
> + * m4/string_h.m4 (gl_HEADER_STRING_H_DEFAULTS): Set it.
> + * lib/string.in.h (rawmemchr): Declare when appropriate.
Simon Josefsson <[EMAIL PROTECTED]> writes:
> Bruno Haible <[EMAIL PROTECTED]> writes:
>
>> Hi Simon,
>>
>>> I would also favor removing both inet_ntop.h and inet_pton.h, and use
>>> arpa/inet.h for the declarations, as you suggested.
>>
>> Me too.
>
> Yoann, Bruno,
> I've pushed the following, pl
Le lundi 28 avril 2008 à 22:40 +0200, Jim Meyering a écrit :
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> > Le samedi 26 avril 2008 à 02:31 +0200, Bruno Haible a écrit :
> >> Yoann Vandoorselaere wrote:
> >> > I guess mkdir could use the original malloc implementation, returning an
> >> > er
20 matches
Mail list logo
