Re: [patch]gnu tar 1.19 canonicalize-lgpl_c.gdiff

Jim Meyering wrote: "John E. Malmberg" <[EMAIL PROTECTED]> wrote: If you're going to contribute much more, you'll have to fill out copyright assignment paperwork. Also (assuming you continue) please provide ChangeLog entries as well as "git format-patch" style diffs, so it's easier to apply.

Re: build problems on old Linux libc5

[CCing bug-gnulib. Please trim bug-gnu-gettext from the CC when replying.] Alain Guibert wrote to bug-gnu-gettext: > On my old Linux box (Intel Pentium 200 MMX, Debian bo, kernel 2.0.40, > gcc 2.7.2.1, libc 5.4.33, GNU ld cygnus-2.7.1, libiconv 1.12, pth 2.0.7, > i586-pc-linux-gnulibc1) during get

Re: [patch]gnu tar 1.19 canonicalize-lgpl_c.gdiff

John E. Malmberg wrote: > On VMS, all the system functions start out with decc$. The compiler > uses a table to know what they are and automatically adds the prefix, > unless macro substitution is active. > > Gnulib does the macro substitution, so the real prefixed symbol name is > used to get

Re: strtod bugs

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 4/1/2008 7:45 PM: |> Were you planning on backing out the math.in.h changes? | | It depends on your vote... If you say no, then no. Let's leave it in for now: I'm brave enough to make m4 1.4.11 the litmus test. If someon

Re: strtod bugs

Eric Blake wrote: > | 1) POSIX says that defines the macro NAN, but also says that it > | expands into a constant expression. We cannot guarantee that. Therefore > | is it better to define the macro or not? > > Well, I did document in doc/posix-functions/math.texi that NAN might not > be

Re: strtod bugs

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 4/1/2008 7:05 PM: | While I like that you collected the many instances of the function which | returns a NaN into a single place, I don't like two things here: | | 1) POSIX says that defines the macro NAN, but also says

Re: strtod bugs

Eric Blake wrote: > * tests/test-math.c (main): Test it. This test fails on IRIX 6.5 with CC="cc -O". The reason is that it inlines the 'd == d' test. Here is the machine code that the compiler generates: .entmain .globl main main:# 0x0 .frame $sp, 0, $31 .BB1.ma

Re: strtod bugs

Eric Blake wrote: > * doc/posix-headers/math.texi (math.h): Document this. It's not only Solaris 8 which lacks it. I'm updating the doc. Also, I prefer not to libel a particular compiler as "broken". If we label every compiler or platform which has a bug as "broken", not only every system will ha

Re: [patch]gnu tar 1.19 canonicalize-lgpl_c.gdiff

Bruno Haible wrote: John E. Malmberg wrote: On VMS, think of "// can be any device mounted on the system, or logical name. A logical name behaves like a symbolic link either in the current directory, or in the root directory as far as the file system is concerned, but it is stored in syste

Re: [patch]gnu tar 1.19 canonicalize-lgpl_c.gdiff

Bruno Haible wrote: Jim Meyering wrote: How about the patch below instead? I've moved the prototype down, so that we see the offensive, "$"-containing symbol name only once ;-) It is less understandable than John Malmberg's patch, because - normally you should have a declaration of a functio

Re: strtod bugs

Eric Blake byu.net> writes: > > Done as follows. FLT_EPSILON represents a 2-ulp error for 0.5; Actually, FLT_EPSILON represents a 2-ulp error for 0.5f, and unless FLT_EVAL_METHOD>0, it's waaay more than 2-ulp of the double 0.5. I also botched FLT_MIN instead of DBL_MIN, now fixed. -- Eric

Re: strtod bugs

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 4/1/2008 1:02 AM: |> Wow - gnulib's version of strtod really IS inaccurate. The buildbot is |> still showing failures, since 5 * pow (10.0, -1) != 0.5. Any suggestions |> on how to make this test pass? Would it be accep

Re: [patch]gnu tar 1.19 canonicalize-lgpl_c.gdiff

Jim Meyering wrote: > How about the patch below instead? > I've moved the prototype down, so that we see > the offensive, "$"-containing symbol name only once ;-) It is less understandable than John Malmberg's patch, because - normally you should have a declaration of a function before you start

Re: [patch]gnu tar 1.19 canonicalize-lgpl_c.gdiff

"John E. Malmberg" <[EMAIL PROTECTED]> wrote: > Update VMS special code to work with gnulib headers. > > -John > [EMAIL PROTECTED] > Personal Opinion Only > --- /src_root/tar-1.19/lib/canonicalize-lgpl.cFri Sep 28 08:11:36 2007 > +++ /stage_vms_src/tar-1.19/lib/canonicalize-lgpl.c Mon Dec

Re: strtod bugs

Eric Blake <[EMAIL PROTECTED]> wrote: > According to Eric Blake on 3/30/2008 4:03 PM: > | And just now, I tested cygwin with -O2, and got: > | > | ../../m4/tests/test-strtod.c:149: assertion failed > | ../../m4/tests/test-strtod.c:221: assertion failed > | > | which looks like rounding errors in c