Re: Some free()s in module 'relocatable'

2007-12-29 Thread Sylvain Beucler
> Sylvain Beucler <[EMAIL PROTECTED]> writes: > > > Attached is a small patch to fix a couple non-fred memory blocks. They > > are not a big deal, but they do produce noise when analyzing programs > > with memory checkers such as Valgrind. > > I do not see the attachment. > > > Another thing:, t

Re: [patch] make acl support optional

2007-12-29 Thread Mike Frysinger
On Wednesday 25 July 2007, Mike Frysinger wrote: > posted this to the coreutils a list sometime ago ... idea is to be able to > disable automatic ACL detection via --disable-acl since this can often > times take the form of an external library rather than part of the system > libc. > > patch was or

Re: wcwidth failure on RedHat Linux 7.3 (coreutils-6.9.91)

2007-12-29 Thread Bruno Haible
Peter Fales wrote: > I'm seeing the following gnulib test failure while building > coreutils-6.9.91 on RedHat Linux 7.3. ... the failure > is at line 63 of gnulib-tests/test-wcwidth.c which says: > > 63 ASSERT (wcwidth (0x2060) == 0); > > The value that is actually being returned is -1.

Re: lib/progname.c

2007-12-29 Thread Bruno Haible
Paul Eggert wrote: > I do have a bit of trouble reading the code, though. > It doesn't seem to match the comment: e.g., it strips a leading "lt-" > even when there's no "/.libs/". When I look at ltmain.sh it seems that an 'lt-program' or 'lt-program.exe' can also be generated outside the .libs dir

Re: memmem issues

2007-12-29 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > No; ISO C 99 section 7.21.4 says that when byte strings are compared the > elements are considered as 'unsigned char' values. Why risk bugs when the > approach is very simple: after fetching any 'char' from any of the strings, > cast it to 'unsigned char'

Re: memmem issues

2007-12-29 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > Most of your comments apply to all copies of the KMP code in gnulib. Ouch! Should these be coalesced? >> Shouldn't this check for overflow in the multiplication? > > Yes, it should. I'm always lazy about this. OK, I installed this patch. 2007-12-29

Re: Gnulib needed in AC_CHECK_HEADERS

2007-12-29 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > - The autoconf manual still recommends to include only if > HAVE_ALLOCA_H. > - fnmatch.c and regex.c are still included in gcc's libiberty. Its regex.c > also includes only if HAVE_ALLOCA_H. But these are for Autoconf's AC_FUNC_ALLOCA macro