Re: no license on some test modules

2007-12-11 Thread Ralf Wildenhues
Hello Eric, all, * Eric Blake wrote on Tue, Dec 11, 2007 at 08:18:35PM CET: > > This may not be the end of the story. For M4 head, it is now triggering a > libtool bug - libtool mistakenly canonicalizes its link line, and discards > one > of the two instances of $(local_ldadd), which means we

Re: mingw isnanl-nolibm failure

2007-12-11 Thread Eric Blake
Eric Blake byu.net> writes: > > Here's one idea. Since it fixes the mingw cross-compilation failure of test- > isnanl-nolibm, I'm installing it; if we come up with something better or more > efficient in the future, we can alter the test then. > > The idea behind this patch is that = doesn't

Re: no license on some test modules

2007-12-11 Thread Eric Blake
Jim Meyering meyering.net> writes: > > And indeed, there can be circular dependencies. I tested the same m4 setup on > > mingw. If libtests.a is listed first, progname.o is not included. But if it > > is listed second only, then gl_array_list.o generates a missing link to xmalloc > > and fr

Re: mingw isnanl-nolibm failure

2007-12-11 Thread Eric Blake
Bruno Haible clisp.org> writes: > Ack. It's a bug in the isnanl module. > > > I'm not sure how to fix this, but it seems like rpl_isnanl needs to check for > > invalid x86 long double bit patterns before falling back to ==. > > Either this, or ensure that the "checking where to find the expon

Re: no license on some test modules

2007-12-11 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: ... > And indeed, there can be circular dependencies. I tested the same m4 setup on > mingw. If libtests.a is listed first, progname.o is not included. But if it > is listed second only, then gl_array_list.o generates a missing link to > xmalloc > and frien

Re: no license on some test modules

2007-12-11 Thread Eric Blake
Eric Blake byu.net> writes: > This is because test-avltree_oset.c relies on progname.c to provide > program_name. Since m4 didn't use progname.c (only the test programs did), > progname.o is now part of libtests.a rather than ../lib/libm4.a. Yet, the use > of program_name doesn't occur unti

Re: $(LIB_ACL_TRIVIAL)

2007-12-11 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > You can avoid a bit of code duplication through a change like this: That fix assumes that acl_free preserves errno, but normally I wouldn't expect random library calls to preserve errno. doesn't claim that it does pr

Re: OpenBSD frexpl failure

2007-12-11 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/11/2007 4:28 AM: > This test is not right. You can have >SIZEOF_DOUBLE < SIZEOF_LONG_DOUBLE && DBL_MANT_DIG == LDBL_MANT_DIG > (the FreeBSD 6.1 case that we had recently). You can also have Do any of the LDBL_* cons

Re: Support versions of autoconf prior to 2.59c.

2007-12-11 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: >> >Support versions of autoconf prior to 2.59c. >> >* gnulib-tool (func_emit_initmacro_done): Define m4_foreach_w >> >if it is not already defined. > > Thanks. The blank line could also be an 'echo' that emits a blank line. Ok. Committed.

Re: $(LIB_ACL_TRIVIAL)

2007-12-11 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Paul Eggert wrote: >> I installed the following: > > Your patch is hard to understand for me in unidiff format, so I tried to > convert it to context diff format, as usual, but this did not work: > $ ud2cd < acl.udiff > ud2cd: Warning: Incomplete hunk e

Re: $(LIB_ACL_TRIVIAL)

2007-12-11 Thread Bruno Haible
Paul Eggert wrote: > I installed the following: Your patch is hard to understand for me in unidiff format, so I tried to convert it to context diff format, as usual, but this did not work: $ ud2cd < acl.udiff ud2cd: Warning: Incomplete hunk ending at line 87 I understand that GNU diff can now

Re: Relative speed of globbing and regex implementations

2007-12-11 Thread Bruno Haible
James Youngman wrote: > I notice that the gnulib fnmatch implementation is slower than the > regex implementation, at least in those cases where a pattern can be > compiled once and offered thousands of times. Very roughly, I'd guess > that the fnmatch implementation takes about 1.4x the time that

Re: OpenBSD frexpl failure

2007-12-11 Thread Bruno Haible
Eric Blake wrote: > I'm wondering if we should also add a configure-time compile test in > float_h.m4, which does the sanity check of this untested snippet: > > AC_CHECK_SIZEOF([double]) > AC_CHECK_SIZEOF([long double]) > AC_COMPUTE_INT([variable], > [(SIZEOF_DOUBLE == SIZEOF_LONG_DOUBLE) >=

Re: OpenBSD frexpl failure

2007-12-11 Thread Bruno Haible
Eric Blake wrote: > Here's the relevant contents of OpenBSD 4.0 > > #define LDBL_MANT_DIG DBL_MANT_DIG > #define LDBL_EPSILONDBL_EPSILON > #define LDBL_DIGDBL_DIG > #define LDBL_MIN_EXPDBL_MIN_EXP > #define LDBL_MINDBL_MIN > #define LDBL_MIN_10_EXP DBL_MIN_10_EXP > #defi

Re: Support versions of autoconf prior to 2.59c.

2007-12-11 Thread Bruno Haible
Hi Jim, > > Support versions of autoconf prior to 2.59c. > > * gnulib-tool (func_emit_initmacro_done): Define m4_foreach_w > > if it is not already defined. Thanks. The blank line could also be an 'echo' that emits a blank line. Bruno