Re: snprintf gnulibification, first step

2007-02-23 Thread Daniel Jacobowitz
On Fri, Feb 23, 2007 at 11:42:31PM -0500, Daniel Jacobowitz wrote: > I checked in the attached to libsnprintfv. By the way, the only warning in the mingw32 build: ../../libsnprintfv/snprintfv/printf.c: In function `stream_vprintf': ../../libsnprintfv/snprintfv/printf.c:850: warning: `snv_wint_t'

snprintf gnulibification, first step

2007-02-23 Thread Daniel Jacobowitz
I checked in the attached to libsnprintfv. This is the first step in getting it to use gnulib for its own portability needs, which will make it easier to integrate with gnulib. Most of this is extremely predictable. The only bits that deserve mention are: - The modules it uses so far are: std

coreutils build on IRIX 6.5

2007-02-23 Thread Bruno Haible
Hi Jim, Building a coreutils snapshot (2007-02-21) from http//meyering.net/cu/ on IRIX 6.5 with the native cc shows one problem: After the c99 patch has been applied, man/Makefile attempts to rebuild the 'rm.1' manual page. This fails like this: Updating man page rm.1 Perl 5.005 required-

Re: build reports of coreutils snapshot on AIX 4.3.2

2007-02-23 Thread Bruno Haible
Hi Jim, > > - on AIX 4.3.2: compiles fine. > > didn't pass tests? Passed one test, then starts consuming 100% CPU time: Making check in chgrp make check-TESTS PASS: default-no-deref It's inside the "chgrp/basic" test, the "sleep 1" command. "top" shows this: PID USERNAME PRI NIC

Re: portability checks, errors and warnings

2007-02-23 Thread Bruno Haible
Hi Paul, all, > I want 'make' to fail if any module > uses ctime, since it's asking for trouble in portable code (it has > undefined behavior with out-of-range time stamps). I suppose someone > could write code that carefully bounds the time stamps and then uses > ctime; such code can "#undef cti

Re: snprintfv for gnulib?

2007-02-23 Thread Bruno Haible
Daniel Jacobowitz wrote: > One of the items on my plate is figuring out the best way to > regenerate the generated .h files after moving them to gnulib. > One way would be at gnulib-tool time, another to have a separate > script and keep updated copies checked in. gnulib-tool so far has no options

Re: snprintfv for gnulib?

2007-02-23 Thread Bruno Haible
Daniel Jacobowitz wrote: > - I don't know how to make one gnulib module override another yet There are two ways to achieve this, both in the area of the package that uses gnulib. Say, you want override 'snprintf' with 'snprintfv'. a) Invoke "gnulib-tool --avoid=snprintf --import snprintfv". or b

Re: snprintfv for gnulib?

2007-02-23 Thread Bruce Korb
On 2/23/07, Gary V. Vaughan <[EMAIL PROTECTED]> wrote: Looks like you have a good plan for gnulib integration. Date: Fri, 23 Feb 2007 10:03:35 -0800 Indeed. Welcome to California, Gary. :) - Bruce

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > 2007-02-23 Eric Blake <[EMAIL PROTECTED]> > > * lib/getdate.h (includes): Include , not "timespec.h". > * lib/stat-time.h (includes): Likewise. > * lib/utimecmp.c (includes): Likewise. > * lib/utimens.h (includes): Likewise. >

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Eric Blake
Jim Meyering meyering.net> writes: > No. Otherwise, gnulib's "time.h" replacement becomes mandatory, > and encourages gnulib-using applications to use functions > that are not standard. Agreed. > > > Or do we keep the timespec module, which both coreutils and tar > > explicitly request, as an

Re: snprintfv for gnulib?

2007-02-23 Thread Gary V. Vaughan
Looks like you have a good plan for gnulib integration. I especially like splitting out the other datatypes into independently useable modules. On 23 Feb 2007, at 04:36, Paolo Bonzini wrote: I will work on gnulib-izing snprintfv first. Are there any particular platforms you would recommend c

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > Jim Meyering meyering.net> writes: > >> >> There is a declaration of struct timespec in time_.h, >> so utimens.h, stat-time.h, and getdate.h should include >> rather than timespec.h. Then timespec.h can be removed. >> >> I'll look into that over the weeke

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Eric Blake
Jim Meyering meyering.net> writes: > > There is a declaration of struct timespec in time_.h, > so utimens.h, stat-time.h, and getdate.h should include > rather than timespec.h. Then timespec.h can be removed. > > I'll look into that over the weekend, if no one else does it first. I took a cl

Re: gnulib getcwd patch needed for Solaris 10 getcwd

2007-02-23 Thread Jim Meyering
Matthew Woehlke <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Bad timing. I was about to make a test release. >> If anyone else has access to a Solaris 10 system (x86 or otherwise), >> with Sun C, would you please try the latest snapshot? >> http://meyering.net/cu/ > > FYI if you feel the

Re: gnulib getcwd patch needed for Solaris 10 getcwd

2007-02-23 Thread Matthew Woehlke
Jim Meyering wrote: Bad timing. I was about to make a test release. If anyone else has access to a Solaris 10 system (x86 or otherwise), with Sun C, would you please try the latest snapshot? http://meyering.net/cu/ FYI if you feel the need for more test results, I can do builds on both SPA

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > According to Jim Meyering on 2/22/2007 2:26 PM: >> This fixes it: >> >> * modules/utimens (Depends-on): Add timespec, required for >> utimens.h's inclusion of timespec.h. > > stat-time is another module that uses raw timespec.h without depending on

Re: snprintfv for gnulib?

2007-02-23 Thread Bruce Korb
On 2/23/07, Daniel Jacobowitz <[EMAIL PROTECTED]> wrote: One of the items on my plate is figuring out the best way to regenerate the generated .h files after moving them to gnulib. One way would be at gnulib-tool time, another to have a separate script and keep updated copies checked in. ``gnul

Re: snprintfv for gnulib?

2007-02-23 Thread Paolo Bonzini
I don't think I copied you on an email -- there is a bug fix and a number of warning fixes in my version that did not make it into the smalltalk version. I think some, at least, are in the libsnprintfv sources. I think it will be worth checking. (Paolo - I'm at work -- could you forward him m

Re: snprintfv for gnulib?

2007-02-23 Thread Bruce Korb
Daniel, I don't think I copied you on an email -- there is a bug fix and a number of warning fixes in my version that did not make it into the smalltalk version. I think some, at least, are in the libsnprintfv sources. I think it will be worth checking. (Paolo - I'm at work -- could you forward

Re: FYI, utimens was missing a dependency on timespec

2007-02-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 2/22/2007 2:26 PM: > This fixes it: > > * modules/utimens (Depends-on): Add timespec, required for > utimens.h's inclusion of timespec.h. stat-time is another module that uses raw timespec.h without depending

Re: snprintfv for gnulib?

2007-02-23 Thread Paolo Bonzini
How should I initially configure this? It has a couple of support files already (compile, ltmain.sh) but not in the build-aux directory where it wants to find them, and not all of the necessary files e.g. config.sub. If the right answer is just "use --add-missing", then should we delete the exis

Re: snprintfv for gnulib?

2007-02-23 Thread Daniel Jacobowitz
On Fri, Feb 23, 2007 at 07:46:27AM -0500, Daniel Jacobowitz wrote: > How should I initially configure this? It has a couple of support > files already (compile, ltmain.sh) but not in the build-aux directory > where it wants to find them, and not all of the necessary files > e.g. config.sub. > > I

Re: snprintfv for gnulib?

2007-02-23 Thread Daniel Jacobowitz
On Fri, Feb 23, 2007 at 08:22:45AM +0100, Paolo Bonzini wrote: > I added you to the group to give you commit rights, > https://savannah.nongnu.org/cvs/?group=libsnprintfv has the instructions > for checking out the project. Is it ok if we use bug-gnulib@gnu.org, > for the time being, to host pa

Re: snprintfv for gnulib?

2007-02-23 Thread Paolo Bonzini
- The unlocked I/O module isn't actually what snprintfv wants. It needs flockfile and unlocked-io.h defines that to nothing. All it really wants is an autoconf check for unlocked IO. Yes, the same thing that gnulib does in getdelim: #if !HAVE_FLOCKFILE # undef flockfile # define flockfi

Re: snprintfv for gnulib?

2007-02-23 Thread Daniel Jacobowitz
On Fri, Feb 23, 2007 at 08:22:45AM +0100, Paolo Bonzini wrote: > Agreed. However, I'm sorry to say that you might have to restart part > of your work. I've checked in into the libsnprintfv repository on > savannah a merge of my work and Bruce's, except for the && || mismatch > that I have not