Re: Building m4 on BSDI 4.0.1

2007-01-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Chris McGuire on 1/12/2007 7:55 PM: > That was it, worked fine! > Hooray - the gnulib wchar module has seen its first happy customer. I'll check in the remaining m4 patches shortly; I've been camping on the ss_sp vs. ss_base patch for a

Re: Building m4 on BSDI 4.0.1

2007-01-12 Thread Eric Blake
Bruno Haible clisp.org> writes: > > 2007-01-12 Eric Blake byu.net> > > > > Provide a robust . Further simplifications are now > > possible in other modules, but not included here. > > Thanks. Looks fine, except 2 nits: OK, checked in with those nits fixed, along with a typo fix in

Re: Building m4 on BSDI 4.0.1

2007-01-12 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Here's my first cut at it. It currently assumes that absolute > exists. I'm not sure whether it is worth trying to check for > HAVE_WCHAR_H, or to leave that until we actually get a report of a system > that needs it. Yes, I'd leave it alone until then,

Re: [bug-gnulib] xreadlink.c initial buffer size guesstimate

2007-01-12 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > in the frequent case that the link is smaller than 1024 and that the > guess was right, both implementations call xmalloc just once. Thanks. I installed the following to make it more robust for this case. 2007-01-12 Paul Eggert <[EMAIL PROTECTED]>

Re: [bug-gnulib] updating with gnulib-tool

2007-01-12 Thread Bruno Haible
Lorenzo Bettini wrote: > I noticed, after an update that this file is also added in the gnulib > directory > > gnulib-common.m4 > > but it is not included in the tarbal, is it the expected behavior? It is harmless. gnulib-tool adds the file gnulib-common.m4 always; aclocal then determines wheth

Re: [bug-gnulib] updating with gnulib-tool

2007-01-12 Thread Eric Blake-1
> > > > Yes, just add gnulib-cache.m4 to EXTRA_DIST in your top-level > Makefile.am. > > See recent coreutils or m4 package releases for examples. > > > > I noticed, after an update that this file is also added in the gnulib > directory > > gnulib-common.m4 > > but it is not included in the

Re: [bug-gnulib] updating with gnulib-tool

2007-01-12 Thread Lorenzo Bettini
Eric Blake wrote: > According to Lorenzo Bettini on 12/20/2006 12:44 PM: >>> Thanks for the feedback. Last time we discussed whether gnulib-cache.m4 >>> should be added to EXTRA_DIST by gnulib-tool, so that anyone getting a >>> tarball can do "gnulib-tool --update", there was no consensus. A majori

Re: Building m4 on BSDI 4.0.1

2007-01-12 Thread Bruno Haible
Eric Blake wrote: > 2007-01-12 Eric Blake <[EMAIL PROTECTED]> > > Provide a robust . Further simplifications are now > possible in other modules, but not included here. > * modules/wchar: New module. > * m4/wchar.m4: New file. > * lib/wchar_.h: Likewise. > *

Re: [bug-gnulib] xreadlink.c initial buffer size guesstimate

2007-01-12 Thread Bruno Haible
Liyang HU wrote: > I've been getting ``ls: memory exhausted'' messages, which I eventually > tracked down to xreadlink() attempting to allocate several hundred MB of > memory, since that's what lstat() returns[0] for the symlink's st_size. > In actuality, the length of the symlink were mostly under

Re: Building m4 on BSDI 4.0.1

2007-01-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 1/11/2007 10:39 AM: > Eric Blake <[EMAIL PROTECTED]> writes: > >> At this point, I really think it is easier to generate a replacement >> that takes care of the intricacies, > > Yes, I'd like a wchar module that provides

Re: xreadlink.c initial buffer size guesstimate

2007-01-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Liyang HU on 1/11/2007 6:29 PM: > > [0] I know, lstat() should report the on-disk usage of the symlink; however > I thought of more nefarious uses for st_size. Consider my FS braindead if > you will, but xreadlink() needn't fail... Sorry

xreadlink.c initial buffer size guesstimate

2007-01-12 Thread Liyang HU
Hallo, I've been getting ``ls: memory exhausted'' messages, which I eventually tracked down to xreadlink() attempting to allocate several hundred MB of memory, since that's what lstat() returns[0] for the symlink's st_size. In actuality, the length of the symlink were mostly under 128 bytes. It s