import regex buffer-overrun fix from glibc

2006-09-20 Thread Paul Eggert
I installed this: 2006-09-20 Paul Eggert <[EMAIL PROTECTED]> Import this patch from libc: 2006-09-06 Jakub Jelinek <[EMAIL PROTECTED]> * lib/regex_internal.c (re_string_reconstruct): Handle offset < pstr->valid_raw_len && pstr->offsets_needed case. En

Re: Updating FreeBSD port

2006-09-20 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [I'm replying to several mails in this chain, sorry for any confusion it causes] According to Mikhail Teterin on 9/20/2006 8:59 AM: > On Wednesday 20 September 2006 09:28, Eric Blake wrote: > = > . Although FreeBSD's getopt.h is detected as sufficie

Re: Updating FreeBSD port

2006-09-20 Thread Paul Eggert
Mikhail Teterin <[EMAIL PROTECTED]> writes: > :-( Are there regex-patches currently waiting to be merged into GNU's libc? You can just do a diff between glibc and regex to find the list of patches. They aren't marshaled into a coherent set of small patches, which is the bottleneck. However, yo

Re: Updating FreeBSD port

2006-09-20 Thread Mikhail Teterin
середа 20 вересень 2006 17:12, Paul Eggert написав: > Mikhail Teterin <[EMAIL PROTECTED]> writes: > > However, there is not a single place anywhere in m4's code (outside of > > getopt*.c), where optind is set to zero. > > Other gnulib-using programs do rely on that functionality, though, so > we te

Re: Updating FreeBSD port

2006-09-20 Thread Mikhail Teterin
середа 20 вересень 2006 13:24, Paul Eggert написав: > Mikhail Teterin <[EMAIL PROTECTED]> writes: > > I see -- would you have a test-case, that detects this difference? > > No, but you can read the thread containing this message: > > http://lists.gnu.org/archive/html/bug-gnulib/2004-10/msg00171.htm

mkstemp.h needs a mention in modules/mkstemp

2006-09-20 Thread Paul Eggert
I intsalled this: 2006-09-20 Paul Eggert <[EMAIL PROTECTED]> * modules/mkstemp (Files): Add mkstemp.h. --- modules/mkstemp 20 Sep 2006 18:48:29 - 1.10 +++ modules/mkstemp 20 Sep 2006 22:32:08 - @@ -2,6 +2,7 @@ Description: mkstemp() function: create a private temp

Re: gnulib-tool should be interruptible

2006-09-20 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: >> That doesn't sound like much of a real problem, but if it is, this >> looks to me like a band-aid that doesn't solve things; it'd cut down >> the number of bogus messages without eliminating them. > > This I don't understand. If I do the output with

Re: Updating FreeBSD port

2006-09-20 Thread Paul Eggert
Mikhail Teterin <[EMAIL PROTECTED]> writes: > However, there is not a single place anywhere in m4's code (outside of > getopt*.c), where optind is set to zero. Other gnulib-using programs do rely on that functionality, though, so we test for it in gnulib. It's not worth the configuration hassle

mkstemp-safer followup

2006-09-20 Thread Paul Eggert
I also installed this further change, which shouldn't hurt either. That old HAVE_MKSTEMP code was bogus anyway, since it should have been HAVE_DECL_MKSTEMP. 2006-09-20 Paul Eggert <[EMAIL PROTECTED]> * mkstemp-safer.c: Include "mkstemp.h" instead of . (mkstemp): Remove, since mk

Re: [bug-gnulib] tempname.c patch from libc

2006-09-20 Thread Bruno Haible
> Import this patch from libc: > > 2006-04-07 Ulrich Drepper <[EMAIL PROTECTED]> > > * lib/tempname.c (__gen_tempname): Change attempts_min > into a macro. Use preprocessor to decide how to initialize > attempts [Coverity CID 67]. And I'm doing likewise for mkdte

Re: gnulib-tool should be interruptible

2006-09-20 Thread Ralf Wildenhues
[ Behdad, this is: http://lists.gnu.org/archive/html/bug-gnulib/2006-09/msg00221.html ] Hello Paul, * Paul Eggert wrote on Tue, Sep 19, 2006 at 06:10:07PM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > > * gnulib-tool (func_version): Create output all at once, to > > avoid trigg

Re: Mapping text files

2006-09-20 Thread Bruce Korb
On 9/20/06, Paul Eggert <[EMAIL PROTECTED]> wrote: > the correct response is something along the lines of EINVAL > whenever strlen(filedata) != filestat.st_size. The GNU coding standards disagree: they say "Utilities reading files should not drop NUL characters". Wait. I get it. The GNU codi

Re: 2G tmpfile of sort

2006-09-20 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: > Eric Blake <[EMAIL PROTECTED]> writes: > >> Thanks for the report. Which platform, which compiler, and which version >> of coreutils was this? If it is still present in coreutils 6.2, we would >> like to get it fixed before 6.3. > > Yes, likewise. > > Look

Re: Mapping text files

2006-09-20 Thread Paul Eggert
Bruce Korb <[EMAIL PROTECTED]> writes: > If valid data is supposed to be ASCII text, then what meaning > do you give to the NUL byte? It depends on the application. The NUL character is valid in ASCII. For 'sort', for example, it participates in comparison as the least-possible character. > If

Re: 2G tmpfile of sort

2006-09-20 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Thanks for the report. Which platform, which compiler, and which version > of coreutils was this? If it is still present in coreutils 6.2, we would > like to get it fixed before 6.3. Yes, likewise. Looking at the implementation, it seems like there are

tempname.c patch from libc

2006-09-20 Thread Paul Eggert
I installed this: 2006-09-20 Paul Eggert <[EMAIL PROTECTED]> Import this patch from libc: 2006-04-07 Ulrich Drepper <[EMAIL PROTECTED]> * lib/tempname.c (__gen_tempname): Change attempts_min into a macro. Use preprocessor to decide how to initialize

Re: Updating FreeBSD port

2006-09-20 Thread Paul Eggert
Mikhail Teterin <[EMAIL PROTECTED]> writes: > I see -- would you have a test-case, that detects this difference? No, but you can read the thread containing this message: http://lists.gnu.org/archive/html/bug-gnulib/2004-10/msg00171.html to see some of the issues here, and why gnulib getopt.m4 r

Re: Updating FreeBSD port

2006-09-20 Thread Mikhail Teterin
On Wednesday 20 September 2006 09:28, Eric Blake wrote: = > . Although FreeBSD's getopt.h is detected as sufficiently capable = > by configure, the getopt.c and getopt1.c are still compiled and = > linked into m4, instead of relying on the libc's versions = = No, the FreeBSD's geto

Re: Updating FreeBSD port

2006-09-20 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, According to Mikhail Teterin on 9/20/2006 7:06 AM: > Hello! > > In preparing an update of the FreeBSD port of m4 (currently at the 1.4.4) to > 1.4.6, I noticed the following minor nits: > > . Although FreeBSD's getopt.h is detected as suf