Re: regex compile warnings

Eric Blake <[EMAIL PROTECTED]> writes: > Is it worth silencing these compiler warnings with /usr/ucb/cc on Solaris 7? > > "../../lib/regex_internal.h", line 714: warning: token-less macro argument This one is worth fixing, since the code does not conform to C89. The obvious fix is to surround th

Re: typo in error module

Eric Blake <[EMAIL PROTECTED]> writes: > 2006-07-28 Eric Blake <[EMAIL PROTECTED]> > > * error.c (error_at_line): Match GNU Coding Standards. The change looks good, but the ChangeLog entry is a bit terse; could you please modify it to explain the bug it fixes. > Man, I wish there were an

Re: dates in gnulib ChangeLog entries

[EMAIL PROTECTED] writes: > Emacs doesn't highlight this new format well. Care to bring this idea > up on, e.g., emacs-devel? I'm a bit stretched for time right now, but you're welcome to bring it up, as an Emacs issue or as a GNU coding standards issue or both. I suppose it'd be nice if Emacs

Re: typo in error module

Ben Pfaff cs.stanford.edu> writes: > > Is it useful if it isn't pushed to glibc? It only updates code > inside an #ifdef _LIBC block. Actually, a different bug is present on non glibc platforms. When file_name is NULL, error_at_file omits the required space in "program: message". My amended

Re: typo in error module

Eric Blake <[EMAIL PROTECTED]> writes: > On glibc platforms, error_at_line currently violates GNU coding standards > when > the output stream is in wide character mode. OK to apply? Does this need to > be pushed to glibc? Is it useful if it isn't pushed to glibc? It only updates code inside

typo in error module

On glibc platforms, error_at_line currently violates GNU coding standards when the output stream is in wide character mode. OK to apply? Does this need to be pushed to glibc? 2006-07-28 Eric Blake <[EMAIL PROTECTED]> * error.c (error_at_line): Fix typo in wide string. Index: lib/er

regex compile warnings

Is it worth silencing these compiler warnings with /usr/ucb/cc on Solaris 7? "../../lib/regex_internal.h", line 714: warning: token-less macro argument "../../lib/regexec.c", line 1412: warning: non-constant initializer: op "--" -- Eric Blake

Re: split stdio-safer into fopen-safer, tmpfile-safer

Paul Eggert CS.UCLA.EDU> writes: > > With Bison I wanted fopen_safer but not tmpfile_safer (I think tmpfile > is not that safe due to signals and whatnot), so I split the fopen-safer > module into two, as follows: /usr/ucb/cc on Solaris 7 didn't like fopen-safer or tmpfile-safer: cc -Xc -D__EX

Re: [bug-gnulib] [PATCH]: mbchar.h and iswcntrl

Yoann Vandoorselaere wrote: > there are multiple "static" typo in your latest commit, please > apply the attached patch. Oops, sorry. Thanks, done. Bruno

Re: dates in gnulib ChangeLog entries

/Simon wrote: > Emacs doesn't highlight this new format well. This is a poor argument: 1) Emacs ChangeLog highlighting is known for not even supporting enumerations of functions, broken across lines: 2005-05-11 Bruno Haible <[EMAIL PROTECTED]> * flo_rest.d (SF_I_

netinet_in (was: Re: [PATCH]: arpa/inet.h inclusion warning under FreeBSD 4.x)

[EMAIL PROTECTED] writes: > [EMAIL PROTECTED] writes: > >> Yoann Vandoorselaere <[EMAIL PROTECTED]> writes: >> >>> On Fri, 2006-07-28 at 14:13 +0200, Bruno Haible wrote: Yoann Vandoorselaere wrote: > > #include > #include > + > +#ifdef HAVE_NETINET_IN_H > +

Re: [PATCH]: arpa/inet.h inclusion warning under FreeBSD 4.x

[EMAIL PROTECTED] writes: > Yoann Vandoorselaere <[EMAIL PROTECTED]> writes: > >> On Fri, 2006-07-28 at 14:13 +0200, Bruno Haible wrote: >>> Yoann Vandoorselaere wrote: >>> > >>> > #include >>> > #include >>> > + >>> > +#ifdef HAVE_NETINET_IN_H >>> > +# include >>> > +#endif >>> > + >>> >

Re: dates in gnulib ChangeLog entries

Paul Eggert <[EMAIL PROTECTED]> writes: > I noticed that recent changes (merging from gettext, for example) > added many ChangeLog entries whose dates disagree with when the change > was installed into gnulib. Hence gnulib's ChangeLog file appears not > to be in reverse chronological order. This

Re: [PATCH]: arpa/inet.h inclusion warning under FreeBSD 4.x

Yoann Vandoorselaere <[EMAIL PROTECTED]> writes: > On Fri, 2006-07-28 at 14:13 +0200, Bruno Haible wrote: >> Yoann Vandoorselaere wrote: >> > >> > #include >> > #include >> > + >> > +#ifdef HAVE_NETINET_IN_H >> > +# include >> > +#endif >> > + >> > #ifdef HAVE_ARPA_INET_H >> > # include

Re: [bug-gnulib] [PATCH]: mbchar.h and iswcntrl

On Fri, 2006-07-28 at 17:44 +0200, Yoann Vandoorselaere wrote: > On Fri, 2006-07-28 at 17:35 +0200, Bruno Haible wrote: > > Yoann Vandoorselaere wrote: > > > > Just for info: Which system is this which has a and a > > > > > > > > header file but no iswcntrl function? The isw* functions are the m

Re: [bug-gnulib] [PATCH]: mbchar.h and iswcntrl

On Fri, 2006-07-28 at 17:35 +0200, Bruno Haible wrote: > Yoann Vandoorselaere wrote: > > > Just for info: Which system is this which has a and a > > > header file but no iswcntrl function? The isw* functions are the main > > > contents of . I don't expect a system to have > > > but lack the func

Re: [bug-gnulib] [PATCH]: mbchar.h and iswcntrl

Yoann Vandoorselaere wrote: > > Just for info: Which system is this which has a and a > > header file but no iswcntrl function? The isw* functions are the main > > contents of . I don't expect a system to have > > but lack the functions. > > FreeBSD 4.x got the wctype.h header, however, the hea

Re: [bug-gnulib] [PATCH]: mbchar.h and iswcntrl

On Fri, 2006-07-28 at 14:18 +0200, Bruno Haible wrote: > Hi, > > Yoann Vandoorselaere wrote: > > mbchar.h make direct use of the iswcntrl function which is not available > > on some system. I made a patch using the same workaround as is done in > > mbswidth.c, although I'm not sure this is valid.

Re: [bug-gnulib] [PATCH]: arpa/inet.h inclusion warning under FreeBSD 4.x

On Fri, 2006-07-28 at 14:13 +0200, Bruno Haible wrote: > Yoann Vandoorselaere wrote: > > > > #include > > #include > > + > > +#ifdef HAVE_NETINET_IN_H > > +# include > > +#endif > > + > > #ifdef HAVE_ARPA_INET_H > > # include > > #endif > > Also, how about using #if instead of #ifdef, l

Re: [bug-gnulib] [PATCH]: mbchar.h and iswcntrl

Hi, Yoann Vandoorselaere wrote: > mbchar.h make direct use of the iswcntrl function which is not available > on some system. I made a patch using the same workaround as is done in > mbswidth.c, although I'm not sure this is valid. Just for info: Which system is this which has a and a header fil

Re: [bug-gnulib] [PATCH]: arpa/inet.h inclusion warning under FreeBSD 4.x

Yoann Vandoorselaere wrote: > > #include > #include > + > +#ifdef HAVE_NETINET_IN_H > +# include > +#endif > + > #ifdef HAVE_ARPA_INET_H > # include > #endif Also, how about using #if instead of #ifdef, like in the rest of gnulib? *** gnulib-20060722-modified/lib/inet_ntop.h2006-01

Re: stdio-safer and tmpfile

Eric Blake <[EMAIL PROTECTED]> writes: > m4/ChangeLog: > 2006-07-23 Eric Blake <[EMAIL PROTECTED]> > > * unistd-safer.m4 (gl_UNISTD_SAFER): Check for missing pipe. > > 2006-07-23 Eric Blake <[EMAIL PROTECTED]> > > * pipe-safer.c (pipe_safer) [!HAVE_FUNC_PIPE]: Provide fallback to >

Re: rewritten inttypes module

Bruno Haible <[EMAIL PROTECTED]> writes: > Here, as well as in many other places (including 'stdint'), we assume that > int and int32_t are the same. I don't wish to add more #ifdefs for cases > that are hypothetical. I was worried about the case where an implementation provides a conforming stdi

Re: stdint tweak

Bruno Haible <[EMAIL PROTECTED]> writes: > 2006-07-27 Bruno Haible <[EMAIL PROTECTED]> > > * m4/stdint.m4 (gl_STDINT_H): Define __STDC_CONSTANT_MACROS during the > test. > * lib/stdint_.h (INT*_C, UINT*_C) [C++]: Define these if > __STDC_CONSTANT_MACROS is defined, not if

modechange sync from coreutils

I installed this to sync from coreutils. This follows up on the discussion rooted at . 2006-07-28 Paul Eggert <[EMAIL PROTECTED]> * modechange.c (mode_compile): Numeric modes now affect setuid and setgid on d