OSF/4.0D strtold

2006-05-27 Thread Ralf Wildenhues
Tru64 UNIX 4.0D doesn't provide strtold (in the standard library at least), but /usr/include.dtk/stdlib.h provides a declaration. Thus the compile test in c-strtod.m4 fails. This causes a link failure for coreutils-5.96 printf. The patch below seems to fix this (but I don't know whether it shoul

Re: strfile: new module

2006-05-27 Thread Bruce Korb
OK. I can be an idiot, too. It has to be compiled with -DHAVE_MMAP (so I had an empty compile) and it needs a couple more headers: sys/stat.h, errno.h and fcntl.h.

Re: strfile: new module

2006-05-27 Thread Bruce Korb
Ralf Wildenhues wrote: * Simon Josefsson wrote on Sat, May 27, 2006 at 12:35:21PM CEST: I hadn't actually even compiled the module.. Let's put it this way: Using a mailing list to fix trivial compile warnings doesn't encourage further code reviews. It might also be useful to use mmap to loa

Re: [bug-gnulib] Re: nanosleep module and mingw32

2006-05-27 Thread Martin Lambers
On Tue, 23. May 2006, 22:21:15 +0200, Martin Lambers wrote: > With the new sys_select module and the attached changes to the nanosleep > module, my project compiles and links fine when crosscompiled using the > mingw package. I forgot to add the new file nanosleep.h to AC_LIBSOURCES. Here is an up

Re: strfile: new module

2006-05-27 Thread Ralf Wildenhues
* Simon Josefsson wrote on Sat, May 27, 2006 at 12:35:21PM CEST: > > I hadn't actually even compiled the module.. Let's put it this way: Using a mailing list to fix trivial compile warnings doesn't encourage further code reviews. * Simon Josefsson wrote on Sat, May 27, 2006 at 12:40:37PM CEST: >

Re: strfile: new module

2006-05-27 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > * Ralf Wildenhues wrote on Sat, May 27, 2006 at 12:22:35PM CEST: >> * Simon Josefsson wrote on Sat, May 27, 2006 at 12:12:59PM CEST: >> > + int save_errno = errno; >> >> You are using errno but not including . > > ...and realloc but not including . >

Re: strfile: new module

2006-05-27 Thread Simon Josefsson
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hi Simon, > > * Simon Josefsson wrote on Sat, May 27, 2006 at 12:12:59PM CEST: >> +int save_errno = errno; > > You are using errno but not including . Hi Ralf! Thanks. I hadn't actually even compiled the module.. Improved patch below. Index: mo

Re: strfile: new module

2006-05-27 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, May 27, 2006 at 12:22:35PM CEST: > * Simon Josefsson wrote on Sat, May 27, 2006 at 12:12:59PM CEST: > > + int save_errno = errno; > > You are using errno but not including . ...and realloc but not including . Please compile your code with lots of warnings enabled

Re: strfile: new module

2006-05-27 Thread Ralf Wildenhues
Hi Simon, * Simon Josefsson wrote on Sat, May 27, 2006 at 12:12:59PM CEST: > + int save_errno = errno; You are using errno but not including . Cheers, Ralf

strfile: new module

2006-05-27 Thread Simon Josefsson
This is used in GnuTLS, and I need it in Shishi now, so I thought that it should be a module. What do you think? Possibly, there should be a xstrfile too, that uses xrealloc... Thanks! Index: modules/strfile === RCS file: modules/s