Re: bugs in dirname module

2005-11-10 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > On the other hand, on cygwin, "./a:b" is a valid name whose base_name is > unambiguously "a:b" per POSIX, We needn't conform strictly to the POSIX spec as far as slashes go; otherwise we'd be forced to treat "a/b" as not having a directory separator. The

Re: bugs in dirname module

2005-11-10 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 11/10/2005 6:44 PM: > > This makes it sound like we cannot implement base_name using the > current approach. Currently, base_name always returns a suffix of the > original file name. But under Cygwin if the file name is "

Re: bugs in dirname module

2005-11-10 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > On cygwin, : can be a valid file character (cygwin has managed mounts, > where cygwin transparently translates the names in use by the program into > valid characters for the file system). There, drive letters are exactly > [A-Za-z]:, and all other leading

Re: gethrxtime: fall back on gettime?

2005-11-10 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > What do you think of making gethrxtime fall back on gettime? Yes, that makes sense to me. I installed the patch below. This also fixes the comments to match the code. > While we're on the subject, how about removing gettime's use > of time? If there

gethrxtime: fall back on gettime?

2005-11-10 Thread Jim Meyering
Hi Paul, What do you think of making gethrxtime fall back on gettime? Currently, if it can't find a monotonic timer, it tries gettimeofday, then resorts to using time. Those are also the last resorts of gettime. The difference is that if gethrxtime used gettime, it'd benefit by using nanotime or

Re: readline fix

2005-11-10 Thread Eric Blake
> > Some testing reveal that the readline strip any number of \n or \r at > the end: > > [EMAIL PROTECTED]:~$ cat foo.c > #include > > int main () { > char *foo = readline("bar: "); > size_t i; > > for (i = 0; i < strlen (foo); i++) > printf ("%02x\n", foo[i]); > } Your test app was

Re: readline fix

2005-11-10 Thread Simon Josefsson
Eric Blake <[EMAIL PROTECTED]> writes: > According to Simon Josefsson on 11/9/2005 7:17 PM: >> Is this right? I'm not sure what a portable way to remove EOL is. >> Anyway, I installed this because it work on known platforms. > > The concept is correct (the full-blown readline library does indeed