Re: arcfour

2005-10-15 Thread Simon Josefsson
Paul Eggert <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> writes: > >> Revised patch below. Ok to install? > > Yes, with one minor nit: > >> + *outbuf++ = *inbuf++ ^ >> +sbox[(0U + sbox[i] + sbox[j]) % ARCFOUR_SBOX_SIZE]; > > The usual GNU style is to parenthesize and

Re: rijndael

2005-10-15 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> Simon Josefsson <[EMAIL PROTECTED]> wrote: >>> Revised patch. >> >> Do those `U' suffixes serve any purpose, >> given an array base type of uint32_t? > > I don't know. Should I remove them? Please do. I sus