gnulib-tool tweak

2005-08-29 Thread Bruno Haible
* gnulib-tool (import): Avoid unnecessary spaces in $avoidlist. *** gnulib-tool.bak 2005-08-29 00:16:05.0 +0200 --- gnulib-tool 2005-08-29 00:10:56.0 +0200 *** *** 1231,1235 # Which modules to avoid? ! avoidlist="$avoidlist $ac_avoidlist"

Re: iconv_alloc for iconvme module

2005-08-29 Thread Bruno Haible
Oskar Liljeblad wrote: > Thanks. I didn't know free could clobber errno. (Do you know a system > where it does?) Yes: glibc systems. free() gives back unused memory to the system by calling munmap(). munmap() can clobber errno. Bruno ___ bug-gnulib m

gnulib-tool --import: more advice

2005-08-29 Thread Bruno Haible
To make gnulib-tool a little more developer-friendly: * gnulib-tool (func_import): Emit more comments into gnulib.m4. Emit more advice. *** gnulib-tool.bak 2005-08-29 00:16:05.0 +0200 --- gnulib-tool 2005-08-29 00:10:56.0 +0200 *** *** 836,839

gnulib-tool: robustness fix

2005-08-29 Thread Bruno Haible
I applied this: * gnulib-tool: Enclose all occurrences of $destdir in "...", so that it works when the directory contains spaces. *** gnulib-tool.bak 2005-08-25 14:36:00.0 +0200 --- gnulib-tool 2005-08-29 00:10:56.0 +0200 *** *** 789,795

Re: iconv_alloc for iconvme module

2005-08-29 Thread Oskar Liljeblad
On Monday, August 29, 2005 at 10:04, Simon Josefsson wrote: [..] > Same here, free may corrupt the errno from iconv (or others) that > should be returned. Thanks. I didn't know free could clobber errno. (Do you know a system where it does?) Another thing - I think you forgot to apply the iconvme.

Re: check-module

2005-08-29 Thread Stepan Kasal
Hello, On Mon, Jul 11, 2005 at 02:38:23PM +0200, Stepan Kasal wrote: > 2005-07-11 Bruno Haible <[EMAIL PROTECTED]> > and Stepan Kasal <[EMAIL PROTECTED]> > > * check-module: If more parameters are given, check each of them > separately; add more exceptions, as noted by Jim Me

Re: patch ping

2005-08-29 Thread Jim Meyering
Stepan Kasal <[EMAIL PROTECTED]> wrote: > could you please look at my patch submitted in > http://lists.gnu.org/archive/html/bug-gnulib/2005-07/msg00084.html That looks fine. Thanks for doing that. Please apply. ___ bug-gnulib mailing list bug-gnulib@

Re: [bug-gnulib] Re: [patch] byteswap module fails when building from subdir

2005-08-29 Thread Bruno Haible
Oskar Liljeblad wrote: > > byteswap.h: byteswap_.h > > - cp $(srcdir)/$< [EMAIL PROTECTED] > > + cp $(srcdir)/byteswap_.h [EMAIL PROTECTED] > > mv [EMAIL PROTECTED] $@ > > [..] > > I wrote that module. You didn't object to the patch, so I applied it now. Thanks, Ben. Bruno

Re: iconv_alloc for iconvme module

2005-08-29 Thread Simon Josefsson
"Oskar Liljeblad" <[EMAIL PROTECTED]> writes: > Here's a patch adding a function iconv_alloc to the iconvme module. > It differs from the function iconv_string in that it takes a previously > opened iconv descriptor instead of the explicit codeset names. Thanks! I installed this, after fixing tw