Re: getline

2005-07-17 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > 5. I have no idea whether using flockfile/funlockfile is appropriate. I'd say it's appropriate, but only if flockfile/funlockfile exist. They don't exist on all platforms. POSIX says they're optional; they're part of the Thread Safe Functions extensi

Re: [bug-gnulib] Re: quoting in gnulib

2005-07-17 Thread Bob Proulx
Bruno Haible wrote: > Paul Eggert wrote: > > I am using the latest release of Debian GNU/Linux (3.1, released only > > last month), and one of the most widely used browsers (Firefox 1.0.4 > > as maintained by Debian). But I can't read all the characters in that > > web page telling me how to quote

Re: getline

2005-07-17 Thread Simon Josefsson
5. I have no idea whether using flockfile/funlockfile is appropriate. The glibc code invoked some locking macros, which I translated into flockfile/funlockfile. getndelim2 does not appear to do any locking, though. Reading the man page for flockfile, using them didn't seem like an obv

Re: getline

2005-07-17 Thread Simon Josefsson
This is a rough start, to let you see my thinking. If this is OK, I'll write ChangeLog entries for it. The getdelim in glibc appear to suffer from a missing overflow check in the realloc call, but I may be mistaken. I fixed that while porting the code below. 1. There are separate modules for ge

Re: getline

2005-07-17 Thread Simon Josefsson
Paul Eggert <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> writes: > >> 1) Port the libc LGPL getdelim into a gnulib module. >> 2a) Port the libc LGPL getline into a gnulib module. >> 2b) Write a gnulib LGPL getline module that use the gnulib LGPL getdelim. >> 3) Keep the curren

Re: getline

2005-07-17 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > 1) Port the libc LGPL getdelim into a gnulib module. > 2a) Port the libc LGPL getline into a gnulib module. > 2b) Write a gnulib LGPL getline module that use the gnulib LGPL getdelim. > 3) Keep the current getndelim2 as a GPL module. > > The libc getli