Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>
>>>This seems a bit brittle. Why not simply try to compile this program?
>>>
>>> #include
>>> char a[_GNU_GLOB_INTERFACE_VERSION == 1 ? 1 : -1];
>>>
>>>
>>Because I like to avoid runtime tests if I can avoid it, since they
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Paul Eggert wrote:
>First, already we have something bogus: that __BEGIN_DECLS. It must
>be protected by "#ifdef _LIBC", since random C environments don't have
>it. Similarly for __END_DECLS.
Done.
>The simplest fix would be to do something like th
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>>Are you sure? You asked me to restore similar parens around bit-ands
>>back at several other locations despite other work that changed the
>>lines, in an earlier email. Not that I disagre
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> On Tue, 2005-05-17 at 14:21 +0200, Jim Meyering wrote:
>> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
...
> This requirement is technically wrong since you allow modification of
> the input argument through the user provided callback.
I am well
Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>
>
>>+#ifdef LIMITS_H_HAS_MINMAX
>>+# include
>>+#elif SYS_PARAM_H_HAS_MINMAX
>>+# include
>>+#endif
>>
>>
>
>This doesn't work if and both define MIN.
>
>
Hrm. Okay, I've fixed this, though I think such a system that i
Looking at m4/chown.m4, the test for defining
CHOWN_FAILS_TO_HONOR_ID_OF_NEGATIVE_ONE uses the wrong sense, since
ac_cv_func_chown_works is yes iff not cross-compiling and chown(f,-1,-1) didn't
change the struct stat owners. Furthermore, in lib/chown.c, when this C macro
is defined, the code v
Patch attached. I noticed that getcwd.c and regex.c also use MIN & MAX
without depending on minmax. Is this because they are shared with
glibc? Both use #ifdef _LIBC in places, though I noticed that getcwd.c
isn't in config/srclist. Would it be appropriate to have getcwd &/or
regex depend on mi
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
>>From a first look, the fts module file is lacking lstat, realloc and
> malloc dependencies (which also would need to have their license changed
> from GPL to LGPL).
Thanks. I'll add lstat.
It doesn't seem to require the malloc module, since there
On Mon, 2005-05-16 at 15:20 +0200, Jim Meyering wrote:
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> > This patch fix constness warning in the GnuLib hash module.
>
> I'm all for avoiding warnings, but not when it detracts from what I
> think of as the correctness of an interface, as it woul
Derek Price <[EMAIL PROTECTED]> writes:
> +#ifdef LIMITS_H_HAS_MINMAX
> +# include
> +#elif SYS_PARAM_H_HAS_MINMAX
> +# include
> +#endif
This doesn't work if and both define MIN.
> + AC_CHECK_HEADERS_ONCE([sys/param.h],
> +[gl_have_sys_param_h=:], [gl_have_sys_param_h=false])dnl
You
On Tue, 2005-05-17 at 08:59 +0200, Jim Meyering wrote:
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> > On Mon, 2005-05-16 at 15:20 +0200, Jim Meyering wrote:
> >> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> >> > This patch fix constness warning in the GnuLib hash module.
> >>
> >> I'm
Derek Price <[EMAIL PROTECTED]> writes:
>>This seems a bit brittle. Why not simply try to compile this program?
>>
>> #include
>> char a[_GNU_GLOB_INTERFACE_VERSION == 1 ? 1 : -1];
>
> Because I like to avoid runtime tests if I can avoid it, since they
> cannot be used when cross-compiling.
T
On Tue, 2005-05-17 at 14:21 +0200, Jim Meyering wrote:
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> >> > This patch fix constness warning in the GnuLib hash module.
>
> That patch fixes three of the four warnings produced by gcc -Wcast-qual.
> The final one is here:
>
> void *
> hash_i
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> On Mon, 2005-05-16 at 15:20 +0200, Jim Meyering wrote:
>> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
>> > This patch fix constness warning in the GnuLib hash module.
>>
>> I'm all for avoiding warnings, but not when it detracts from what I
>> t
On Mon, 2005-05-16 at 14:42 +0200, Jim Meyering wrote:
[...]
> Thanks for diagnosing that.
> I've confirmed that those modules are not needed,
> so I'll remove those lines.
Saw that the FTS module was checked in. Are you planing to do something
regarding the license problem ?
--
Yoann Vandoors
I installed this, imported from coreutils. It addresses the issue
that `unlink ("directory")' works on some hosts (e.g., Solaris,
OpenBSD) but not others (e.g., GNU/Linux, FreeBSD). Solaris 10 has a
new wrinkle: you can add/remove the privilege of unlinking a
directory.
2005-05-14 Paul Eggert
On Tue, 2005-05-17 at 10:47 +0200, Jim Meyering wrote:
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> ...
> > Saw that the FTS module was checked in. Are you planing to do something
> > regarding the license problem ?
>
> Of course :)
> As soon as that's resolved, I'll check in modules/fts.
Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>
>>minmax was so nice and small, but would you be willing to add an m4 file
>>which called AC_CHECK_HEADERS([sys/param.h]) and the following lines to
>>the beginning of minmax.h?
>>
>>#ifdef HAVE_SYS_PARAM_H
>># include
>>#endif
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Thanks for the latest round. I'm going to be out of the office today,
but I should get to it by tomorrow.
Regards,
Derek
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
>> > This patch fix constness warning in the GnuLib hash module.
That patch fixes three of the four warnings produced by gcc -Wcast-qual.
The final one is here:
void *
hash_insert (Hash_table *table, const void *entry)
{
...
return (v
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
...
> Saw that the FTS module was checked in. Are you planing to do something
> regarding the license problem ?
Of course :)
As soon as that's resolved, I'll check in modules/fts.
___
bug-gnulib mailing l
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> Another things is that including the fts module trigger a missing
> dependency:
> ../src/.libs/libprelude.so: undefined reference to `xalloc_die'
That's because the hash module uses xalloc.
You must tell gnulib-tool that you want to use xalloc-die,
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
...
>> It will be LGPL, since it's based on the glibc one which is LGPL.
...
> Well, there seem to be a few license problem with the dependencies:
> cycle-check, dirfd, hash, unistd-safer and xalloc are marked as GPL
> only, so the inclusion of FTS us
On Mon, 2005-05-16 at 10:36 +0200, Jim Meyering wrote:
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> ...
> >> It will be LGPL, since it's based on the glibc one which is LGPL.
> ...
> > Well, there seem to be a few license problem with the dependencies:
> > cycle-check, dirfd, hash, unistd-sa
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> This patch fix constness warning in the GnuLib hash module.
I'm all for avoiding warnings, but not when it detracts from what I
think of as the correctness of an interface, as it would in this case.
Those `const void *entry' parameters constitute
On Mon, 2005-05-16 at 11:27 +0200, Jim Meyering wrote:
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> ...
> >> The other files are not hidden :)
> >> They're part of coreutils.
> >
> > I will try by using these. Note that coreutils contain no fts.m4. I will
>
> You'll find it in the CVS repos
Hi,
This patch fix constness warning in the GnuLib hash module.
Regards,
--
Yoann Vandoorselaere | Responsable R&D / CTO | PreludeIDS Technologies
Tel: +33 (0)8 70 70 21 58 Fax: +33(0)4 78 42 21 58
http://www.prelude-ids.com
Index: lib/hash.c
===
On Mon, 2005-05-16 at 12:57 +0200, Jim Meyering wrote:
> Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> >>From a first look, the fts module file is lacking lstat, realloc and
> > malloc dependencies (which also would need to have their license changed
> > from GPL to LGPL).
>
> Thanks. I'll ad
On Mon, 2005-05-16 at 13:04 +0200, Yoann Vandoorselaere wrote:
> On Mon, 2005-05-16 at 12:57 +0200, Jim Meyering wrote:
> > Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> > >>From a first look, the fts module file is lacking lstat, realloc and
> > > malloc dependencies (which also would need to
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> On Mon, 2005-05-16 at 13:04 +0200, Yoann Vandoorselaere wrote:
>> On Mon, 2005-05-16 at 12:57 +0200, Jim Meyering wrote:
>> > Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
>> > >>From a first look, the fts module file is lacking lstat, realloc and
Paul Eggert wrote:
>Derek Price <[EMAIL PROTECTED]> writes:
>
>
>
>> /* Enable GNU extensions in glob.h. */
>>-#ifndef _GNU_SOURCE
>>+#if defined _LIBC && !defined _GNU_SOURCE
>> # define _GNU_SOURCE 1
>> #endif
>>
>>
>
>I just checked the glibc source file include/libc-symbols.h, and it
>d
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
...
>> The other files are not hidden :)
>> They're part of coreutils.
>
> I will try by using these. Note that coreutils contain no fts.m4. I will
You'll find it in the CVS repository for the project on Savannah:
savannah.gnu.org/projects/coreuti
Derek Price <[EMAIL PROTECTED]> writes:
>>Why do we need to include here? All we need is size_t,
>>right? And stddef.h gives us that.
>
> If I don't, I get the following error:
>
> In file included from glob.c:23:
> glob.h:107: error: syntax error before "struct"
> In file included from /usr/in
Yoann Vandoorselaere <[EMAIL PROTECTED]> wrote:
> Hi Jim,
>
> I just wanted to know if it is finally planed that the coreutils FTS
> module will be included in GnuLIB. Henry originally did his FTS module
> for the Prelude project, and we needed this module to be LGPL.
>
> So my question is whether
Derek Price <[EMAIL PROTECTED]> writes:
> Are you sure? You asked me to restore similar parens around bit-ands
> back at several other locations despite other work that changed the
> lines, in an earlier email. Not that I disagree now. I actually prefer
> the version without the unnecessary par
35 matches
Mail list logo
