Re: [bug-gnulib] New GNULIB glob module?

2005-05-14 Thread Paul Eggert
Now for commentary on glob.h. Derek Price <[EMAIL PROTECTED]> writes: > --- ../glibc-2.3.5/posix/glob.h 2004-09-16 20:55:15.0 -0400 > +++ lib/glob_.h 2005-05-13 12:21:39.0 -0400 > @@ -19,29 +19,48 @@ > #ifndef _GLOB_H > #define _GLOB_H 1 > > -#include >

Re: [bug-gnulib] New GNULIB glob module?

2005-05-14 Thread Paul Eggert
Derek Price <[EMAIL PROTECTED]> writes: > /* Enable GNU extensions in glob.h. */ > -#ifndef _GNU_SOURCE > +#if defined _LIBC && !defined _GNU_SOURCE > # define _GNU_SOURCE 1 > #endif I just checked the glibc source file include/libc-symbols.h, and it defines both _LIBC and _GNU_SOURCE. So th

Re: [bug-gnulib] Unused variable in regex.c

2005-05-14 Thread Paul Eggert
Derek Price <[EMAIL PROTECTED]> writes: > -char *destination; > \ Sorry, this patch doesn't look right to me. The comment in front of PUSH_FAILURE_POINT says that DOUBLE_FAIL_STACK requires `destination'. Perhaps it's not required on you

Re: [bug-gnulib] stdint_.h update

2005-05-14 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > + #elif defined(_MSC_VER) > + typedef __int64 int64_t; > + typedef unsigned __int64 uint64_t; > #endif Shouldn't that typedef of int64_t be protected by "#ifdef NEED_SIGNED_INT_TYPES"? That is done everywhere else that int64_t is declared. (

[bug-gnulib] Re: stdint_.h update

2005-05-14 Thread Bruno Haible
Hi Jim, > Then, look carefully and you'll see that all three branches > are the same, so you can condense them into one: > > #if @HAVE_LONG_64BIT@ || @HAVE_LONG_LONG_64BIT@ || defined _MSC_VER > # define INT64_MIN (~INT64_MIN) > # define INT64_MAX INT64_C(9223372036854775807) > # defin

[bug-gnulib] Re: stdint_.h update

2005-05-14 Thread Jim Meyering
Hi Bruno, > 2005-05-13 Bruno Haible <[EMAIL PROTECTED]> > > * stdint_.h (int64_t, uint64_t, int_least64_t, uint_least64_t, > int_fast64_t, uint_fast64_t, intmax_t, uintmax_t, INT64_MIN, INT64_MAX, > UINT64_MAX, INT_LEAST64_MIN, INT_LEAST64_MAX, UINT_LEAST64_MAX, > INT_FAS

[bug-gnulib] stdint_.h update

2005-05-14 Thread Bruno Haible
Hi, I committed this patch. It enables the use of 64-bit integer types in MSVC (which is also the compiler used in 'uwin'). 2005-05-13 Bruno Haible <[EMAIL PROTECTED]> * stdint_.h (int64_t, uint64_t, int_least64_t, uint_least64_t, int_fast64_t, uint_fast64_t, intmax_t, uintmax