bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-06 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
Juri Linkov writes: [...] > The current implementation is based on long discussions including bug#18132. > So everyone is welcome to improve it, it's not cast in stone. Thanks for the pointer. I'm proposing the following patch then. >From d8e59996f8a8dccd564cb27e5a2a56f83cb2db6f Mon Sep 17 00:

bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-05 Thread Juri Linkov
>>> > And is xdg-open reliably available on BSD systems, so that we don't >>> > generate an opaque error message if that is not the case? >>> >>> I think it would work whether xdg-open is install or not because >>> `shell-command-guess-open' is defined by testing the presence of >>> xdg-open. So i

bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-05 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
Eli Zaretskii writes: >> Cc: 73...@debbugs.gnu.org >> Date: Thu, 05 Sep 2024 15:48:12 +0200 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > And is xdg-open reliably available on BSD systems, so that we don't >> > generate an opaque error

bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-05 Thread Philip Kaludercic
Eli Zaretskii writes: >> Cc: 73...@debbugs.gnu.org >> Date: Thu, 05 Sep 2024 15:48:12 +0200 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > And is xdg-open reliably available on BSD systems, so that we don't >> > generate an opaque error

bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-05 Thread Eli Zaretskii
> Cc: 73...@debbugs.gnu.org > Date: Thu, 05 Sep 2024 15:48:12 +0200 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > And is xdg-open reliably available on BSD systems, so that we don't > > generate an opaque error message if that is not the cas

bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-05 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
Philip Kaludercic writes: [...] >> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >> index cd948bd7dd9..97b1e28a4ff 100644 >> --- a/lisp/dired-aux.el >> +++ b/lisp/dired-aux.el >> @@ -1472,7 +1472,7 @@ dired-do-open >> (when command >>(dolist (file files) >> (cond >> -

bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-05 Thread Philip Kaludercic
Manuel Giraud writes: > Tags: patch > > Hi, > > Here is a patch to make `dired-do-open' work on some non GNU/Linux > systems. I have tested it on OpenBSD with "xdg-open" installed. > > Thanks, > > In GNU Emacs 31.0.50 (build 19, x86_64-unknown-openbsd7.6) of 2024-09-02 > built on computer > Rep

bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

2024-09-03 Thread Bug reports for GNU Emacs, the Swiss army knife of text editors
Tags: patch Hi, Here is a patch to make `dired-do-open' work on some non GNU/Linux systems. I have tested it on OpenBSD with "xdg-open" installed. Thanks, In GNU Emacs 31.0.50 (build 19, x86_64-unknown-openbsd7.6) of 2024-09-02 built on computer Repository revision: 92ea393a16e5c99a8860dab368