bug#72652: 31.0.50; url-retrieve on non-existent domain gives no indication of error

2024-09-12 Thread Dmitry Gutov
On 17/08/2024 15:54, Greg Minshall wrote: Patches to report an error in the (mytry 2) case are welcome. that'd be great. thanks. For those who'd like to try their hand at writing the fix, https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26835#18 might be relevant, or at least point to the prob

bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command

2024-09-12 Thread Dmitry Gutov
On 03/08/2024 18:38, Eli Zaretskii wrote: comint-terminfo-terminal affects async-shell-command, why not this? Ugh! A mistake, IMNSHO. But that ship sailed a long time ago, so we cannot fix the mistake. We can avoid enlarging the mistake, though. If the fact that the variable is in comint is

bug#73172: [PATCH] Move to start of current header in diff-{file, hunk}-prev

2024-09-12 Thread Dmitry Gutov
Hi Spencer and Stefan, On 10/09/2024 21:40, Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: (The following change is split across two patches; the first one, "move easy-mmode", fixes an unrelated FIXME, which makes the diff in the second patch simpler)

bug#43086: [PATCH] Allow tags backend to not query for TAGS file

2024-09-10 Thread Dmitry Gutov
On 10/09/2024 15:45, Eli Zaretskii wrote: Cc: phil...@posteo.net, 43...@debbugs.gnu.org Date: Tue, 10 Sep 2024 14:41:43 +0300 From: Eli Zaretskii How do you feel about etags-regen-mode being on by default in some next Emacs release? It shouldn't conflict with the manual invocations of 'M-x vis

bug#43086: [PATCH] Allow tags backend to not query for TAGS file

2024-09-10 Thread Dmitry Gutov
On 10/09/2024 14:41, Eli Zaretskii wrote: But what do you expect from a backend that depends on TAGS to do when TAGS is not there? You yourself just noticed the regression. Why would we want that? I'm thinking of the xref-find-references case - where the scanner doesn't depend on the tags ta

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-10 Thread Dmitry Gutov
On 10/09/2024 14:47, Eli Zaretskii wrote: Date: Tue, 10 Sep 2024 03:58:58 +0300 Cc:joaotav...@gmail.com,72...@debbugs.gnu.org From: Dmitry Gutov The backtrace that I managed to generate is attached. Thanks. Please try the patch below. Thanks! The patch takes care of the crash AFAICS (no

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-09 Thread Dmitry Gutov
Hi Joao, On 08/09/2024 18:51, João Távora wrote: So, for the record, before this patch with the latest emacs-30, I get the results in failure1.txt I've taken some more looks at the test output. [eglot-tests] contents of `*EGLOT (cmpl-project/(rust-mode rust-ts-mode)) output*': [eglot-tests]

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-09 Thread Dmitry Gutov
On 09/09/2024 14:46, Eli Zaretskii wrote: Date: Mon, 9 Sep 2024 03:20:01 +0300 Cc: Eli Zaretskii , 72...@debbugs.gnu.org From: Dmitry Gutov This now aborts (segfault?). At least something different. So, for the record, before this patch with the latest emacs-30, I get the results in

bug#43086: [PATCH] Allow tags backend to not query for TAGS file

2024-09-09 Thread Dmitry Gutov
On 09/09/2024 14:54, Eli Zaretskii wrote: Date: Mon, 9 Sep 2024 03:29:05 +0300 Cc: phil...@posteo.net, 43...@debbugs.gnu.org From: Dmitry Gutov On 07/09/2024 09:18, Eli Zaretskii wrote: Maybe just like this? This makes Xref identifier completion not query for TAGS unless already loaded. In

bug#43086: [PATCH] Allow tags backend to not query for TAGS file

2024-09-08 Thread Dmitry Gutov
On 07/09/2024 09:18, Eli Zaretskii wrote: Maybe just like this? This makes Xref identifier completion not query for TAGS unless already loaded. In many cases that would be TRT, although `C-u M-.` seems to regress (seems like we *would* want to query eagerly there). I don't understand why the o

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-08 Thread Dmitry Gutov
On 08/09/2024 18:51, João Távora wrote: Looking at minibuffer-tests.el, the above might be a solution, but it gets me a core dump instead: diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el index e0168baee54..fa3b63b38dc 100644 --- a/test/lisp/progmodes/eglot-te

bug#72701: eglot crash when project-files-relative-names t

2024-09-08 Thread Dmitry Gutov
On 08/09/2024 13:56, João Távora wrote: On Sun, Sep 8, 2024 at 3:24 AM Dmitry Gutov wrote: On 07/09/2024 10:20, Eli Zaretskii wrote: Ping! Is this issue resolved and can be closed, or do we need to do anything else here? I suggest installing the following. Not a hard necessity, but seems

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-07 Thread Dmitry Gutov
On 03/09/2024 16:43, João Távora wrote: On Tue, Sep 3, 2024 at 2:20 PM Dmitry Gutov wrote: On 01/09/2024 17:28, Dmitry Gutov wrote: * the rust-analyzer test you added recently -- and which you said was very brittle -- is indeed very brittle: I cannot get it to pass. We should fix it

bug#72701: eglot crash when project-files-relative-names t

2024-09-07 Thread Dmitry Gutov
On 07/09/2024 10:20, Eli Zaretskii wrote: Ping! Is this issue resolved and can be closed, or do we need to do anything else here? I suggest installing the following. Not a hard necessity, but seems like an improvement: diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index acc

bug#73044: [PATCH] Add project-find-file-in-root

2024-09-07 Thread Dmitry Gutov
On 07/09/2024 09:10, Eli Zaretskii wrote: If you consider this not important enough to be in the manual, please mark the NEWS entry with "---", to convey your opinion. Added, thanks. Also split the entry into two lines.

bug#72768: [PATCH] Keep local keymap out of vc-git-stash-get-at-point

2024-09-07 Thread Dmitry Gutov
Version: 31.1 On 07/09/2024 10:33, Eli Zaretskii wrote: Date: Tue, 27 Aug 2024 03:37:54 +0530 From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" James Thomas wrote: emacs -Q (define-key key-translation-map [?\C-j] (kbd "RET")) M-x vc-dir (select a git

bug#70968: 29.2.50; choose-completion on an emacs22-style completion deletes text after point

2024-09-07 Thread Dmitry Gutov
On 07/09/2024 10:30, Eli Zaretskii wrote: Date: Mon, 26 Aug 2024 03:08:56 +0300 Cc:sba...@janestreet.com,70...@debbugs.gnu.org,j...@linkov.net, monn...@iro.umontreal.ca From: Dmitry Gutov On 16/05/2024 21:25, Eli Zaretskii wrote: I don't think that would be required exactly. The pr

bug#43086: [PATCH] Allow tags backend to not query for TAGS file

2024-09-06 Thread Dmitry Gutov
On 03/09/2024 19:39, Philip Kaludercic wrote: I could imagine this might be extended to allow an auto-generate option, but that feature seems out of scope of this patch, and probably would require some interoperation with project.el. Indeed. Actually, I have an old, WIP patch for tag file auto-g

bug#73044: [PATCH] Add project-find-file-in-root

2024-09-06 Thread Dmitry Gutov
On 06/09/2024 20:44, Eli Zaretskii wrote: Resent-To:bug-gnu-emacs@gnu.org Date: Fri, 6 Sep 2024 19:20:16 +0300 From: Dmitry Gutov This command is equivalent to C-x p o C-x C-f, but it's nice to be able to bind it to a specific key. Overall, this is easy enough to provide, so let'

bug#73044: [PATCH] Add project-find-file-in-root

2024-09-06 Thread Dmitry Gutov
Version: 31.1 Hi Spencer, On 05/09/2024 17:01, Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: Several users have asked me for a command which is just find-file, but starting from the project root. In large projects, where project-files is expensive, t

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-03 Thread Dmitry Gutov
On 01/09/2024 17:28, Dmitry Gutov wrote: * the rust-analyzer test you added recently -- and which you said was    very brittle -- is indeed very brittle: I cannot get it to pass.  We    should fix it, or just delete it and do those rust-analyzer tests    manually each time we touch this area

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-02 Thread Dmitry Gutov
On 02/09/2024 04:56, Aaron Jensen wrote: It seems to me that anything other than 0 spaces would look inconsistent with the first element (the hash), and its closing brace in particular. Yeah, that's my sense as well, even if it looks awful, but you get what you get. * Support for the new optio

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Dmitry Gutov
On 02/09/2024 03:49, Aaron Jensen wrote: Here's a bonus example which looks off but would be more difficult to fix (and it's not urgent, given the expression is in mixed styles): foo([{ a: 2 }, { b: 3 }, 4 ]) Yes, that's connected to the case I mentione

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Dmitry Gutov
On 01/09/2024 22:28, Aaron Jensen wrote: Here's a corrected patch for that particular example. Thank you for finding that. I think I missed it because as long as you type the code in, it indents fine. I still have a lot to understand about SMIE, so if anything looks off in my patch, please let

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call

2024-09-01 Thread Dmitry Gutov
Hi Aaron! On 01/09/2024 03:54, Aaron Jensen wrote: Updated patch with more precise variables in the new test. Thanks for taking the initiative. Here's an example which seems to get worse with the new variable set to nil: def foo foo.update( { key => value, other_key: foo } ) end I'd

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-09-01 Thread Dmitry Gutov
On 01/09/2024 12:43, João Távora wrote: It seems the difference comes from bug#70968 as well (which came up recently). Okay, but that presumed bug has nothing to do with Eglot, AFAICT. One could argue that the current definition of the style (in Eglot) relies on buggy (or suboptimal) behavi

bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text

2024-08-31 Thread Dmitry Gutov
On 31/08/2024 15:03, João Távora wrote: Eglot aims primarily at that, since it's what's in Emacs proper. But Eglot also aims at supporting Company in particular as fully as possible. Anyway, I don't have time to investigate this. The :exit-function in eglot.el should be stepped through to under