getrlimit() patch

2018-07-16 Thread Barath Aron
Hello, I made a patch that fixes (at least to me) the declaration of an unused variable if HAVE_GETRLIMIT is false. The OS I use does not have getrlimit(). Is sysconf(3) mandatory? Because it is not guarded (HAVE_SYSCONF ?). It is a few lines below where my patch applies. And a quick questi

Re: getrlimit() patch

2018-07-16 Thread Barath Aron
Hello, Sorry for the self-reply. I have an additional suggestion for an alternate method: getdtablesize(2) returns the current limit on the number of open files per process. This also can be used in get_max_fd function. Aron On 07/16/2018 11:24 AM, Barath Aron wrote: Hello, I made a patch

Re: [Findutils-patches] Rebased extended attribute (-xattr) and capabilty (-cap) patch for find

2018-07-16 Thread Morgan Weetman
Hi all, Many thanks to Pavel for helping me with autoconf, I am resubmitting the patch for xattr and cap support which is now deconfigurable... cheers On 13 July 2018 at 01:08, Pavel Raiskup wrote: > Hi Morgan, > > On Tuesday, January 19, 2016 12:02:24 PM CEST Morgan Weetman wrote: > > Hey Ber

Re: Manual Readability Feedback

2018-07-16 Thread Bernhard Voelker
On 07/12/2018 03:17 AM, Dale R. Worley wrote: > Bernhard Voelker writes: >>> "Only use 'assert' to catch fully-implemented features of your code." >> ^~~~ >> >> This sounds odd to me - as non-native English speaker - as well. >> What about "Avoid

Re: configure issue: getfsstat(), 'struct statfs' and 'struct fsstat'

2018-07-16 Thread Bernhard Voelker
[forwarding to gnulib] On 07/11/2018 02:00 PM, Barath Aron wrote: > Hello, > > I have a little issue around the detection of the getfsstat() function. > > According to multiple manuals from different BSD versions [1,2], the > signature of the BSD's getfsstat() is this: > int getfsstat(struct st

[bug #46305] Doing "find -L . -type d -delete" fails on symlinks to directories.

2018-07-16 Thread Bernhard Voelker
Follow-up Comment #3, bug #46305 (project findutils): With "-L bar -delete", find would have to delete 2 files: a) the symlink target '../foo', and b) the symlink itself 'bar/baz'. I agree with James that trying to fix (or work around) this would probably more ask for trouble than being of help.

Re: configure issue: getfsstat(), 'struct statfs' and 'struct fsstat'

2018-07-16 Thread Paul Eggert
On 07/16/2018 01:05 PM, Bernhard Voelker wrote: So, my questions are: a) Why the configure use a different type name? Comments suggest that this is what OSF/1 used. b) If it is intentional, then where that type is defined? Presumably in system include files. c) Is this branch of the config

Re: [Findutils-patches] Rebased extended attribute (-xattr) and capabilty (-cap) patch for find

2018-07-16 Thread Morgan Weetman
Many thanks for all your assistance with autoconf Pavel... an updated patch supporting de-configuration is attached for review On 13 July 2018 at 01:08, Pavel Raiskup wrote: > Hi Morgan, > > On Tuesday, January 19, 2016 12:02:24 PM CEST Morgan Weetman wrote: > > Hey Berny, > > > > I've never pl

Re: configure issue: getfsstat(), 'struct statfs' and 'struct fsstat'

2018-07-16 Thread Barath Aron
Hi, Thank you all for the answers. Let me merge Bruno's mail first: On 07/17/2018 12:02 AM, Bruno Haible wrote: The configuration of the gnulib 'mountlist' module (used by findutils and coreutils, among others) is written in such a way that on OpenBSD it uses the getmntinfo() function https

Re: [Findutils-patches] Rebased extended attribute (-xattr) and capabilty (-cap) patch for find

2018-07-16 Thread Pavel Raiskup
Hi Morgan, thanks for the update! (in-line patch would be better) For maintainers, since Morgan is Red Hat employee no copyright paperwork is needed. On Tuesday, July 17, 2018 2:05:15 AM CEST Morgan Weetman wrote: > diff --git a/configure.ac b/configure.ac > index 2acf54c7..ab286b6c 100644 You