Re: [Patch] faster fnmatch

2009-05-01 Thread Bruno Haible
Hello Ondrej, Nice work already! > *abc* > en_US.UTF-8 > user: 2.71 > user: 0.23 > ... > *ab[a-z]* > en_US.UTF-8 > user: 2.85 > user: 3.32 > C > user: 0.86 > user: 1.25 Hmm, well, users are expecting a speedup through your module always. If it some (not too rare) cases the glibc fnmatch is

Re: [Patch] faster fnmatch

2009-05-01 Thread Ralf Wildenhues
Hello Ondrej, * Ondrej Bilka wrote on Thu, Apr 30, 2009 at 10:41:49PM CEST: > I here attach compiled fnmatch I wrote as gnulib module. I haven't read your patch closely, but it fails to check the return value from all of the malloc/realloc... functions, opening up several opportunities for segme

[Patch] faster fnmatch

2009-04-30 Thread Ondrej Bilka
Hello I here attach compiled fnmatch I wrote as gnulib module. It always should give same answer as fnmatch. Still I assume UTF8 or singlebyte encoding otherwise I fallback. I could generalize this to wide characters but if I dont know any character is single wchar I cannot do much (UTF16 wchar i

Re: faster fnmatch

2009-04-20 Thread Ondrej Bilka
bitwise. Its in most cases faster. > > fnmatch converts to wide characters because it often makes several passes > across many characters of the string, and at each pass it has to call mbrtowc > for looking up the extent of that character. And while UTF-8 is the most > common encoding, th

Re: faster fnmatch

2009-04-18 Thread Bruno Haible
Ondrej Bilka wrote: > I looked more into source and discovered fnmatch doesn't work as I imagined. > By default it converts strings into widechars and match there. > utf8 allows searching be done bitwise. Its in most cases faster. fnmatch converts to wide characters because

Re: faster fnmatch

2009-04-18 Thread Ondrej Bilka
On Fri, Apr 17, 2009 at 01:02:57PM +0200, Bruno Haible wrote: > Hello Ondrej, > > > > Hello. I am writing partial fnmatch to speed up locate et al. > > Cool! We know for some time already that this is a bottleneck [1]. > I find it also interesting that you go for a two-step approach, > preprocess

Re: faster fnmatch

2009-04-17 Thread Bruno Haible
Hello Ondrej, > > Hello. I am writing partial fnmatch to speed up locate et al. Cool! We know for some time already that this is a bottleneck [1]. I find it also interesting that you go for a two-step approach, preprocess the pattern once and use it for matching often - the same approach that we

Re: faster fnmatch

2009-04-17 Thread James Youngman
[ CC += bug-findutils, bug-gnulib; bug-coreutils moved to BCC ] On Thu, Apr 16, 2009 at 8:09 PM, Ondrej Bilka wrote: > Hello. I am writing partial fnmatch to speed up locate et al. Please note that locate is part of GNU findutils, not GNU coreutils. I have CC'ed this email to the correct list.