Re: Conversion of GNU find to use gnulib's fts interface

2005-09-04 Thread James Youngman
On Sat, Jul 30, 2005 at 11:27:09PM +0100, James Youngman wrote: > I have made a CVS branch and modified findutils to use fts also. I am about to begin concurrently releasing findutils 4.2.x (a "stable" branch) and 4.3.x (a "development" branch). The princpal thing provoking this is the change

Re: Conversion of GNU find to use gnulib's fts interface

2005-08-11 Thread James Youngman
On Thu, Aug 11, 2005 at 09:25:19PM -0600, Eric Blake wrote: > It turns out that a patch to cygwin to make open(".", O_RDONLY) always > work if the directory is readable fixed find; so that find does the right > thing out-of-the-box (with or without fts) in the upcoming cygwin-1.5.19. > Unless som

Re: Conversion of GNU find to use gnulib's fts interface

2005-08-11 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to James Youngman on 8/7/2005 1:24 PM: >>However, I am not sure why the leaf files are reporting >>an error in find, when they listed just fine with ls. > > Sorry, I'm unable to help there since I have no access to a Cygwin > system to test

Re: Conversion of GNU find to use gnulib's fts interface

2005-08-08 Thread James Youngman
On Mon, Aug 08, 2005 at 06:21:16AM -0600, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to James Youngman on 8/7/2005 1:24 PM: > >>cvs checkout: move away findutils/debian/changelog; it is in the way > > > > Now fixed in the trunk. > > Can you also fix it in t

Re: Conversion of GNU find to use gnulib's fts interface

2005-08-08 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to James Youngman on 8/7/2005 1:24 PM: >>cvs checkout: move away findutils/debian/changelog; it is in the way > > Now fixed in the trunk. Can you also fix it in the fts-conversion branch? And the cygwin build bug, with patch posted to sava

Re: Conversion of GNU find to use gnulib's fts interface

2005-08-07 Thread James Youngman
On Fri, Aug 05, 2005 at 07:02:49AM -0600, Eric Blake wrote: > I tried this on cygwin, and the first thing I noticed was that CVS has > files with case conflicts: Thanks for doing the tests. > cvs checkout: move away findutils/debian/changelog; it is in the way Now fixed in the trunk. > cvs che

Re: Conversion of GNU find to use gnulib's fts interface

2005-08-05 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > I'd like to enlist your help - yes yours - in testing this. It's > probably the most significant change made to findutils since I became > maintainer. I need hardly say that testing is very important indeed, > as a small mistake here could affect a

Re: Conversion of GNU find to use gnulib's fts interface

2005-07-31 Thread James Youngman
On Sun, Jul 31, 2005 at 10:56:41AM +0200, Jim Meyering wrote: > James Youngman <[EMAIL PROTECTED]> wrote: > > I have made a CVS branch and modified findutils to use fts also. This > > Great! Thank you for doing that! > I'll certainly switch to that version for my personal use. > In working on co

Re: Conversion of GNU find to use gnulib's fts interface

2005-07-31 Thread James Youngman
My earlier email described the branch that the fts find code lives on. If you want to test this you may find it helpful to use the test suite from the CVS trunk, not the branch. This has two advantages:- 1. It ensures that we use the same tests and don't end up with any unexpected incompatibil

Re: Conversion of GNU find to use gnulib's fts interface

2005-07-31 Thread Jim Meyering
James Youngman <[EMAIL PROTECTED]> wrote: > I have made a CVS branch and modified findutils to use fts also. This Great! Thank you for doing that! I'll certainly switch to that version for my personal use. In working on coreutils, sometimes I've wanted to use find on pathologically deep hierarch

Re: Conversion of GNU find to use gnulib's fts interface

2005-07-31 Thread James Youngman
On Sun, Jul 31, 2005 at 09:44:11AM +0200, Andreas Metzler wrote: > this fails to build from source for me. Oops. > find.c:89: error: static declaration of 'default_prints' follows non-static > declaration > defs.h:523: error: previous declaration of 'default_prints' was here > /tmp/findutils-rft

Re: Conversion of GNU find to use gnulib's fts interface

2005-07-31 Thread Andreas Metzler
On 2005-07-31 Andreas Metzler <[EMAIL PROTECTED]> wrote: [...] > "autoreconf -i" is also not happy, this might be connected: > *prompt* autoreconf -i > m4/withfts.m4:1: warning: underquoted definition of FIND_WITH_FTS > run info '(automake)Extending aclocal' > or see http://sources.redhat.com/a

Re: Conversion of GNU find to use gnulib's fts interface

2005-07-31 Thread Andreas Metzler
On 2005-07-31 James Youngman <[EMAIL PROTECTED]> wrote: [...] > cvs -z3 -d:ext:[EMAIL PROTECTED]:/cvsroot/findutils \ > co -rfts-conversion findutils > Then you need to follow the simple instructions in the README-CVS file > to compile the findutils code. When building the code, don't forge

Conversion of GNU find to use gnulib's fts interface

2005-07-30 Thread James Youngman
Gnulib offers an implementation of the fts directory hierarchy searcher. It is this implementation on which several parts of coreutils rely for their 'recursive' behaviour. One of the benefits obtained in this way is that coreutils can handle very deeply nested directory trees. I have made a C