[PATCH] Fix compilation warning.

xargs.c: In function 'fopen_cloexec_for_read_only': xargs.c:387:1: warning: control reaches end of non-void function [-Wreturn-type] * xargs/xargs.c (fopen_cloexec_for_read_only): Return result. --- xargs/xargs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xargs/xargs.c b/xargs/xargs.c ind

Ping: [PATCH] Fix save_cwd/restore_cwd error diagnostics.

Ping. -- ldv pgpzI0XxJTV2r.pgp Description: PGP signature

[PATCH] Fix save_cwd/restore_cwd error diagnostics.

Before this change, a pointer to struct saved_cwd was used in place of char*, leading to incorrect error diagnostics, e.g.: $ chmod a-x . && find / -maxdepth 0 -exec true \; find: Failed to change directory: : Permission denied find: failed to restore initial working directory: : Permission

Re: Regression: "find dir/. -type d -empty -delete" claims 'unsuccessful', breaking scripts.

On Wed, Nov 20, 2013 at 04:47:38PM -0800, Linda Walsh wrote: > On 18/11/2013 16:29, Dmitry V. Levin wrote: > >On Mon, Nov 18, 2013 at 03:55:52PM -0800, Linda A. Walsh wrote: > >>In coreutils 8.21-7.1.3. > >> > >>It has been standard to use "."

Re: Regression: "find dir/. -type d -empty -delete" claims 'unsuccessful', breaking scripts.

On Mon, Nov 18, 2013 at 03:55:52PM -0800, Linda A. Walsh wrote: > In coreutils 8.21-7.1.3. > > It has been standard to use "." in a directory to mean it's contents > on a recursive or copy (compare cp -al src/. dst/.). > > However, "find dir/. -type d -empty -delete" works, but Does it? $ mkd

[ping] [PATCH] find: fix potential buffer overflow in -execdir and -okdir

ping? On Thu, May 16, 2013 at 03:48:21AM +0400, Dmitry V. Levin wrote: > * lib/buildcmd.c (bc_push_arg): Take prefix length into account > to avoid state->argbuf overflow. > * NEWS: Mention this fix. > --- > > It would be a security issue if one could control factors trigger

[PATCH] find: fix potential buffer overflow in -execdir and -okdir

EWS | 2 ++ lib/buildcmd.c | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e6914ff..7b4f3e0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-05-15 Dmitry V. Levin + + find: fix potential buffer overflow in -execdir and -ok

[bug #38658] If the command exec() fails, xargs terminates prematurely

Follow-up Comment #3, bug #38658 (project findutils): http://pubs.opengroup.org/onlinepubs/009695399/utilities/xargs.html ___ Reply to this item at: ___

[bug #38658] If the command exec() fails, xargs terminates prematurely

Follow-up Comment #1, bug #38658 (project findutils): POSIX states: "If a command line meeting the specified requirements cannot be assembled, the utility cannot be invoked, an invocation of the utility is terminated by a signal, or an invocation of the utility exits with exit status 255, the xarg

[bug #38356] xargs -P option creates wrong result

Follow-up Comment #5, bug #38356 (project findutils): Try "grep --line-buffered", it might help avoiding output mangling. I suppose xargs documentation could mention that it is duty of parallelized processes executed by xargs -P to care of potential output mangling. _

Re: [PATCH] find: use FTS_VERBATIM

On Sat, Dec 15, 2012 at 02:33:09PM +, James Youngman wrote: > On Sun, Nov 18, 2012 at 2:06 AM, Dmitry V. Levin wrote: > > The recent change v0.0-7611-g3a9002d in gnulib that made fts_open strip > > trailing slashes from input path names had a negative impact on > > finduti

[PATCH] find: use FTS_VERBATIM

|6 ++ find/ftsfind.c |2 +- gnulib |2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3efc4ad..ba2408a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2012-11-17 Dmitry V. Levin + + find: use FTS_VERBATIM

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

On Fri, Nov 16, 2012 at 09:52:06PM +, James Youngman wrote: > Did anybody do any further work on whether it worked best to fix this > in gnulib or in findutils? As I said, my proposal is to introduce a new FTS_ flag that would make fts_open behave as before that change, and use this flag in fi

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

On Thu, Nov 01, 2012 at 06:22:32AM -0600, Eric Blake wrote: > On 10/31/2012 05:28 PM, Dmitry V. Levin wrote: > > On Tue, Sep 04, 2012 at 01:09:24PM +0200, Jim Meyering wrote: > > [...] > >> Here's the revised commit: > >> > >> Subject: [PATCH] fts:

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

On Tue, Sep 04, 2012 at 01:09:24PM +0200, Jim Meyering wrote: [...] > Here's the revised commit: > > >From 3a9002d3cc63da7110f133b1040d2d2b0aad8305 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Tue, 4 Sep 2012 11:36:38 +0200 > Subject: [PATCH] fts: reduce two or more trailing slashes to j

Re: find acting weird

Hi, On Wed, May 26, 2010 at 01:42:53PM +0400, Юрий Пухальский wrote: > > I'm trying to remove the directories with find -exec and i've > encountered that for some reason the behaviour is strange. I've tested > with 4.1.20, 4.2.27 and 4.4.2. > I'm doing the following: > > devfe:~>mkdir -p findtes

Re: git mirror of the CVS repository for findutils

On Sun, Mar 09, 2008 at 05:40:33PM +, James Youngman wrote: > There is now a read-only mirror of the CVS repoistory available at: > > http://git.sv.gnu.org/gitweb/?p=findutils.git;a=summary > > It syncs from cvs every 30 minutes. It seems to broken atm: all branches except FINDUTILS and all

Re: [Findutils-patches] [PATCH] -delete requires -depth

On Thu, Aug 23, 2007 at 11:11:23AM +0100, James Youngman wrote: > I am proposing to make this change in findutils-4.3.9.Any objections? > > On 8/23/07, James Youngman <[EMAIL PROTECTED]> wrote: > > 2007-08-23 James Youngman <[EMAIL PROTECTED]> > > > > The -delete action now requires

Re: How ready is findutils 4.3.x for use as a "stable" release?

On Mon, Aug 20, 2007 at 12:15:33PM +0100, James Youngman wrote: [...] > I think my personal preference would be to make a 4.4.0 "stable" > release, and merge Leslie's changes into a new "development" release > 4.5.x. +1 I have to maintain an "old stable" 4.2.x package for a while, though. -- ld

Re: updatedb.c: call find via exec()

On Wed, Apr 11, 2007 at 10:25:23AM +0200, Leslie P. Polzer wrote: > I gave this some thought and it seems to be the best solution. > > Any other ideas? Looks like I missed context of this question, sorry. -- ldv pgpwS8SkLD7eW.pgp Description: PGP signature ___

Re: Status of updatedb

On Sat, Dec 17, 2005 at 11:42:53PM +, James Youngman wrote: > One more wheel and we'll have enough for a car :) I found one more wheel! :) Yet another locate implementation is mlocate, see http://www.redhat.com/archives/fedora-devel-list/2006-February/msg01060.html -- ldv pgpLAW06gQb4j.p

Re: Google Summer of Code - findutils project ideas?

On Mon, Apr 17, 2006 at 03:27:58PM +0100, James Youngman wrote: [...] > However, there also needs to be a backup mentor in case the first one > becomes unresponsive, falls ill, goes on vacation, etc. Who would be > willing to act as backup? I can help if necessary. -- ldv pgpb4TT20EBAj.pgp D

[bug #15384] find misbehaves when parent directory is not readable

URL: Summary: find misbehaves when parent directory is not readable Project: findutils Submitted by: ldv Submitted on: Thu 01/05/06 at 19:53 Category: find

Re: Status of updatedb

On Sat, Dec 17, 2005 at 11:42:53PM +, James Youngman wrote: > On Sun, Dec 18, 2005 at 01:36:52AM +0300, Dmitry V. Levin wrote: > > > You can have a look at my own slocate I wrote several years ago > > (based on glibc's fts and GNU locate's frencode) which de

Re: Status of updatedb

On Sat, Dec 17, 2005 at 10:26:38PM +, James Youngman wrote: > On Sat, Dec 17, 2005 at 10:49:08AM +0100, Andreas Metzler wrote: > > On 2005-11-30 James Youngman wrote: [...] > > and that in find | sort | datahandling | writeupdatedb only > > writeupdatedb should run as superuser. > > Good point

[bug #15181] compilation warning: implicit declaration of function 'parse_openparen'

Follow-up Comment #2, bug #15181 (project findutils): Actually I had to apply similar patch a few days ago. It resolves other non-gnulib warnings, too. ___ Additional Item Attachment: File name: findutils-4.2.27-alt-warnings.patch Size:4 K

Re: xargs: exec's with too many arguments

On Tue, Nov 22, 2005 at 11:35:15AM +, Tim Waugh wrote: > On Sat, Nov 19, 2005 at 08:30:50AM +, James Youngman wrote: > > > Thanks for discovering and fixing the bug. > > With 4.2.26 I'm finding a test suite failure with the new tests on > x86_64: Same here. > Running > /tmp/twaugh/find

[bug #14842] Incorrect "Cannot allocate memory" error in some cases.

Follow-up Comment #2, bug #14842 (project findutils): James, please update lib/savedir.c (and lib/getcwd.c as well) from gnulib. ___ Reply to this item at: _

[bug #14587] -L does not default to -L1 and results in error

Additional Item Attachment, bug #14587 (project findutils): File name: xargs.c.diff Size:0 KB Proposed error message fix as suggested by Eric Blake __

[bug #14399] broken version of gl_INCLUDED_REGEX macro

URL: Summary: broken version of gl_INCLUDED_REGEX macro Project: findutils Submitted by: ldv Submitted on: Sun 09/04/05 at 15:36 Category: find

[patch #4103] Additional documentation tweaks for -execdir/-okdir actions

URL: Summary: Additional documentation tweaks for -execdir/-okdir actions Project: findutils Submitted by: ldv Submitted on: Wed 06/15/05 at 23:03 Category: do

Re: [bug #13303] find should filter out non-printable characters if outputting to tty

On Sun, Jun 05, 2005 at 03:07:24PM +0100, James Youngman wrote: > On Sun, Jun 05, 2005 at 12:02:59PM +, Andreas Metzler wrote: > > > Afaict dumping non printable characters to the terminal usually is not > > wanted > > and should not be default. > > > > Posix says: > > -print > > The pri

[bug #13303] find should filter out non-printable characters if outputting to tty

Follow-up Comment #3, bug #13303 (project findutils): I like the idea, but the patch is quite large. One mistake found so far: the change to pred_fprint() will result to double print. P.S. Could you please add -p option to "cvs diff" command next time? __

[patch #3701] Additional tweaks for -execdir/-okdir actions

Follow-up Comment #4, patch #3701 (project findutils): Additional documentation tweaks for -execdir/-okdir actions. ___ Additional Item Attachment: File name: findutils-4.2.18-alt-find-execdir-okdir.patch Size:4 KB rest of original patch <

[bugs #12230] wrong result of "find -execdir {} +" compared to -exec

URL: Summary: wrong result of "find -execdir {} +" compared to -exec Project: findutils Submitted by: ldv Submitted on: Sun 03/06/2005 at 17:42 Category: find

[bugs #12044] find still hangs on dead NFS filesystems on Solaris

Follow-up Comment #13, bugs #12044 (project findutils): Ouch, safely_chdir_lstat() gets too complicated to be sure it will work as expected. I see one potential minor issue with findutils-nostatmountpt-1.patch: In safely_chdir_lstat(), if wd_sanity_check() call fails and RETRY_IF_SANITY_CHECK_F

[bugs #12044] find still hangs on dead NFS filesystems on Solaris

Follow-up Comment #5, bugs #12044 (project findutils): I like first (chdir/fchdir-back/retry) approach more than second (stat./chdir/stat..). I can imagine situation where one can subvert subdirectory with symlink to another subdirectory in the same directory. Second check cannot catch this situ

[bugs #12099] O_NOFOLLOW may be erroneously disabled

URL: Summary: O_NOFOLLOW may be erroneously disabled Project: findutils Submitted by: ldv Submitted on: Tue 02/22/2005 at 15:11 Category: find

[bugs #11879] all mount-points lstat()-ed, but shouldn't be

Follow-up Comment #7, bugs #11879 (project findutils): Looks like this issue is now platform-dependent: find version 4.2.18 no longer stats filesystems on GNU/Linux. ___ This item URL is:

[bugs #11879] all mount-points lstat()-ed, but shouldn't be

Follow-up Comment #3, bugs #11879 (project findutils): 1. this hunk looks odd: + time(NULL); + opendir("."); + time(NULL); + 2. safely_chdir_nofollow() will switch to safely_chdir_lstat() if open() fails due to some race. 3. I'd prefer to avoid runtime fallback to safely_chdir_lstat() on pl